PCI:pciehp:remove unnecessary volatile in struct controller
From: Ming Lei <[email protected]>
Proper memory barriers have been added to order accesses to ->cmd_busy, so volatile declaration for cmd_busy can be removed.
Signed-off-by Ming Lei <[email protected]>
--- drivers/pci/hotplug/pciehp.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/pci/hotplug/pciehp.h +1 -1
@@ -96,7 +96,7 @@ struct controller {u32 slot_cap;u8 cap_base;struct timer_list poll_timer; -volatile int cmd_busy; +int cmd_busy; unsigned int no_cmd_complete:1; };
Signature · 1 line
1.5.6.rc2.45.gdc92c
Quoted 16 lines · On Wednesday, July 16, 2008 7:54 am [email protected] wrote:
From: Ming Lei <[email protected]>
Proper memory barriers have been added to order accesses to ->cmd_busy, so volatile declaration for
cmd_busycan be removed.Signed-off-by Ming Lei <[email protected]>--- drivers/pci/hotplug/pciehp.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/pci/hotplug/pciehp.h +0
-0
drivers/pci/hotplug/pciehp.h struct controller { · line 101
Quoted 7 lines
drivers/pci/hotplug/pciehp.h +1
-1@@ -96,7 +96,7 @@ struct controller {u32 slot_cap;u8 cap_base;struct timer_list poll_timer; -volatile int cmd_busy; +int cmd_busy; unsigned int no_cmd_complete:1; };
Yeah I saw the first one, just hadn't had a chance to reply/apply yet. I just applied it to my linux-next branch and pushed.
Jesse