Skip to contentSkip to conversation

synclink_gt fix locking in error path of rx enable

PATCH New Paul Fulghum 1 participant 1 message Jul 18, 2008 Char and misc drivers

lore
Share & tools
lore

Paul Fulghum

author
#0 lore raw

PATCH 1/1 synclink_gt fix locking in error path of rx enable

Fix locking in error path of rx_enable() introduced by synclink_gt-add-rx-dma-buffer-fill-level-control patch.

Signed-off-by Paul Fulghum <[email protected]>
drivers/char/synclink_gt.c +3 -1
@@ -2700,8 +2700,10 @@ static int rx_enable(struct slgt_info *i
 	 */
 	rbuf_fill_level = ((unsigned int)enable) >> 16;
 	if (rbuf_fill_level) {
-		if ((rbuf_fill_level > DMABUFSIZE) || (rbuf_fill_level % 4))
+		if ((rbuf_fill_level > DMABUFSIZE) || (rbuf_fill_level % 4)) {
+			spin_unlock_irqrestore(&info->lock, flags);
 			return -EINVAL;
+		}
 		info->rbuf_fill_level = rbuf_fill_level;
 		rx_stop(info); /* restart receiver to use new fill level */
 	}