cifs: suggestions for a few more sparse warnings
Quoted 10 lines · Harvey Harrison
Here's a patch for some of the other warnings, but the
cifsacl.cbit needs a comment I think.Harvey
fs/cifs/cifsacl.c +0
-0
fs/cifs/cifsacl.c static void copy_sec_desc(const struct cifs_ntsd *pntsd, · line 175
Quoted 9 lines
fs/cifs/cifsacl.c +1
-2@@ -169,8 +169,7 @@ static void copy_sec_desc(const struct cifs_ntsd *pntsd,for (i =0 ; i <6 ; i++) ngroup_sid_ptr->authority[i] = group_sid_ptr->authority[i];for (i =0 ; i <5 ; i++) - ngroup_sid_ptr->sub_auth[i] = -cpu_to_le32 (group_sid_ptr->sub_auth[i]); +cpu_to_le32s (&group_sid_ptr->sub_auth[i]);return ; }
No - the cifsacl one looks like just a bug - there should not be an endian conversion here.
Shirish,
Would you verify?
Signature · 3 lines
Thanks, Steve
Steve,
Quoted 19 lines · Steve French
Quoted 17 lines · Harvey Harrison
Here's a patch for some of the other warnings, but the
cifsacl.cbit needs a comment I think.Harvey
fs/cifs/cifsacl.c +1
-2@@ -169,8 +169,7 @@ static void copy_sec_desc(const struct cifs_ntsd *pntsd,for (i =0 ; i <6 ; i++) ngroup_sid_ptr->authority[i] = group_sid_ptr->authority[i];for (i =0 ; i <5 ; i++) - ngroup_sid_ptr->sub_auth[i] = -cpu_to_le32 (group_sid_ptr->sub_auth[i]); +cpu_to_le32s (&group_sid_ptr->sub_auth[i]);
Quoted 6 lines
fs/cifs/cifsacl.c static void copy_sec_desc(const struct cifs_ntsd *pntsd, · line 175
Quoted 2 lines
fs/cifs/cifsacl.c +0
-0return ; }No - the cifsacl one looks like just a bug - there should not be an endian conversion here.
I think you are right, there should not be any conversion since the sub authorities would be in little endin format when we did get_cifs_acl prior to this copy.
Quoted 8 lines
Shirish,
Would you verify?--
Thanks,Steve