Skip to contentSkip to conversation

ppc4xx: Optimizations/Cleanups for IBM DDR2 Memory Controller

U-Boot Prodyut Hazarika 3 participants 6 messages Aug 27, 2008 – Sep 2, 2008

lore
Share & tools
lore
#1 lore raw
Quoted 9 lines · Prodyut Hazarika
Quoted 1 line

From bdc99201a532b040b3d346fca5acff8332d670e4 Mon Sep 17 00:00:00 2001

From: Prodyut Hazarika <[email protected]>
Date: Wed, 27 Aug 2008 16:26:36 -0700
Subject: [PATCH] Optimizations/Cleanups for IBM DDR2 memory controller
Removed Magic numbers from Initialization preload registers Tested with Kilauea, Glacier, Canyonlands and Katmai boards About 5-7% improvement seen for LMBench memtests

Applied to u-boot-ppc4xx repository.

Somehow your patch was malformatted though. Please see the ">From bdc..." above. This should not be included in the patch mail. Did you create this patch with git format-patch and send it with git send-email?

And please don't indent the commit text and add one empty line before the s-o-f line.

I fixed this manually now but please take more care next time.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================

#2 lore raw

Hi Stefan,
Thanks.

Quoted 3 lines

Somehow your patch was malformatted though. Please see the ">From bdc..." above. This should not be included in the patch mail. Did you create this patch with git format-patch and send it with git send-email?

I created the patch using git format-patch. I had applied the patch using git-am in my local repo before sending, and it applied fine. I used Evolution on Linux to send the patch using the instructions given in Documentation/email-clients in Linux kernel tree. I have problems using git send-email because we send emails using the Exchange server.

Quoted 2 lines

And please don't indent the commit text and add one empty line before the s-o-f line.

I will take care of the that.

Regards,
Prodyut Hazarika

==================
Staff S/W Engineer
AMCC
==================

#3 lore raw

Prodyut,

Quoted 6 lines · Prodyut Hazarika
Quoted 3 lines

Somehow your patch was malformatted though. Please see the ">From bdc..." above. This should not be included in the patch mail. Did you create this patch with git format-patch and send it with git send-email?

I created the patch using git format-patch. I had applied the patch using git-am in my local repo before sending, and it applied fine.

So far so good. :)

Quoted 4 lines

I used
Evolution on Linux to send the patch using the instructions given in Documentation/email-clients in Linux kernel tree. I have problems using git send-email because we send emails using the Exchange server.

OK, then this Evolution step seems to have introduced this problem. Too bad that even the instructions in the Linux Documention describe this correctly. Sorry, I can't help you here, I have no experience with Evolution. Perhaps somebody else can jump in here.

Quoted 4 lines
Quoted 2 lines

And please don't indent the commit text and add one empty line before the s-o-f line.

I will take care of the that.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================

#4 lore raw
Quoted 9 lines · Stefan Roese
Quoted 4 lines

I used
Evolution on Linux to send the patch using the instructions given in Documentation/email-clients in Linux kernel tree. I have problems using git send-email because we send emails using the Exchange server.

OK, then this Evolution step seems to have introduced this problem. Too bad that even the instructions in the Linux Documention describe this correctly. Sorry, I can't help you here, I have no experience with Evolution. Perhaps somebody else can jump in here.

Just make sure to select "preformat" instead of "normal" before you "insert" -> text file" on your patch.

jdl

#5 lore raw

[U-Boot] ppc4xx: Optimizations/Cleanups for IBM DDR2 MemoryController

Quoted 3 lines

Just make sure to select "preformat" instead of "normal" before you "insert" -> text file" on your patch.

Thanks. I will try that next time I post any patch.

Regards,
Prodyut Hazarika