Skip to contentSkip to conversation

EFS: Don't set f_fsid in statfs()

PATCH David Woodhouse 1 participant 1 message Sep 2, 2008 VFS

lore
Share & tools
lore
#0 lore raw

We don't have any suitable value to put in f_fsid. Using EFS_MAGIC really isn't a good idea, because all EFS file systems will have the same f_fsid then.

---
 fs/efs/super.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
fs/efs/super.c +0 -2
index 567b134..73b19cf 100644
@@ -341,8 +341,6 @@ static int efs_statfs(struct dentry *dentry, struct kstatfs *buf) {
 			sb->inode_blocks *
 			(EFS_BLOCKSIZE / sizeof(struct efs_dinode));
 	buf->f_ffree   = sb->inode_free;	/* free inodes */
-	buf->f_fsid.val[0] = (sb->fs_magic >> 16) & 0xffff; /* fs ID */
-	buf->f_fsid.val[1] =  sb->fs_magic        & 0xffff; /* fs ID */
 	buf->f_namelen = EFS_MAXNAMELEN;	/* max filename length */
 
 	return 0;
Signature · 6 lines
1.5.5.1


-- 
David Woodhouse                            Open Source Technology Centre
[email protected]                              Intel Corporation