Fix compiler warning in mpc8xxx ddr code
PATCH 1/1 Fix compiler warning in mpc8xxx ddr code
ctrl_regs.c: In function 'compute_fsl_memctl_config_regs':
ctrl_regs.c:523: warning: 'caslat' may be used uninitialized in this function ctrl_regs.c:523: note: 'caslat' was declared here
Add a warning in DDR1 case if cas_latency isn't a value we know about.
--- cpu/mpc8xxx/ddr/ctrl_regs.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-)
cpu/mpc8xxx/ddr/ctrl_regs.c +4 -2
@@ -520,7 +520,7 @@ static void set_ddr_sdram_mode(fsl_ddr_cfg_regs_t *ddr,unsigned int wr;/* Write Recovery */ unsigned int dll_res;/* DLL Reset */ unsigned int mode;/* Normal=0 or Test=1 */ -unsigned int caslat;/* CAS# latency */ +unsigned int caslat =0 ;/* CAS# latency */ /* BT: Burst Type (0=Sequential, 1=Interleaved) */ unsigned int bt;unsigned int bl;/* BL: Burst Length */
@@ -572,7 +572,9 @@ static void set_ddr_sdram_mode(fsl_ddr_cfg_regs_t *ddr,0x6 ,/* 2.5 clocks */ 0x3 /* 3.0 clocks */ }; - caslat = mode_caslat_table[cas_latency - 1]; + caslat = mode_caslat_table[cas_latency - 1]; + }else { +printf ("Warning: unknown cas_latency %d\n" , cas_latency); }#elif defined(CONFIG_FSL_DDR2) caslat = cas_latency;
Signature · 1 line
1.5.5.1
PATCH 1/1 Fix compiler warning in mpc8xxx ddr code
Quoted 11 lines · Kumar Gala
ctrl_regs.c: In function 'compute_fsl_memctl_config_regs':
ctrl_regs.c:523: warning: 'caslat' may be used uninitialized in this function ctrl_regs.c:523: note: 'caslat' was declared hereAdd a warning in DDR1 case if
cas_latencyisn't a value we know about.Signed-off-by Kumar Gala <[email protected]>--- cpu/mpc8xxx/ddr/ctrl_regs.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-)
Thanks it's fix my warnings
Best Regards,
J.
Wolfgang Denk
AppliedPATCH 1/1 Fix compiler warning in mpc8xxx ddr code
In reply to Kumar GalaDear Kumar Gala,
Quoted 7 lines · In message <[email protected]> you…
ctrl_regs.c: In function 'compute_fsl_memctl_config_regs':
ctrl_regs.c:523: warning: 'caslat' may be used uninitialized in this function ctrl_regs.c:523: note: 'caslat' was declared hereAdd a warning in DDR1 case if
cas_latencyisn't a value we know about.Signed-off-by Kumar Gala <[email protected]>
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Things that try to look like things often do look more like things than things. Well-known fact. - Terry Pratchett, _Wyrd Sisters_