Skip to contentSkip to conversation

Bad FCS flag

DISCUSSION Johannes Berg 2 participants 3 messages Sep 5, 2008 2 messages not in the archive

lore
Share & tools
lore
#0 lore raw

Hi,

Sorry I haven't actually updated my proposal, had other stuff.

Here's a representation of the non-conflict we're running into with RX flags:

* wireshark defines that bit 6 in field 1 ("flags") means "bad FCS".
* the unofficial RX-flags stuff defines that bit 0 in "RX flags" means "bad FCS"

I want to avoid having _two_ "bad FCS" bits and chose the RX flags one to leave room for possible generic flags in "flags"/1, but I don't really care either way.

Opinions?

johannes

A message that is not in the archive (sent off-list or not yet received): 1220646325.11109.21.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org

#2 lore raw
Quoted 8 lines · Johannes Berg

Hi,

Sorry I haven't actually updated my proposal, had other stuff.

Here's a representation of the non-conflict we're running into with RX flags:

* wireshark defines that bit 6 in field 1 ("flags") means "bad FCS".

Johannes,

TCPDump uses this bit, too. I think that we are stuck with it.

Quoted 2 lines

* the unofficial RX-flags stuff defines that bit 0 in "RX flags" means "bad FCS"

Any users of this bit?

I think that TCPDump & Wireshark probably out-number the radiotap interpreters who use the rx-flags bit :-), but I don't know how many drivers there are who write headers with "bad FCS" in the rx flags bit.

Dave

Signature · 2 lines
David Young             OJC Technologies
[email protected]      Urbana, IL * (217) 278-3933 ext 24

A message that is not in the archive (sent off-list or not yet received): [email protected]

#4 lore raw
Quoted 2 lines

TCPDump uses this bit, too. I think that we are stuck with it.

Alright. I'll amend my old proposal to drop the shortGI bit for now (not interested in 11n, let somebody else define those things) and make this the "bad FCS" bit rather than the first bit in "RX flags".

Quoted 4 lines
Quoted 2 lines

* the unofficial RX-flags stuff defines that bit 0 in "RX flags" means "bad FCS"

Any users of this bit?

Not sure, I think we might create it in Linux, but it's easy to change.

Quoted 3 lines

I think that TCPDump & Wireshark probably out-number the radiotap interpreters who use the rx-flags bit :-), but I don't know how many drivers there are who write headers with "bad FCS" in the rx flags bit.

Yeah. I'll mark the RX flags bit as reserved though so we don't run into odd things there.

johannes