Skip to contentSkip to conversation

dmatest: properly handle duplicate DMA channels

PATCH In review Timur Tabi 2 participants 2 messages Sep 18, 2008 dmaengine

lore
Share & tools
lore

Timur Tabi

author
#0 lore raw

PATCH v2 1/1 dmatest: properly handle duplicate DMA channels

Update the the dmatest driver so that it handles duplicate DMA channels properly.

When a DMA client is notified of an available DMA channel, it must check if it has already allocated resources for that channel. If so, it should return DMA_DUP. This can happen, for example, if a DMA driver calls dma_async_device_register() more than once.

---

Replaced list_for_each_entry_safe() with list_for_each_entry()

 drivers/dma/dmatest.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
drivers/dma/dmatest.c +5 -0
index a08d197..422500c 100644
@@ -325,6 +325,11 @@ static enum dma_state_client dmatest_add_channel(struct dma_chan *chan)
 	struct dmatest_thread	*thread;
 	unsigned int		i;
 
+	/* Have we already been told about this channel? */
+	list_for_each_entry(dtc, &dmatest_channels, node)
+		if (dtc->chan == chan)
+			return DMA_DUP;
+
 	dtc = kmalloc(sizeof(struct dmatest_chan), GFP_ATOMIC);
 	if (!dtc) {
 		pr_warning("dmatest: No memory for %s\n", chan->dev.bus_id);
Signature · 1 line
1.5.5
Acked-by on v2 1/1
#1 lore raw
Quoted 9 lines · Timur Tabi

Update the the dmatest driver so that it handles duplicate DMA channels properly.

When a DMA client is notified of an available DMA channel, it must check if it has already allocated resources for that channel. If so, it should return DMA_DUP. This can happen, for example, if a DMA driver calls dma_async_device_register() more than once.