Skip to contentSkip to conversation

mountd: change "unknown host" error message to "unmatched host"

PATCH In review Jeff Layton 2 participants 2 messages Sep 29, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mountd: change "unknown host" error message to "unmatched host"

I've had a few users mention that they find this message confusing:

mount request from unknown host 10.11.14.99 for /export

The hosts are listed in DNS with proper reverse records, so the reason why the host is "unknown" isn't clear. This patch just changes the wording of this error to hopefully make it more clear why the mount request was rejected. This also makes this error message use a format more similar to the other error messages in auth_authenticate().

---
 utils/mountd/auth.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
utils/mountd/auth.c +1 -1
index 2bb708f..dfe61ea 100644
@@ -223,7 +223,7 @@ auth_authenticate(char *what, struct sockaddr_in *caller, char *path)
 		break;
 
 	case unknown_host:
-		xlog(L_WARNING, "%s request from unknown host %s for %s (%s)",
+		xlog(L_WARNING, "refused %s request from %s for %s (%s): unmatched host",
 		     what, inet_ntoa(addr), path, epath);
 		break;
 
Signature · 1 line
1.5.5.1
#1 lore raw
Quoted 11 lines · Jeff Layton

I've had a few users mention that they find this message confusing:

mount request from unknown host 10.11.14.99 for /export

The hosts are listed in DNS with proper reverse records, so the reason why the host is "unknown" isn't clear. This patch just changes the wording of this error to hopefully make it more clear why the mount request was rejected. This also makes this error message use a format more similar to the other error messages in auth_authenticate().

Committed.

steved.