x86: IOMMU setup failures should not be KERN_ERR
PATCH 1/1 x86: IOMMU setup failures should not be KERN_ERR
The number of BIOSes that have an option to enable the IOMMU, or fix anything about its configuration, is vanishingly small. There's no good reason to punish quiet boot for this.
Signed-off-by Adam Jackson <[email protected]>
--- arch/x86/kernel/aperture_64.c | 6 +++--- include/asm-x86/gart.h | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-)
arch/x86/kernel/aperture_64.c +3 -3
@@ -455,11 +455,11 @@ out: force_iommu || valid_agp || fallback_aper_force) { -printk (KERN_ERR +printk (KERN_INFO "Your BIOS doesn't leave a aperture memory hole\n" ); -printk (KERN_ERR +printk (KERN_INFO "Please enable the IOMMU option in the BIOS setup\n" ); -printk (KERN_ERR +printk (KERN_INFO "This costs you %d MB of RAM\n" ,32 << fallback_aper_order);
include/asm-x86/gart.h +3 -3
@@ -52,15 +52,15 @@ static inline int aperture_valid(u64 aper_base, u32 aper_size, u32 min_size)return 0 ;if (aper_base + aper_size >0x100000000ULL ) { -printk (KERN_ERR "Aperture beyond 4GB. Ignoring.\n" ); +printk (KERN_INFO "Aperture beyond 4GB. Ignoring.\n" );return 0 ; }if (e820_any_mapped (aper_base, aper_base + aper_size,E820_RAM )) { -printk (KERN_ERR "Aperture pointing to e820 RAM. Ignoring.\n" ); +printk (KERN_INFO "Aperture pointing to e820 RAM. Ignoring.\n" );return 0 ; }if (aper_size < min_size) { -printk (KERN_ERR "Aperture too small (%d MB) than (%d MB)\n" , +printk (KERN_INFO "Aperture too small (%d MB) than (%d MB)\n" , aper_size>>20 , min_size>>20 );return 0 ; }
Signature · 1 line
1.6.0.1
Ingo Molnar
AppliedQuoted 9 lines · Adam Jackson
The number of BIOSes that have an option to enable the IOMMU, or fix anything about its configuration, is vanishingly small. There's no good reason to punish quiet boot for this.
Signed-off-by Adam Jackson <[email protected]>--- arch/x86/kernel/aperture_64.c | 6 +++--- include/asm-x86/gart.h | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-)
applied to tip/x86/debug, thanks Adam!
Ingo