b43: remove remaining b43_radio_{read|write}16 from main.c
PATCH 2/8 b43: remove remaining b43_radio_{read|write}16 from main.c
The 16 is not necessary anymore and is defnined to read/write.
--- drivers/net/wireless/b43/main.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/b43/main.c +2 -2
@@ -789,7 +789,7 @@ void b43_dummy_transmission(struct b43_wldev *dev)b43_write16 (dev,0x0502 ,0x0030 );if (phy->radio_ver ==0x2050 && phy->radio_rev <=0x5 ) -b43_radio_write16 (dev,0x0051 ,0x0017 ); +b43_radio_write (dev,0x0051 ,0x0017 );for (i =0x00 ; i < max_loop; i++) { value =b43_read16 (dev,0x050E );if (value &0x0080 )
@@ -809,7 +809,7 @@ void b43_dummy_transmission(struct b43_wldev *dev)udelay (10 ); }if (phy->radio_ver ==0x2050 && phy->radio_rev <=0x5 ) -b43_radio_write16 (dev,0x0051 ,0x0037 ); +b43_radio_write (dev,0x0051 ,0x0037 );write_unlock (&wl->tx_lock);spin_unlock_irq (&wl->irq_lock);
Signature · 1 line
1.6.0.2.471.g47a76
Quoted 21 lines · Harvey Harrison
The 16 is not necessary anymore and is defnined to read/write.
Signed-off-by Harvey Harrison <[email protected]>--- drivers/net/wireless/b43/main.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)drivers/net/wireless/b43/main.c +1
-1@@ -789,7 +789,7 @@ void b43_dummy_transmission(struct b43_wldev *dev)b43_write16 (dev,0x0502 ,0x0030 );if (phy->radio_ver ==0x2050 && phy->radio_rev <=0x5 ) -b43_radio_write16 (dev,0x0051 ,0x0017 ); +b43_radio_write (dev,0x0051 ,0x0017 );for (i =0x00 ; i < max_loop; i++) { value =b43_read16 (dev,0x050E );if (value &0x0080 )
drivers/net/wireless/b43/main.c void b43_dummy_transmission(struct b43_wldev *dev) · line 815
Quoted 8 lines
drivers/net/wireless/b43/main.c +1
-1@@ -809,7 +809,7 @@ void b43_dummy_transmission(struct b43_wldev *dev)udelay (10 ); }if (phy->radio_ver ==0x2050 && phy->radio_rev <=0x5 ) -b43_radio_write16 (dev,0x0051 ,0x0037 ); +b43_radio_write (dev,0x0051 ,0x0037 );write_unlock (&wl->tx_lock);spin_unlock_irq (&wl->irq_lock);
NACK. The two extra characters are absolutely harmless, but they do contain useful information. In addition, who knows if a future Broadcom device starts using 32-bit read/writes.
Larry
Quoted 28 lines · On Saturday 04 October 2008 03:36:33 Larry Finger wrote:
Quoted 27 lines · Harvey Harrison
The 16 is not necessary anymore and is defnined to read/write.
Signed-off-by Harvey Harrison <[email protected]>--- drivers/net/wireless/b43/main.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)drivers/net/wireless/b43/main.c +2
-2@@ -789,7 +789,7 @@ void b43_dummy_transmission(struct b43_wldev *dev)b43_write16 (dev,0x0502 ,0x0030 );if (phy->radio_ver ==0x2050 && phy->radio_rev <=0x5 ) -b43_radio_write16 (dev,0x0051 ,0x0017 ); +b43_radio_write (dev,0x0051 ,0x0017 );for (i =0x00 ; i < max_loop; i++) { value =b43_read16 (dev,0x050E );if (value &0x0080 )@@ -809,7 +809,7 @@ void b43_dummy_transmission(struct b43_wldev *dev)udelay (10 ); }if (phy->radio_ver ==0x2050 && phy->radio_rev <=0x5 ) -b43_radio_write16 (dev,0x0051 ,0x0037 ); +b43_radio_write (dev,0x0051 ,0x0037 );
Quoted 6 lines
drivers/net/wireless/b43/main.c void b43_dummy_transmission(struct b43_wldev *dev) · line 815
Quoted 2 lines
drivers/net/wireless/b43/main.c +0
-0write_unlock (&wl->tx_lock);spin_unlock_irq (&wl->irq_lock);NACK. The two extra characters are absolutely harmless, but they do contain useful information. In addition, who knows if a future Broadcom device starts using 32-bit read/writes.
Ok, there are valid reasons for it, there are valid reasons against it...
Can we just agree now that we're not going to apply _any_ cleanups to the PHY code, please? (So I revoke my mail from Sat Oct 4 00:35:35 2008)
Actual bugfixes are welcome, of course.
Signature · 1 line
Greetings Michael.