Skip to contentSkip to conversation

Remove support for the legacy DTS source file format.

PATCH In review Jon Loeliger 2 participants 2 messages Oct 3, 2008 – Oct 4, 2008 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Remove support for the legacy DTS source file format.

Now that all in-kernel-tree DTS files are properly /dts-v1/, remove direct support for the older, un-numbered DTS source file format.

Convert existing tests to /dts-v1/ and remove support for the conversion tests themselves.

For now, though, the conversion tool still exists.

---

I've decided to apply this patch. It may not be popular,
but we're going to move forward here. Several folks at
Freescale agree with me here.

#2 lore raw
In reply to a message not in the archive
Quoted 7 lines · Jon Loeliger

Now that all in-kernel-tree DTS files are properly /dts-v1/, remove direct support for the older, un-numbered DTS source file format.

Convert existing tests to /dts-v1/ and remove support for the conversion tests themselves.

Quoted 8 lines

For now, though, the conversion tool still exists.

---

I've decided to apply this patch. It may not be popular,
but we're going to move forward here. Several folks at
Freescale agree with me here.

As you no doubt expected, I'm not very happy with this.

Updating the test dts files to v1 certainly makes sense. We probably should have done that some time ago. *Except* that you've converted the *_dts0.dts files, which makes no sense since their only purpose was to test the handling of dtsv0 files. This is sloppy, if v0 support is removed from they should be deleted (along with the corresponding pieces of run_tests.sh).

Removing the actual v0 support I think is premature, but I guess we can agree to disagree on this point.

Removing the conversion tests worries me more, however, since I fear that convert-dtsv0 will start bitrotting without testcases to keep it in line. If I get time I might see about a patch which restore at least some of these tests in a way that doesn't require v0 support in dtc itself (possibly including prebuilt dtbs for comparison).

Signature · 4 lines
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson