ALSA: ASoC: TWL4030 codec - fix 256*Fs clock
PATCH 1/1 ALSA: ASoC: TWL4030 codec - fix 256*Fs clock
According to TRM, 256*Fs clock output should be enabled when TWL4030 is in slave mode, not master. This allows sound to work on OMAP3 Pandora, which uses 256*Fs clock.
Signed-off-by Grazvydas Ignotas <[email protected]>
--- sound/soc/codecs/twl4030.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
sound/soc/codecs/twl4030.c +2 -2
@@ -469,11 +469,11 @@ static int twl4030_set_dai_fmt(struct snd_soc_dai *codec_dai,switch (fmt &SND_SOC_DAIFMT_MASTER_MASK ) {case SND_SOC_DAIFMT_CBM_CFM : format &= ~(TWL4030_AIF_SLAVE_EN ); - format |=TWL4030_CLK256FS_EN ; + format &= ~(TWL4030_CLK256FS_EN );break ;case SND_SOC_DAIFMT_CBS_CFS : - format &= ~(TWL4030_CLK256FS_EN ); format |=TWL4030_AIF_SLAVE_EN ; + format |=TWL4030_CLK256FS_EN ;break ;default :return -EINVAL ;
Signature · 1 line
1.5.4.3
Quoted 6 lines · Grazvydas Ignotas
According to TRM, 256*Fs clock output should be enabled when TWL4030 is in slave mode, not master. This allows sound to work on OMAP3 Pandora, which uses 256*Fs clock.
Signed-off-by Grazvydas Ignotas <[email protected]>
Acked-by Steve Sakoman <[email protected]>
As we discussed on IRC you are correct! I apologize for not making this change when I resubmitted the patches last week. Somehow fell off my todo list.
Steve
Quoted 22 lines
--- sound/soc/codecs/twl4030.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)sound/soc/codecs/twl4030.c +2
-2@@ -469,11 +469,11 @@ static int twl4030_set_dai_fmt(struct snd_soc_dai *codec_dai,switch (fmt &SND_SOC_DAIFMT_MASTER_MASK ) {case SND_SOC_DAIFMT_CBM_CFM : format &= ~(TWL4030_AIF_SLAVE_EN ); - format |=TWL4030_CLK256FS_EN ; + format &= ~(TWL4030_CLK256FS_EN );break ;case SND_SOC_DAIFMT_CBS_CFS : - format &= ~(TWL4030_CLK256FS_EN ); format |=TWL4030_AIF_SLAVE_EN ; + format |=TWL4030_CLK256FS_EN ;break ;default :return -EINVAL ;