gpiolib: irq functions not implemented on x86
A message that is not in the archive (sent off-list or not yet received): 1226966206.2731269545548579.JavaMail.root@mail.savoirfairelinux.com
Hi,
I wrote a gpiolib implementation for Technologic Systems TS-5500 boards (x86) custom GPIO lines. Some of their GPIO lines are directly hooked to CPU (ElanSC520) GPIRQ lines, so they can trigger IRQs.
However, looking at arch/x86/include/asm/gpio.h:
/*
* Not implemented, yet.
*/
static inline int gpio_to_irq(unsigned int gpio)
{
return -ENOSYS;
}gpio_to_irq()/irq_to_gpio() are not defined on x86 yet.
Q: Is there a reason not to have it call gpiolib's __gpio_to_irq(), as done for other gpiolib functions defined here ? such as
- return -ENOSYS;
+ return __gpio_to_irq(gpio);
Thanks
Jerome Oufella
Are you sure that I am the intended recipient of this mail?
I'm not involved in the GPIO subsystem at all.
Quoted 28 lines · On Thursday 25 March 2010 20:36:04 Jérôme Oufella wrote:
Hi,
I wrote a gpiolib implementation for Technologic Systems TS-5500 boards (x86) custom GPIO lines. Some of their GPIO lines are directly hooked to CPU (ElanSC520) GPIRQ lines, so they can trigger IRQs.
However, looking at
arch/x86/include/asm/gpio.h:
/*
* Not implemented, yet.
*/
static inline intgpio_to_irq(unsigned int gpio){ return -ENOSYS; }gpio_to_irq()/irq_to_gpio() are not defined on x86 yet.
Q: Is there a reason not to have it call gpiolib's
__gpio_to_irq(), as done for other gpiolib functions defined here ? such as(quoted diff) +1
-1- return -ENOSYS; + return __gpio_to_irq(gpio);Thanks
Jerome Oufella
Signature · 1 line
Greetings, Michael.
Quoted 2 lines · ----- "Michael Buesch
Are you sure that I am the intended recipient of this mail? I'm not involved in the GPIO subsystem at all.
Sorry Michael, I wrote to you as the original author for the questioned code. So being unable to find anyone in charge of the GPIO subsystem, I'm reiterating with the x86 team.
Regards,
Jerome
Quoted 31 lines · On Thursday 25 March 2010 20:36:04 Jérôme Oufella wrote:
Quoted 28 lines
Hi,
I wrote a gpiolib implementation for Technologic Systems TS-5500 boards (x86)custom GPIO lines. Some of their GPIO lines are directly hooked to CPU (ElanSC520) GPIRQ lines, so they can trigger IRQs.
However, looking at
arch/x86/include/asm/gpio.h:
/*
* Not implemented, yet.
*/
static inline intgpio_to_irq(unsigned int gpio){ return -ENOSYS; }gpio_to_irq()/irq_to_gpio() are not defined on x86 yet.
Q: Is there a reason not to have it return gpiolib's
__gpio_to_irq(), as done for other gpiolib functions defined here ? such as:(quoted diff) +1
-1- return -ENOSYS; + return __gpio_to_irq(gpio);Thanks
Jerome OufellaSignature · 1 line
Greetings, Michael.