Skip to contentSkip to conversation

x86: always select SWIOTLB on x86_64

PATCH Applied Joerg Roedel 3 participants 3 messages Nov 18, 2008 – Nov 19, 2008 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: always select SWIOTLB on x86_64

Impact: fixes korg bugzilla 11980

A kernel for a 64bit x86 system should always contain the swiotlb code in case it is booted on a machine without any hardware IOMMU supported by the kernel and more than 4GB of RAM. This patch changes Kconfig to always compile swiotlb into the kernel for x86_64.

---
 arch/x86/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/Kconfig +1 -1
index 93224b5..669c6d5 100644
@@ -566,7 +566,7 @@ config AMD_IOMMU
 
 # need this always selected by IOMMU for the VIA workaround
 config SWIOTLB
-	bool
+	def_bool y if X86_64
 	help
 	  Support for software bounce buffers used on x86-64 systems
 	  which don't have a hardware IOMMU (e.g. the current generation
Signature · 1 line
1.5.6.4
Applied
#1 lore raw
Quoted 7 lines · Joerg Roedel

Impact: fixes korg bugzilla 11980

A kernel for a 64bit x86 system should always contain the swiotlb code in case it is booted on a machine without any hardware IOMMU supported by the kernel and more than 4GB of RAM. This patch changes Kconfig to always compile swiotlb into the kernel for x86_64.

Quoted 6 lines
---
 arch/x86/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

applied to tip/x86/iommu, thanks Joerg!

Ingo

#2 lore raw
In reply to Joerg Roedel
Quoted 6 lines · On Tue, 18 Nov 2008 12:44:21 +0100 Joerg Roedel <[email protected]> wrote:

Impact: fixes korg bugzilla 11980

A kernel for a 64bit x86 system should always contain the swiotlb code in case it is booted on a machine without any hardware IOMMU supported by the kernel and more than 4GB of RAM. This patch changes Kconfig to always compile swiotlb into the kernel for x86_64.

Yeah, as I wrote in a different thread, I think that it makes sense to enable SWIOTLB at all times:

http://marc.info/?l=linux-kernel&m=122593287501949&w=2

An option asking an user if he has more than 4GB RAM or not, doesn't make sense much.

BTW, you can also remove the help description, right?

Quoted 26 lines
---
 arch/x86/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/Kconfig +1 -1
index 93224b5..669c6d5 100644
@@ -566,7 +566,7 @@ config AMD_IOMMU
 
 # need this always selected by IOMMU for the VIA workaround
 config SWIOTLB
-	bool
+	def_bool y if X86_64
 	help
 	  Support for software bounce buffers used on x86-64 systems
 	  which don't have a hardware IOMMU (e.g. the current generation
Signature · 8 lines
1.5.6.4


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/