Char: n_tty, include module.h
PATCH 1/1 Char: n_tty, include module.h
Hi,
this is a ldisc-n_tty-export-all-n_tty-ldisc-methods.patch fix.
--
Since we are using EXPORT_SYMBOL, we should include linux/module.h
--- drivers/char/n_tty.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/char/n_tty.c +1 -0
@@ -41,6 +41,7 @@#include <linux/timer.h> #include <linux/ctype.h> #include <linux/mm.h> +#include <linux/module.h> #include <linux/string.h> #include <linux/slab.h> #include <linux/poll.h>
Signature · 1 line
1.6.0.4
Quoted 3 lines · On Wed, 3 Dec 2008 16:21:51 +0100 Jiri Slaby <[email protected]> wrote:
Hi,
this is a ldisc-n_tty-export-all-n_tty-ldisc-methods.patch fix.
NAK and NAK the patch needing it.
Once PPS is in this can be revisted by adding the almost identical N_PPS ldisc into n_tty with a couple of different handlers (notably some of the termios flags need to be handled differently)
Quoted 8 lines · On Wed, 3 Dec 2008 15:35:37 +0000 Alan Cox <[email protected]> wrote:
Quoted 3 lines · On Wed, 3 Dec 2008 16:21:51 +0100 Jiri Slaby <[email protected]> wrote:
Hi,
this is a ldisc-n_tty-export-all-n_tty-ldisc-methods.patch fix.
NAK and NAK the patch needing it.
Late :(
Quoted 1 line
Once PPS is in
PPS can't go in without this?
Perhaps I can drop pps-serial-clients-support.patch, dunno.
Quoted 3 lines
this can be revisted by adding the almost identical
N_PPSldisc inton_ttywith a couple of different handlers (notably some of the termios flags need to be handled differently)
Quoted 7 lines
Quoted 1 line
NAK and NAK the patch needing it.
Late :(
Quoted 1 line
Once PPS is in
PPS can't go in without this?
PPS stands alone without the tty parts. Once the core PPS bits are accepted (Ingo seems to be silent on that ?) I'll redo the N_PPS tty bits.
Quoted 10 lines · Andrew Morton
Quoted 7 lines · On Wed, 3 Dec 2008 15:35:37 +0000 Alan Cox <[email protected]> wrote:
Quoted 3 lines · On Wed, 3 Dec 2008 16:21:51 +0100 Jiri Slaby <[email protected]> wrote:
Hi,
this is a ldisc-n_tty-export-all-n_tty-ldisc-methods.patch fix.
Quoted 7 lines
Quoted 1 line
NAK and NAK the patch needing it.
Late :(
Quoted 1 line
Once PPS is in
PPS can't go in without this?
No, PPS works perfectly without that patch.
Quoted 1 line
Perhaps I can drop pps-serial-clients-support.patch, dunno.
I think you can drop the last fix.
Ciao,
Rodolfo
Signature · 4 lines
GNU/Linux Solutions e-mail: [email protected] Linux Device Driver [email protected] Embedded Systems phone: +39 349 2432127 UNIX programming skype: rodolfo.giometti