Skip to contentSkip to conversation

Status of Beagle Board

DISCUSSION Hiremath, Vaibhav 2 participants 6 messages May 8, 2009 – May 12, 2009 17 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): FD6982799649459A93E724A62BF2E64F@LinHPNotebook

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#17 lore raw

Hi Vaibhav Hiremath,

My application can work in OMAP3 EVM and other v4l2 platform, but there is another issue in beagle board. as follow:

1. NormalSize() -> RequestBuffer() -> mmap()
2. playing...
3. FullScreen() -> VIDIOC_STREAMOFF

                         -> munmap()
                         -> VIDIOC_REQBUFS
                         -> VIDIOC_QUERYBUF
                         -> RequestBuffer() -> mmap()
                         -> VIDIOC_S_CROP
                         -> VIDIOC_S_FMT
                         -> VIDIOC_QBUF
                         -> VIDIOC_STREAMON

When I want to call VIDIOC_REQBUFS in FullScreen(), it always fail.

Best Regards,
George.Qiao

============================

Quoted 183 lines

Great, please see my comments in-lined below -

Thanks,
Vaibhav Hiremath
Platform Support Products
Texas Instruments Inc
Ph: +91-80-25099927

Quoted 40 lines

-----Original Message-----
From: George.Qiao [mailto:[email protected]]
Sent: Thursday, May 07, 2009 3:51 PM
To: Hiremath, Vaibhav
Cc: Syed Mohammed, Khasim; Shah, Hardik; [email protected]; Bill Lin; [email protected]; Chatterjee, Amit; Andrews, Gerard; Kridner, Jason; 'Bangfei Jin'; 'Xuejun Dong'; 'YangCai'; [email protected]
Subject: Re: Status of Beagle Board

Dear Vaibhav Hiremath,

I can play video by v4l2 now! Thank you!

I have add code in board-omap3beagle.c :

#ifdef CONFIG_FB_OMAP2
static struct resource omap3beagle_vout_resource[3 - CONFIG_FB_OMAP2_NUM_FBS] = {
};
#else
static struct resource omap3beagle_vout_resource[2] = { };
#endif

static struct platform_device omap3beagle_vout_device = {
.name = "omap_vout",
.num_resources = ARRAY_SIZE(omap3beagle_vout_resource),
.resource = &omap3beagle_vout_resource[0],
.id = -1,
};

static struct platform_device *omap3_beagle_devices[] __initdata = {
    &beagle_dss_device,
    &leds_gpio,
    &keys_gpio,
    &omap3beagle_vout_device,
};
Quoted 9 lines

I have got some omapdss error and voutBuffer Size. as follow:

omapdss: Could not find exact pixel clock. Requested 23500 kHz, got 24000 kHz
omapdss error: display already enabled
omap_voutDisplay already enabled
omapdss error: display already enabled
omap_voutDisplay already enabled

[Hiremath, Vaibhav] This is not an error as such, it warning message. Actually here we are trying to enable the display which has already been enabled by Fbdev. We can suppress this message, atleast during init.

Quoted 6 lines

omap_voutBuffer Size = 3686400
omap_vout: registered and initialized video device 0 [v4l2] omap_voutBuffer Size = 3686400
omap_vout: registered and initialized video device 1 [v4l2]

[Hiremath, Vaibhav] This is just a debug massage; it is neither a error nor a warning. So don't worry.

Can you share the code-base or submit the patches to the list, so that interested people can use it.

Quoted 104 lines

Could I change 'voutBuffer Size'? How to fix it?

Best Regards,
George.Qiao

=======================

Quoted 2 lines

Yes Definitely this is the issue. If the platform_device.name

doesn't match with the platform_driver.driver.name then your probe function will not be called at all.

Quoted 2 lines

Can you just copy the board-omap3evm.c changes related to

V4L2/DSS2 and give a shot? I think it should work straight away.

Quoted 47 lines

Please let me know if you need any further clarification or help.

Thanks,
Vaibhav Hiremath
Platform Support Products
Texas Instruments Inc
Ph: +91-80-25099927

Quoted 37 lines

-----Original Message-----
From: George.Qiao [mailto:[email protected]]
Sent: Thursday, May 07, 2009 12:55 PM
To: Hiremath, Vaibhav
Cc: Syed Mohammed, Khasim; Shah, Hardik; [email protected]; Bill Lin; [email protected]; Chatterjee, Amit; Andrews, Gerard; Kridner, Jason; 'Bangfei Jin'; 'Xuejun Dong'; 'YangCai'; [email protected]
Subject: Re: Status of Beagle Board

Hi Hiremath, Vaibhav,

Thank you very much for your instant response!

I've checked the file 'board-omap3beagle.c' and found nothing looking
like omap_vout in it, no platform_device, either. And I've also compared
it with board-omap3evm.c.

Below is some difference between them:

board-omap3evm.c has:
*+static struct platform_device omap3evm_vout_device = {
**+ .name = "omap_vout",
...
}
*
But 'board-omap3beagle.c' does not have anything looking like:

*+static struct platform_device omap3beagle_vout_device = {*
*+ .name = "omap_vout",
...
}
*
So, I think there's no patch on V4L2 for beagle done and this is

the

Quoted 9 lines
Quoted 9 lines

root cause of this issue. Do you agree with me? Thanks a lot.

Best Regards,
George.Qiao
===================================

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

Hi George,

I have looked into your config file and it looks ok to me.

Can you conform that, you have added "platform_device"

definitions

Quoted 5 lines
Quoted 5 lines

in board-omap3beagle.c?

Quoted 2 lines

Can you please create complete patch on top of your baseline (O-

L

Quoted 15 lines
Quoted 13 lines

and Tomi's tree), so that I can review that directly? I will be seeing complete changes done for beagle.

Quoted 9 lines

Thanks,
Vaibhav Hiremath
Platform Support Products
Texas Instruments Inc
Ph: +91-80-25099927

#18 lore raw
Quoted 10 lines

-----Original Message-----
From: George.Qiao [mailto:[email protected]]
Sent: Friday, May 08, 2009 11:57 AM
To: Hiremath, Vaibhav
Cc: Syed Mohammed, Khasim; Shah, Hardik; [email protected]; Bill Lin; [email protected]; Chatterjee, Amit; Andrews, Gerard; Kridner, Jason; 'Bangfei Jin'; 'Xuejun Dong'; 'YangCai'; [email protected]
Subject: Re: Status of Beagle Board

Quoted 6 lines

Hi Vaibhav Hiremath,

My application can work in OMAP3 EVM and other v4l2 platform, but there
is another issue in beagle board. as follow:

[Hiremath, Vaibhav] Are you saying, same application works on OMAP3EVM but fails on beagle board?

Quoted 12 lines

1. NormalSize() -> RequestBuffer() -> mmap()
2. playing...
3. FullScreen() -> VIDIOC_STREAMOFF

                          -> munmap()
                          -> VIDIOC_REQBUFS
                          -> VIDIOC_QUERYBUF
                          -> RequestBuffer() -> mmap()
                          -> VIDIOC_S_CROP
                          -> VIDIOC_S_FMT
                          -> VIDIOC_QBUF
                          -> VIDIOC_STREAMON
Quoted 2 lines

When I want to call VIDIOC_REQBUFS in FullScreen(), it always fail.

[Hiremath, Vaibhav] Is it possible for you to share your application, so that I can give try here at my end?

Thanks,
Vaibhav Hiremath

Quoted 203 lines

Best Regards,
George.Qiao

============================

Quoted 43 lines

Great, please see my comments in-lined below -

Thanks,
Vaibhav Hiremath
Platform Support Products
Texas Instruments Inc
Ph: +91-80-25099927

Quoted 33 lines

-----Original Message-----
From: George.Qiao [mailto:[email protected]]
Sent: Thursday, May 07, 2009 3:51 PM
To: Hiremath, Vaibhav
Cc: Syed Mohammed, Khasim; Shah, Hardik; [email protected]; Bill Lin; [email protected]; Chatterjee, Amit; Andrews, Gerard; Kridner, Jason; 'Bangfei Jin'; 'Xuejun Dong'; 'YangCai'; [email protected]
Subject: Re: Status of Beagle Board

Dear Vaibhav Hiremath,

I can play video by v4l2 now! Thank you!

I have add code in board-omap3beagle.c :

#ifdef CONFIG_FB_OMAP2
static struct resource omap3beagle_vout_resource[3 - CONFIG_FB_OMAP2_NUM_FBS] = {
};
#else
static struct resource omap3beagle_vout_resource[2] = { };
#endif

static struct platform_device omap3beagle_vout_device = {
.name = "omap_vout",
.num_resources = ARRAY_SIZE(omap3beagle_vout_resource),
.resource = &omap3beagle_vout_resource[0],
.id = -1,
};

static struct platform_device *omap3_beagle_devices[] __initdata

= {

Quoted 10 lines
Quoted 10 lines
    &beagle_dss_device,
    &leds_gpio,
    &keys_gpio,
    &omap3beagle_vout_device,
};

I have got some omapdss error and voutBuffer Size. as follow:

omapdss: Could not find exact pixel clock. Requested 23500 kHz,

got

Quoted 9 lines
Quoted 6 lines

24000 kHz
omapdss error: display already enabled
omap_voutDisplay already enabled
omapdss error: display already enabled
omap_voutDisplay already enabled

[Hiremath, Vaibhav] This is not an error as such, it warning

message. Actually here we are trying to enable the display which has already been enabled by Fbdev.

Quoted 11 lines

We can suppress this message, atleast during init.

Quoted 6 lines

omap_voutBuffer Size = 3686400
omap_vout: registered and initialized video device 0 [v4l2] omap_voutBuffer Size = 3686400
omap_vout: registered and initialized video device 1 [v4l2]

[Hiremath, Vaibhav] This is just a debug massage; it is neither a

error nor a warning. So don't worry.

Quoted 2 lines

Can you share the code-base or submit the patches to the list, so

that interested people can use it.

Quoted 4 lines
Quoted 4 lines

Could I change 'voutBuffer Size'? How to fix it?

Quoted 8 lines
Quoted 8 lines

Best Regards,
George.Qiao

=======================

Quoted 2 lines

Yes Definitely this is the issue. If the platform_device.name

doesn't match with the platform_driver.driver.name then your

probe

Quoted 7 lines
Quoted 7 lines

function will not be called at all.

Quoted 2 lines

Can you just copy the board-omap3evm.c changes related to

V4L2/DSS2 and give a shot? I think it should work straight away.

Quoted 1 line

Please let me know if you need any further clarification or

help.

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines

Thanks,
Vaibhav Hiremath
Platform Support Products
Texas Instruments Inc
Ph: +91-80-25099927

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

-----Original Message-----
From: George.Qiao [mailto:[email protected]]
Sent: Thursday, May 07, 2009 12:55 PM
To: Hiremath, Vaibhav
Cc: Syed Mohammed, Khasim; Shah, Hardik;

[email protected];

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

Bill Lin; [email protected]; Chatterjee, Amit;

Andrews,

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

Gerard; Kridner, Jason; 'Bangfei Jin'; 'Xuejun Dong';

'YangCai';

Quoted 23 lines
Quoted 23 lines
Quoted 23 lines
Quoted 23 lines

[email protected]
Subject: Re: Status of Beagle Board

Hi Hiremath, Vaibhav,

Thank you very much for your instant response!

I've checked the file 'board-omap3beagle.c' and found nothing looking
like omap_vout in it, no platform_device, either. And I've also compared
it with board-omap3evm.c.

Below is some difference between them:

board-omap3evm.c has:
*+static struct platform_device omap3evm_vout_device = {
**+ .name = "omap_vout",
...
}
*
But 'board-omap3beagle.c' does not have anything looking like:

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

*+static struct platform_device omap3beagle_vout_device = {*
*+ .name = "omap_vout",
...
}
*
So, I think there's no patch on V4L2 for beagle done and this

is

Quoted 16 lines
Quoted 16 lines
Quoted 1 line
Quoted 1 line

the

Quoted 13 lines
Quoted 13 lines

root cause of this issue. Do you agree with me? Thanks a lot.

Best Regards,
George.Qiao
===================================

Quoted 4 lines

Hi George,

I have looked into your config file and it looks ok to me.

Quoted 8 lines
Quoted 8 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Can you conform that, you have added "platform_device"

definitions

Quoted 4 lines
Quoted 4 lines

in board-omap3beagle.c?

Quoted 1 line

Can you please create complete patch on top of your baseline

(O-

Quoted 21 lines
Quoted 18 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

L

Quoted 15 lines
Quoted 13 lines

and Tomi's tree), so that I can review that directly? I will be seeing complete changes done for beagle.

Quoted 9 lines

Thanks,
Vaibhav Hiremath
Platform Support Products
Texas Instruments Inc
Ph: +91-80-25099927

#19 lore raw

Hi Hiremath Vaibhav,

I have fixed this bugs in omap_vout.c :

vidioc_streamoff()
{
...
- return ovl->set_overlay_info(ovl, &info);
+ ovl->set_overlay_info(ovl, &info);
...
}

because it should not return ovl->set_overlay_info() here, in this way, the below code will not be executed:
videobuf_streamoff() -> videobuf_queue_cancel()
{
...
q->streaming = 0
...
}

so, vidioc_reqbufs->videobuf_reqbufs() will always fail.

Do you agree with me?

Thanks & Best Regards,
George.Qiao

===================================

Quoted 32 lines
Quoted 10 lines

-----Original Message-----
From: George.Qiao [mailto:[email protected]]
Sent: Friday, May 08, 2009 11:57 AM
To: Hiremath, Vaibhav
Cc: Syed Mohammed, Khasim; Shah, Hardik; [email protected]; Bill Lin; [email protected]; Chatterjee, Amit; Andrews, Gerard; Kridner, Jason; 'Bangfei Jin'; 'Xuejun Dong'; 'YangCai'; [email protected]
Subject: Re: Status of Beagle Board

Quoted 7 lines

Hi Vaibhav Hiremath,

My application can work in OMAP3 EVM and other v4l2 platform, but there
is another issue in beagle board. as follow:

[Hiremath, Vaibhav] Are you saying, same application works on OMAP3EVM but fails on beagle board?

Quoted 12 lines

1. NormalSize() -> RequestBuffer() -> mmap()
2. playing...
3. FullScreen() -> VIDIOC_STREAMOFF

                          -> munmap()
                          -> VIDIOC_REQBUFS
                          -> VIDIOC_QUERYBUF
                          -> RequestBuffer() -> mmap()
                          -> VIDIOC_S_CROP
                          -> VIDIOC_S_FMT
                          -> VIDIOC_QBUF
                          -> VIDIOC_STREAMON
Quoted 246 lines
Quoted 3 lines

When I want to call VIDIOC_REQBUFS in FullScreen(), it always fail.

[Hiremath, Vaibhav] Is it possible for you to share your application, so that I can give try here at my end?

Thanks,
Vaibhav Hiremath

Quoted 234 lines

Best Regards,
George.Qiao

============================

Quoted 45 lines

Great, please see my comments in-lined below -

Thanks,
Vaibhav Hiremath
Platform Support Products
Texas Instruments Inc
Ph: +91-80-25099927

Quoted 34 lines

-----Original Message-----
From: George.Qiao [mailto:[email protected]]
Sent: Thursday, May 07, 2009 3:51 PM
To: Hiremath, Vaibhav
Cc: Syed Mohammed, Khasim; Shah, Hardik; [email protected]; Bill Lin; [email protected]; Chatterjee, Amit; Andrews, Gerard; Kridner, Jason; 'Bangfei Jin'; 'Xuejun Dong'; 'YangCai'; [email protected]
Subject: Re: Status of Beagle Board

Dear Vaibhav Hiremath,

I can play video by v4l2 now! Thank you!

I have add code in board-omap3beagle.c :

#ifdef CONFIG_FB_OMAP2
static struct resource omap3beagle_vout_resource[3 - CONFIG_FB_OMAP2_NUM_FBS] = {
};
#else
static struct resource omap3beagle_vout_resource[2] = { };
#endif

static struct platform_device omap3beagle_vout_device = {
.name = "omap_vout",
.num_resources = ARRAY_SIZE(omap3beagle_vout_resource),
.resource = &omap3beagle_vout_resource[0],
.id = -1,
};

static struct platform_device *omap3_beagle_devices[] __initdata

= {

Quoted 11 lines
Quoted 11 lines
    &beagle_dss_device,
    &leds_gpio,
    &keys_gpio,
    &omap3beagle_vout_device,
};

I have got some omapdss error and voutBuffer Size. as follow:

omapdss: Could not find exact pixel clock. Requested 23500 kHz,

got

Quoted 9 lines
Quoted 7 lines

24000 kHz
omapdss error: display already enabled
omap_voutDisplay already enabled
omapdss error: display already enabled
omap_voutDisplay already enabled

[Hiremath, Vaibhav] This is not an error as such, it warning

message. Actually here we are trying to enable the display which has already been enabled by Fbdev.

Quoted 4 lines

We can suppress this message, atleast during init.

Quoted 9 lines
Quoted 7 lines

omap_voutBuffer Size = 3686400
omap_vout: registered and initialized video device 0 [v4l2] omap_voutBuffer Size = 3686400
omap_vout: registered and initialized video device 1 [v4l2]

[Hiremath, Vaibhav] This is just a debug massage; it is neither a

error nor a warning. So don't worry.

Quoted 2 lines

Can you share the code-base or submit the patches to the list, so

that interested people can use it.

Quoted 6 lines
Quoted 6 lines

Could I change 'voutBuffer Size'? How to fix it?

Best Regards,
George.Qiao

Quoted 8 lines
Quoted 8 lines

=======================

Quoted 3 lines

Yes Definitely this is the issue. If the platform_device.name

doesn't match with the platform_driver.driver.name then your

probe

Quoted 11 lines
Quoted 11 lines

function will not be called at all.

Quoted 3 lines

Can you just copy the board-omap3evm.c changes related to

V4L2/DSS2 and give a shot? I think it should work straight away.

Quoted 2 lines

Please let me know if you need any further clarification or

help.

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines

Thanks,
Vaibhav Hiremath
Platform Support Products
Texas Instruments Inc
Ph: +91-80-25099927

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

-----Original Message-----
From: George.Qiao [mailto:[email protected]]
Sent: Thursday, May 07, 2009 12:55 PM
To: Hiremath, Vaibhav
Cc: Syed Mohammed, Khasim; Shah, Hardik;

[email protected];

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Bill Lin; [email protected]; Chatterjee, Amit;

Andrews,

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Gerard; Kridner, Jason; 'Bangfei Jin'; 'Xuejun Dong';

'YangCai';

Quoted 23 lines
Quoted 23 lines
Quoted 23 lines
Quoted 23 lines

[email protected]
Subject: Re: Status of Beagle Board

Hi Hiremath, Vaibhav,

Thank you very much for your instant response!

I've checked the file 'board-omap3beagle.c' and found nothing looking
like omap_vout in it, no platform_device, either. And I've also compared
it with board-omap3evm.c.

Below is some difference between them:

board-omap3evm.c has:
*+static struct platform_device omap3evm_vout_device = {
**+ .name = "omap_vout",
...
}
*
But 'board-omap3beagle.c' does not have anything looking like:

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

*+static struct platform_device omap3beagle_vout_device = {*
*+ .name = "omap_vout",
...
}
*
So, I think there's no patch on V4L2 for beagle done and this

is

Quoted 23 lines
Quoted 23 lines

the

Quoted 10 lines
Quoted 10 lines

root cause of this issue. Do you agree with me? Thanks a lot.

Best Regards,
George.Qiao
===================================

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

Hi George,

I have looked into your config file and it looks ok to me.

Can you conform that, you have added "platform_device"

definitions

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

in board-omap3beagle.c?

Quoted 2 lines

Can you please create complete patch on top of your baseline

(O-

Quoted 21 lines
Quoted 19 lines

L

Quoted 16 lines
Quoted 15 lines

and Tomi's tree), so that I can review that directly? I will be seeing complete changes done for beagle.

Quoted 10 lines

Thanks,
Vaibhav Hiremath
Platform Support Products
Texas Instruments Inc
Ph: +91-80-25099927

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#20 lore raw

Hi George,

Yes I do agree, at-least for me this looks like a small bug in V4L2 driver. But just to make double sure I will discuss this with Hardik and let you know.

Thanks,
Vaibhav Hiremath
Platform Support Products
Texas Instruments Inc
Ph: +91-80-25099927

Quoted 333 lines

-----Original Message-----
From: George.Qiao [mailto:[email protected]]
Sent: Monday, May 11, 2009 12:26 PM
To: Hiremath, Vaibhav
Cc: Syed Mohammed, Khasim; Shah, Hardik; [email protected]; Bill Lin; [email protected]; Chatterjee, Amit; Andrews, Gerard; Kridner, Jason; 'Bangfei Jin'; 'Xuejun Dong'; 'YangCai'; [email protected]
Subject: Re: Status of Beagle Board

Hi Hiremath Vaibhav,

I have fixed this bugs in omap_vout.c :

vidioc_streamoff()
{
...
- return ovl->set_overlay_info(ovl, &info);
+ ovl->set_overlay_info(ovl, &info);
...
}

because it should not return ovl->set_overlay_info() here, in this way,
the below code will not be executed:
videobuf_streamoff() -> videobuf_queue_cancel()
{
...
q->streaming = 0
...
}

so, vidioc_reqbufs->videobuf_reqbufs() will always fail.

Do you agree with me?

Thanks & Best Regards,
George.Qiao

===================================

Quoted 10 lines
Quoted 10 lines

-----Original Message-----
From: George.Qiao [mailto:[email protected]]
Sent: Friday, May 08, 2009 11:57 AM
To: Hiremath, Vaibhav
Cc: Syed Mohammed, Khasim; Shah, Hardik; [email protected]; Bill Lin; [email protected]; Chatterjee, Amit; Andrews, Gerard; Kridner, Jason; 'Bangfei Jin'; 'Xuejun Dong'; 'YangCai'; [email protected]
Subject: Re: Status of Beagle Board

Quoted 8 lines
Quoted 7 lines

Hi Vaibhav Hiremath,

My application can work in OMAP3 EVM and other v4l2 platform, but there
is another issue in beagle board. as follow:

[Hiremath, Vaibhav] Are you saying, same application works on

OMAP3EVM but fails on beagle board?

Quoted 14 lines
Quoted 14 lines

1. NormalSize() -> RequestBuffer() -> mmap()
2. playing...
3. FullScreen() -> VIDIOC_STREAMOFF

                          -> munmap()
                          -> VIDIOC_REQBUFS
                          -> VIDIOC_QUERYBUF
                          -> RequestBuffer() -> mmap()
                          -> VIDIOC_S_CROP
                          -> VIDIOC_S_FMT
                          -> VIDIOC_QBUF
                          -> VIDIOC_STREAMON
Quoted 1 line
Quoted 1 line

When I want to call VIDIOC_REQBUFS in FullScreen(), it always

fail.

Quoted 3 lines
Quoted 2 lines

[Hiremath, Vaibhav] Is it possible for you to share your

application, so that I can give try here at my end?

Quoted 26 lines

Thanks,
Vaibhav Hiremath

Quoted 21 lines

Best Regards,
George.Qiao

============================

Quoted 16 lines

Great, please see my comments in-lined below -

Thanks,
Vaibhav Hiremath
Platform Support Products
Texas Instruments Inc
Ph: +91-80-25099927

Quoted 5 lines

-----Original Message-----
From: George.Qiao [mailto:[email protected]]
Sent: Thursday, May 07, 2009 3:51 PM
To: Hiremath, Vaibhav
Cc: Syed Mohammed, Khasim; Shah, Hardik;

[email protected];

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

Bill Lin; [email protected]; Chatterjee, Amit;

Andrews,

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

Gerard; Kridner, Jason; 'Bangfei Jin'; 'Xuejun Dong';

'YangCai';

Quoted 18 lines
Quoted 18 lines
Quoted 18 lines
Quoted 18 lines

[email protected]
Subject: Re: Status of Beagle Board

Dear Vaibhav Hiremath,

I can play video by v4l2 now! Thank you!

I have add code in board-omap3beagle.c :

#ifdef CONFIG_FB_OMAP2
static struct resource omap3beagle_vout_resource[3 - CONFIG_FB_OMAP2_NUM_FBS] = {
};
#else
static struct resource omap3beagle_vout_resource[2] = { };
#endif

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

static struct platform_device omap3beagle_vout_device = {
.name = "omap_vout",
.num_resources = ARRAY_SIZE(omap3beagle_vout_resource),
.resource = &omap3beagle_vout_resource[0],
.id = -1,
};

static struct platform_device *omap3_beagle_devices[]

__initdata

Quoted 23 lines
Quoted 23 lines
Quoted 1 line
Quoted 1 line

= {

Quoted 11 lines
Quoted 11 lines
    &beagle_dss_device,
    &leds_gpio,
    &keys_gpio,
    &omap3beagle_vout_device,
};

I have got some omapdss error and voutBuffer Size. as follow:

omapdss: Could not find exact pixel clock. Requested 23500 kHz,

got

Quoted 7 lines
Quoted 7 lines

24000 kHz
omapdss error: display already enabled
omap_voutDisplay already enabled
omapdss error: display already enabled
omap_voutDisplay already enabled

Quoted 3 lines
Quoted 3 lines
Quoted 2 lines

[Hiremath, Vaibhav] This is not an error as such, it warning

message. Actually here we are trying to enable the display which

has

Quoted 6 lines
Quoted 6 lines

already been enabled by Fbdev.

Quoted 4 lines

We can suppress this message, atleast during init.

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 7 lines

omap_voutBuffer Size = 3686400
omap_vout: registered and initialized video device 0 [v4l2] omap_voutBuffer Size = 3686400
omap_vout: registered and initialized video device 1 [v4l2]

[Hiremath, Vaibhav] This is just a debug massage; it is neither

a

Quoted 4 lines
Quoted 4 lines
Quoted 1 line

error nor a warning. So don't worry.

Quoted 1 line

Can you share the code-base or submit the patches to the list,

so

Quoted 19 lines
Quoted 19 lines
Quoted 1 line

that interested people can use it.

Quoted 6 lines
Quoted 6 lines

Could I change 'voutBuffer Size'? How to fix it?

Best Regards,
George.Qiao

Quoted 8 lines
Quoted 8 lines

=======================

Quoted 3 lines

Yes Definitely this is the issue. If the platform_device.name

doesn't match with the platform_driver.driver.name then your

probe

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

function will not be called at all.

Quoted 3 lines

Can you just copy the board-omap3evm.c changes related to

V4L2/DSS2 and give a shot? I think it should work straight

away.

Quoted 34 lines
Quoted 34 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

Please let me know if you need any further clarification or

help.

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines

Thanks,
Vaibhav Hiremath
Platform Support Products
Texas Instruments Inc
Ph: +91-80-25099927

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

-----Original Message-----
From: George.Qiao [mailto:[email protected]]
Sent: Thursday, May 07, 2009 12:55 PM
To: Hiremath, Vaibhav
Cc: Syed Mohammed, Khasim; Shah, Hardik;

[email protected];

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Bill Lin; [email protected]; Chatterjee, Amit;

Andrews,

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Gerard; Kridner, Jason; 'Bangfei Jin'; 'Xuejun Dong';

'YangCai';

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

[email protected]
Subject: Re: Status of Beagle Board

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

Hi Hiremath, Vaibhav,

Thank you very much for your instant response!

I've checked the file 'board-omap3beagle.c' and found nothing looking
like omap_vout in it, no platform_device, either. And I've

also

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

compared
it with board-omap3evm.c.

Below is some difference between them:

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

board-omap3evm.c has:
*+static struct platform_device omap3evm_vout_device = {
**+ .name = "omap_vout",
...
}
*
But 'board-omap3beagle.c' does not have anything looking

like:

Quoted 37 lines
Quoted 37 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

*+static struct platform_device omap3beagle_vout_device = {*
*+ .name = "omap_vout",
...
}
*
So, I think there's no patch on V4L2 for beagle done and this

is

Quoted 27 lines
Quoted 27 lines

the

Quoted 10 lines
Quoted 10 lines

root cause of this issue. Do you agree with me? Thanks a lot.

Best Regards,
George.Qiao
===================================

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

Hi George,

I have looked into your config file and it looks ok to me.

Can you conform that, you have added "platform_device"

definitions

Quoted 4 lines
Quoted 4 lines

in board-omap3beagle.c?

Quoted 8 lines
Quoted 8 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Can you please create complete patch on top of your baseline

(O-

Quoted 4 lines
Quoted 4 lines

L

Quoted 1 line
Quoted 1 line

and Tomi's tree), so that I can review that directly? I will

be

Quoted 20 lines
Quoted 17 lines
Quoted 17 lines
Quoted 15 lines
Quoted 15 lines
Quoted 14 lines

seeing complete changes done for beagle.

Quoted 10 lines

Thanks,
Vaibhav Hiremath
Platform Support Products
Texas Instruments Inc
Ph: +91-80-25099927

#21 lore raw

Hi Hiremath Vaibhav,

Thank you very much for v4l2 on beagle!

We want to use your branch to demo our video player, I can not enable sound and usb-mouse in beagle board.

What's the difference between beagle kernel and your branch kernel for sound and usb driver?

Thanks & Best Regards,
George.Qiao
==========================================

Quoted 402 lines

Hi George,

Yes I do agree, at-least for me this looks like a small bug in V4L2 driver. But just to make double sure I will discuss this with Hardik and let you know.

Thanks,
Vaibhav Hiremath
Platform Support Products
Texas Instruments Inc
Ph: +91-80-25099927

Quoted 390 lines

-----Original Message-----
From: George.Qiao [mailto:[email protected]]
Sent: Monday, May 11, 2009 12:26 PM
To: Hiremath, Vaibhav
Cc: Syed Mohammed, Khasim; Shah, Hardik; [email protected]; Bill Lin; [email protected]; Chatterjee, Amit; Andrews, Gerard; Kridner, Jason; 'Bangfei Jin'; 'Xuejun Dong'; 'YangCai'; [email protected]
Subject: Re: Status of Beagle Board

Hi Hiremath Vaibhav,

I have fixed this bugs in omap_vout.c :

vidioc_streamoff()
{
...
- return ovl->set_overlay_info(ovl, &info);
+ ovl->set_overlay_info(ovl, &info);
...
}

because it should not return ovl->set_overlay_info() here, in this way,
the below code will not be executed:
videobuf_streamoff() -> videobuf_queue_cancel()
{
...
q->streaming = 0
...
}

so, vidioc_reqbufs->videobuf_reqbufs() will always fail.

Do you agree with me?

Thanks & Best Regards,
George.Qiao

===================================

Quoted 12 lines
Quoted 12 lines

-----Original Message-----
From: George.Qiao [mailto:[email protected]]
Sent: Friday, May 08, 2009 11:57 AM
To: Hiremath, Vaibhav
Cc: Syed Mohammed, Khasim; Shah, Hardik; [email protected]; Bill Lin; [email protected]; Chatterjee, Amit; Andrews, Gerard; Kridner, Jason; 'Bangfei Jin'; 'Xuejun Dong'; 'YangCai'; [email protected]
Subject: Re: Status of Beagle Board

Hi Vaibhav Hiremath,

Quoted 8 lines
Quoted 6 lines

My application can work in OMAP3 EVM and other v4l2 platform, but there
is another issue in beagle board. as follow:

[Hiremath, Vaibhav] Are you saying, same application works on

OMAP3EVM but fails on beagle board?

Quoted 13 lines
Quoted 13 lines

1. NormalSize() -> RequestBuffer() -> mmap()
2. playing...
3. FullScreen() -> VIDIOC_STREAMOFF

                          -> munmap()
                          -> VIDIOC_REQBUFS
                          -> VIDIOC_QUERYBUF
                          -> RequestBuffer() -> mmap()
                          -> VIDIOC_S_CROP
                          -> VIDIOC_S_FMT
                          -> VIDIOC_QBUF
                          -> VIDIOC_STREAMON
Quoted 2 lines
Quoted 2 lines

When I want to call VIDIOC_REQBUFS in FullScreen(), it always

fail.

Quoted 3 lines
Quoted 1 line

[Hiremath, Vaibhav] Is it possible for you to share your

application, so that I can give try here at my end?

Quoted 29 lines

Thanks,
Vaibhav Hiremath

Quoted 24 lines

Best Regards,
George.Qiao

============================

Quoted 18 lines

Great, please see my comments in-lined below -

Thanks,
Vaibhav Hiremath
Platform Support Products
Texas Instruments Inc
Ph: +91-80-25099927

Quoted 6 lines

-----Original Message-----
From: George.Qiao [mailto:[email protected]]
Sent: Thursday, May 07, 2009 3:51 PM
To: Hiremath, Vaibhav
Cc: Syed Mohammed, Khasim; Shah, Hardik;

[email protected];

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Bill Lin; [email protected]; Chatterjee, Amit;

Andrews,

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Gerard; Kridner, Jason; 'Bangfei Jin'; 'Xuejun Dong';

'YangCai';

Quoted 25 lines
Quoted 25 lines
Quoted 25 lines
Quoted 25 lines

[email protected]
Subject: Re: Status of Beagle Board

Dear Vaibhav Hiremath,

I can play video by v4l2 now! Thank you!

I have add code in board-omap3beagle.c :

#ifdef CONFIG_FB_OMAP2
static struct resource omap3beagle_vout_resource[3 - CONFIG_FB_OMAP2_NUM_FBS] = {
};
#else
static struct resource omap3beagle_vout_resource[2] = { };
#endif

static struct platform_device omap3beagle_vout_device = {
.name = "omap_vout",
.num_resources = ARRAY_SIZE(omap3beagle_vout_resource),
.resource = &omap3beagle_vout_resource[0],
.id = -1,
};

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

static struct platform_device *omap3_beagle_devices[]

__initdata

Quoted 26 lines
Quoted 26 lines

= {

Quoted 7 lines
Quoted 7 lines
    &beagle_dss_device,
    &leds_gpio,
    &keys_gpio,
    &omap3beagle_vout_device,
};
Quoted 5 lines
Quoted 5 lines

I have got some omapdss error and voutBuffer Size. as follow:

omapdss: Could not find exact pixel clock. Requested 23500 kHz,

got

Quoted 8 lines
Quoted 8 lines

24000 kHz
omapdss error: display already enabled
omap_voutDisplay already enabled
omapdss error: display already enabled
omap_voutDisplay already enabled

Quoted 5 lines
Quoted 5 lines
Quoted 3 lines

[Hiremath, Vaibhav] This is not an error as such, it warning

message. Actually here we are trying to enable the display which

has

Quoted 16 lines
Quoted 16 lines

already been enabled by Fbdev.

Quoted 13 lines

We can suppress this message, atleast during init.

Quoted 8 lines

omap_voutBuffer Size = 3686400
omap_vout: registered and initialized video device 0 [v4l2] omap_voutBuffer Size = 3686400
omap_vout: registered and initialized video device 1 [v4l2]

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

[Hiremath, Vaibhav] This is just a debug massage; it is neither

a

Quoted 5 lines
Quoted 5 lines

error nor a warning. So don't worry.

Quoted 2 lines

Can you share the code-base or submit the patches to the list,

so

Quoted 26 lines
Quoted 26 lines

that interested people can use it.

Quoted 9 lines
Quoted 9 lines

Could I change 'voutBuffer Size'? How to fix it?

Best Regards,
George.Qiao

=======================

Quoted 7 lines
Quoted 7 lines
Quoted 4 lines

Yes Definitely this is the issue. If the platform_device.name

doesn't match with the platform_driver.driver.name then your

probe

Quoted 4 lines
Quoted 4 lines

function will not be called at all.

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 4 lines

Can you just copy the board-omap3evm.c changes related to

V4L2/DSS2 and give a shot? I think it should work straight

away.

Quoted 42 lines
Quoted 42 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

Please let me know if you need any further clarification or

help.

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines

Thanks,
Vaibhav Hiremath
Platform Support Products
Texas Instruments Inc
Ph: +91-80-25099927

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

-----Original Message-----
From: George.Qiao [mailto:[email protected]]
Sent: Thursday, May 07, 2009 12:55 PM
To: Hiremath, Vaibhav
Cc: Syed Mohammed, Khasim; Shah, Hardik;

[email protected];

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

Bill Lin; [email protected]; Chatterjee, Amit;

Andrews,

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

Gerard; Kridner, Jason; 'Bangfei Jin'; 'Xuejun Dong';

'YangCai';

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

[email protected]
Subject: Re: Status of Beagle Board

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

Hi Hiremath, Vaibhav,

Thank you very much for your instant response!

I've checked the file 'board-omap3beagle.c' and found nothing looking
like omap_vout in it, no platform_device, either. And I've

also

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

compared
it with board-omap3evm.c.

Below is some difference between them:

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

board-omap3evm.c has:
*+static struct platform_device omap3evm_vout_device = {
**+ .name = "omap_vout",
...
}
*
But 'board-omap3beagle.c' does not have anything looking

like:

Quoted 49 lines
Quoted 49 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

*+static struct platform_device omap3beagle_vout_device = {*
*+ .name = "omap_vout",
...
}
*
So, I think there's no patch on V4L2 for beagle done and this

is

Quoted 27 lines
Quoted 27 lines

the

Quoted 11 lines
Quoted 11 lines

root cause of this issue. Do you agree with me? Thanks a lot.

Best Regards,
George.Qiao
===================================

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

Hi George,

I have looked into your config file and it looks ok to me.

Can you conform that, you have added "platform_device"

definitions

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

in board-omap3beagle.c?

Quoted 3 lines

Can you please create complete patch on top of your baseline

(O-

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

L

Quoted 2 lines
Quoted 2 lines

and Tomi's tree), so that I can review that directly? I will

be

Quoted 19 lines
Quoted 17 lines
Quoted 17 lines
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines

seeing complete changes done for beagle.

Quoted 11 lines

Thanks,
Vaibhav Hiremath
Platform Support Products
Texas Instruments Inc
Ph: +91-80-25099927

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#22 lore raw

Thanks,
Vaibhav Hiremath
Platform Support Products
Texas Instruments Inc
Ph: +91-80-25099927

Quoted 10 lines

-----Original Message-----
From: George.Qiao [mailto:[email protected]]
Sent: Tuesday, May 12, 2009 1:35 PM
To: Hiremath, Vaibhav
Cc: Syed Mohammed, Khasim; Shah, Hardik; [email protected]; Bill Lin; [email protected]; Chatterjee, Amit; Andrews, Gerard; Kridner, Jason; 'Bangfei Jin'; 'Xuejun Dong'; 'YangCai'; [email protected]
Subject: Re: Status of Beagle Board

Quoted 8 lines

Hi Hiremath Vaibhav,

Thank you very much for v4l2 on beagle!

We want to use your branch to demo our video player, I can not enable
sound and usb-mouse in beagle board.

[Hiremath, Vaibhav] I believe you are referring to repository http://arago-project.org/git/people/?p=vaibhav/ti-psp-omap-video.git;a=summary.

This is specific to Video related changes and I am tracking and following Video changes only. I am really not sure about sound and USB related to Beagle board.

Quoted 4 lines

What's the difference between beagle kernel and your branch kernel for
sound and usb driver?

[Hiremath, Vaibhav] Looping Anand Gadiyar, who would be able to answer this.

Quoted 425 lines

Thanks & Best Regards,
George.Qiao
==========================================

Quoted 3 lines

Hi George,

Yes I do agree, at-least for me this looks like a small bug in

V4L2 driver. But just to make double sure I will discuss this with Hardik and let you know.

Quoted 30 lines

Thanks,
Vaibhav Hiremath
Platform Support Products
Texas Instruments Inc
Ph: +91-80-25099927

Quoted 23 lines

-----Original Message-----
From: George.Qiao [mailto:[email protected]]
Sent: Monday, May 11, 2009 12:26 PM
To: Hiremath, Vaibhav
Cc: Syed Mohammed, Khasim; Shah, Hardik; [email protected]; Bill Lin; [email protected]; Chatterjee, Amit; Andrews, Gerard; Kridner, Jason; 'Bangfei Jin'; 'Xuejun Dong'; 'YangCai'; [email protected]
Subject: Re: Status of Beagle Board

Hi Hiremath Vaibhav,

I have fixed this bugs in omap_vout.c :

vidioc_streamoff()
{
...
- return ovl->set_overlay_info(ovl, &info);
+ ovl->set_overlay_info(ovl, &info);
...
}

because it should not return ovl->set_overlay_info() here, in

this

Quoted 16 lines
Quoted 16 lines

way,
the below code will not be executed:
videobuf_streamoff() -> videobuf_queue_cancel()
{
...
q->streaming = 0
...
}

so, vidioc_reqbufs->videobuf_reqbufs() will always fail.

Do you agree with me?

Thanks & Best Regards,
George.Qiao

Quoted 7 lines
Quoted 7 lines

===================================

Quoted 5 lines
Quoted 5 lines

-----Original Message-----
From: George.Qiao [mailto:[email protected]]
Sent: Friday, May 08, 2009 11:57 AM
To: Hiremath, Vaibhav
Cc: Syed Mohammed, Khasim; Shah, Hardik;

[email protected];

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

Bill Lin; [email protected]; Chatterjee, Amit;

Andrews,

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

Gerard; Kridner, Jason; 'Bangfei Jin'; 'Xuejun Dong';

'YangCai';

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

[email protected]
Subject: Re: Status of Beagle Board

Hi Vaibhav Hiremath,

My application can work in OMAP3 EVM and other v4l2 platform,

but

Quoted 88 lines
Quoted 88 lines
Quoted 7 lines
Quoted 5 lines

there
is another issue in beagle board. as follow:

[Hiremath, Vaibhav] Are you saying, same application works on

OMAP3EVM but fails on beagle board?

Quoted 13 lines
Quoted 13 lines

1. NormalSize() -> RequestBuffer() -> mmap()
2. playing...
3. FullScreen() -> VIDIOC_STREAMOFF

                          -> munmap()
                          -> VIDIOC_REQBUFS
                          -> VIDIOC_QUERYBUF
                          -> RequestBuffer() -> mmap()
                          -> VIDIOC_S_CROP
                          -> VIDIOC_S_FMT
                          -> VIDIOC_QBUF
                          -> VIDIOC_STREAMON
Quoted 2 lines
Quoted 2 lines

When I want to call VIDIOC_REQBUFS in FullScreen(), it always

fail.

Quoted 3 lines
Quoted 1 line

[Hiremath, Vaibhav] Is it possible for you to share your

application, so that I can give try here at my end?

Quoted 29 lines

Thanks,
Vaibhav Hiremath

Quoted 24 lines

Best Regards,
George.Qiao

============================

Quoted 18 lines

Great, please see my comments in-lined below -

Thanks,
Vaibhav Hiremath
Platform Support Products
Texas Instruments Inc
Ph: +91-80-25099927

Quoted 6 lines

-----Original Message-----
From: George.Qiao [mailto:[email protected]]
Sent: Thursday, May 07, 2009 3:51 PM
To: Hiremath, Vaibhav
Cc: Syed Mohammed, Khasim; Shah, Hardik;

[email protected];

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Bill Lin; [email protected]; Chatterjee, Amit;

Andrews,

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Gerard; Kridner, Jason; 'Bangfei Jin'; 'Xuejun Dong';

'YangCai';

Quoted 18 lines
Quoted 18 lines
Quoted 18 lines
Quoted 18 lines

[email protected]
Subject: Re: Status of Beagle Board

Dear Vaibhav Hiremath,

I can play video by v4l2 now! Thank you!

I have add code in board-omap3beagle.c :

#ifdef CONFIG_FB_OMAP2
static struct resource omap3beagle_vout_resource[3 - CONFIG_FB_OMAP2_NUM_FBS] = {
};
#else
static struct resource omap3beagle_vout_resource[2] = { };
#endif

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

static struct platform_device omap3beagle_vout_device = {
.name = "omap_vout",
.num_resources =

ARRAY_SIZE(omap3beagle_vout_resource),

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

.resource =

&omap3beagle_vout_resource[0],

Quoted 17 lines
Quoted 17 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

.id = -1,
};

static struct platform_device *omap3_beagle_devices[]

__initdata

Quoted 10 lines
Quoted 10 lines

= {

Quoted 7 lines
Quoted 7 lines
    &beagle_dss_device,
    &leds_gpio,
    &keys_gpio,
    &omap3beagle_vout_device,
};
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

I have got some omapdss error and voutBuffer Size. as follow:

omapdss: Could not find exact pixel clock. Requested 23500

kHz,

Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
Quoted 2 lines
Quoted 2 lines

got

Quoted 8 lines
Quoted 8 lines

24000 kHz
omapdss error: display already enabled
omap_voutDisplay already enabled
omapdss error: display already enabled
omap_voutDisplay already enabled

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 3 lines

[Hiremath, Vaibhav] This is not an error as such, it warning

message. Actually here we are trying to enable the display

which

Quoted 19 lines
Quoted 19 lines
Quoted 1 line
Quoted 1 line

has

Quoted 16 lines
Quoted 16 lines

already been enabled by Fbdev.

Quoted 13 lines

We can suppress this message, atleast during init.

Quoted 8 lines

omap_voutBuffer Size = 3686400
omap_vout: registered and initialized video device 0 [v4l2] omap_voutBuffer Size = 3686400
omap_vout: registered and initialized video device 1 [v4l2]

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

[Hiremath, Vaibhav] This is just a debug massage; it is

neither

Quoted 15 lines
Quoted 15 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

a

Quoted 5 lines
Quoted 5 lines

error nor a warning. So don't worry.

Quoted 2 lines

Can you share the code-base or submit the patches to the list,

so

Quoted 5 lines
Quoted 5 lines

that interested people can use it.

Quoted 2 lines
Quoted 2 lines

Could I change 'voutBuffer Size'? How to fix it?

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

Best Regards,
George.Qiao

=======================

Quoted 1 line

Yes Definitely this is the issue. If the

platform_device.name

Quoted 60 lines
Quoted 60 lines
Quoted 13 lines
Quoted 13 lines
Quoted 6 lines
Quoted 6 lines
Quoted 3 lines

doesn't match with the platform_driver.driver.name then your

probe

Quoted 4 lines
Quoted 4 lines

function will not be called at all.

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 4 lines

Can you just copy the board-omap3evm.c changes related to

V4L2/DSS2 and give a shot? I think it should work straight

away.

Quoted 39 lines
Quoted 39 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

Please let me know if you need any further clarification or

help.

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines

Thanks,
Vaibhav Hiremath
Platform Support Products
Texas Instruments Inc
Ph: +91-80-25099927

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

-----Original Message-----
From: George.Qiao [mailto:[email protected]]
Sent: Thursday, May 07, 2009 12:55 PM
To: Hiremath, Vaibhav
Cc: Syed Mohammed, Khasim; Shah, Hardik;

[email protected];

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

Bill Lin; [email protected]; Chatterjee, Amit;

Andrews,

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

Gerard; Kridner, Jason; 'Bangfei Jin'; 'Xuejun Dong';

'YangCai';

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

[email protected]
Subject: Re: Status of Beagle Board

Hi Hiremath, Vaibhav,

Thank you very much for your instant response!

I've checked the file 'board-omap3beagle.c' and found

nothing

Quoted 18 lines
Quoted 18 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

looking
like omap_vout in it, no platform_device, either. And I've

also

Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
Quoted 13 lines

compared
it with board-omap3evm.c.

Below is some difference between them:

board-omap3evm.c has:
*+static struct platform_device omap3evm_vout_device = {
**+ .name = "omap_vout",
...
}
*
But 'board-omap3beagle.c' does not have anything looking

Quoted 3 lines
Quoted 3 lines

like:

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

*+static struct platform_device omap3beagle_vout_device =

{*

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

*+ .name = "omap_vout",
...
}
*
So, I think there's no patch on V4L2 for beagle done and

this

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

is

Quoted 5 lines
Quoted 5 lines

the

Quoted 1 line
Quoted 1 line

root cause of this issue. Do you agree with me? Thanks a

lot.

Quoted 22 lines
Quoted 22 lines
Quoted 22 lines
Quoted 22 lines
Quoted 22 lines
Quoted 22 lines
Quoted 10 lines
Quoted 10 lines

Best Regards,
George.Qiao
===================================

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

Hi George,

I have looked into your config file and it looks ok to me.

Can you conform that, you have added "platform_device"

definitions

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

in board-omap3beagle.c?

Quoted 1 line

Can you please create complete patch on top of your

baseline

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

(O-

Quoted 5 lines
Quoted 5 lines

L

Quoted 1 line
Quoted 1 line

and Tomi's tree), so that I can review that directly? I

will

Quoted 24 lines
Quoted 22 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

be

Quoted 19 lines
Quoted 17 lines
Quoted 17 lines
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines

seeing complete changes done for beagle.

Quoted 11 lines

Thanks,
Vaibhav Hiremath
Platform Support Products
Texas Instruments Inc
Ph: +91-80-25099927