Skip to contentSkip to conversation

drivers/fsl_pci_init: Fix compile warning

PATCH New Kumar Gala 2 participants 2 messages Dec 9, 2008 PCI

lore
Share & tools
lore

Kumar Gala

author
#0 lore raw

PATCH 1/1 drivers/fsl_pci_init: Fix compile warning

fsl_pci_init.c: In function 'fsl_pci_setup_inbound_windows':
fsl_pci_init.c:122: warning: comparison is always true due to limited range of data type

The check only makes sense if we are CONFIG_PHYS_64BIT

---
 drivers/pci/fsl_pci_init.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/pci/fsl_pci_init.c +2 -0
index e57acba..1db42fd 100644
@@ -119,9 +119,11 @@ int fsl_pci_setup_inbound_windows(struct pci_region *r)
 	}
 #endif
 
+#ifdef CONFIG_PHYS_64BIT
 	if (sz && (((u64)gd->ram_size) < (1ull << 32)))
 		printf("Was not able to map all of memory via "
 			"inbound windows -- %lld remaining\n", sz);
+#endif
 
 	return r - rgn_base;
 }
Signature · 1 line
1.5.6.5
#1 lore raw

PATCH 1/1 drivers/fsl_pci_init: Fix compile warning

Dear Kumar Gala,

Quoted 9 lines · In message <[email protected]> you…

fsl_pci_init.c: In function 'fsl_pci_setup_inbound_windows':
fsl_pci_init.c:122: warning: comparison is always true due to limited range of data type

The check only makes sense if we are CONFIG_PHYS_64BIT

---
 drivers/pci/fsl_pci_init.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
8 Catfish                                               = 1 Octo-puss