Skip to contentSkip to conversation

LED (leds_hp_disk) causes BUG: scheduling while atomic

DISCUSSION Pavel Machek 2 participants 5 messages Jan 6, 2009 – Jan 23, 2009 1 message not in the archive

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive

Hi!

Quoted 6 lines

I'm not sure if I should send this email to LKML, because it doesn't seem to important, and the traffic there seems high. If you are not the correct maintainer, or if I should send it there anyway, please tell me.

Update: I sent this letter first to Helge Deller <[email protected]>, he told me to mail to you.

Yep, that's right, I'm responsible. LKML is indeed right thing to Cc:.

Quoted 6 lines

I have a HP Compaq nc2400 notebook, and having recently installed 2.6.28 (gentoo patchset, self configured), I have observed the following:

When {I manually, udev automatically} load the leds_hp_disk module, my disk-led flashes regularly _without_ disk activity. When I look at my dmesg I see the following:

Yes, that's a (mis-feature).

Quoted 2 lines
[  724.376881] BUG: scheduling while atomic: swapper/0/0x10000100
[  724.376886] Modules linked in: leds_hp_disk i915 drm snd_pcm_oss

And that's a bug. I know what causes it, but i don't have right fix yet.

If you are interested, take latest -mm (mmotm from userweb) and apply this manually:

--- linux-mm/drivers/hwmon/hp_accel.c 2009-01-06 10:54:40.000000000
+0100
+++ linux/drivers/hwmon/hp_accel.c 2008-12-10 09:36:21.000000000
+0100
@@ -174,11 +174,35 @@
}

static struct led_classdev hpled_led = {

-       .name                   = "hp:red:hddprotection",
-       .default_trigger        = "heartbeat",
+       .name                   = "hp:red:hddprotect",
+       .default_trigger        = "none",
        .brightness_set         = hpled_set,

};

...led will stop blinking, and messages will be gone. (But note that if you turn on heartbeat or similar trigger, you'll still get the "scheduling in interrupt" nastyness...)
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#2 lore raw

Am Dienstag, den 06.01.2009, 11:14 +0100 schrieb Pavel Machek:

Quoted 34 lines
Quoted 6 lines

I have a HP Compaq nc2400 notebook, and having recently installed 2.6.28 (gentoo patchset, self configured), I have observed the following:

When {I manually, udev automatically} load the leds_hp_disk module, my disk-led flashes regularly _without_ disk activity. When I look at my dmesg I see the following:

Yes, that's a (mis-feature).

Quoted 2 lines
[  724.376881] BUG: scheduling while atomic: swapper/0/0x10000100
[  724.376886] Modules linked in: leds_hp_disk i915 drm snd_pcm_oss

And that's a bug. I know what causes it, but i don't have right fix yet.

If you are interested, take latest -mm (mmotm from userweb) and apply this manually:

--- linux-mm/drivers/hwmon/hp_accel.c 2009-01-06 10:54:40.000000000
+0100
+++ linux/drivers/hwmon/hp_accel.c 2008-12-10 09:36:21.000000000
+0100

(quoted diff) +2 -2
@@ -174,11 +174,35 @@
 }
 
 static struct led_classdev hpled_led = {
-       .name                   = "hp:red:hddprotection",
-       .default_trigger        = "heartbeat",
+       .name                   = "hp:red:hddprotect",
+       .default_trigger        = "none",
        .brightness_set         = hpled_set,
 };
 
 
Quoted 4 lines

...led will stop blinking, and messages will be gone. (But note that if you turn on heartbeat or similar trigger, you'll still get the "scheduling in interrupt" nastyness...)
Pavel

Hello :)

Sorry it took me so long to reply - I built a kernel based on vanilla-2.6.28 and applied patches with quilt to .DATE=2009-01-05-12-50. That worked well, except that when booted, the xfs driver corrupts each time my MUAs (evolution) configuration :(

But not your problem... the LED-scheduling-problem went away (no more blinking, on more kernel-BUG and I get:

[   31.822317] lis3lv02d: laptop model unknown, using default axes
configuration
[   31.822367] Registered led device: hp:red:hddprotect
[   32.059496] input: ST LIS3LV02DL Accelerometer
as /devices/platform/lis3lv02d/input/input8
[   32.081954] lis3lv02d driver loaded.
$ lsmod | egrep 'lis3lv02d|hp_accel'
hp_accel                6656  0 
led_class               3908  2 iwl3945,hp_accel
lis3lv02d               5956  1 hp_accel

/sys/devices/platform/lis3lv02d
/sys/bus/platform/devices/lis3lv02d
/sys/bus/acpi/drivers/lis3lv02d
/sys/module/lis3lv02d
/sys/module/hp_accel

I was shortly confused, because CONFIG_LEDS_HP_DISK went away and got integrated into CONFIG_SENSORS_LIS3LV02D with lis3lv02d-merge-with-leds-hp-disk.patch :)

Bye,
Daniel

#3 lore raw
Quoted 9 lines · Daniel Troeder

Am Dienstag, den 06.01.2009, 11:14 +0100 schrieb Pavel Machek:

Quoted 8 lines
Quoted 6 lines

I have a HP Compaq nc2400 notebook, and having recently installed 2.6.28 (gentoo patchset, self configured), I have observed the following:

When {I manually, udev automatically} load the leds_hp_disk module, my disk-led flashes regularly _without_ disk activity. When I look at my dmesg I see the following:

Yes, that's a (mis-feature).

What did does it flash, btw? It is red on hp2133 (while disk light is normally white).

Quoted 3 lines

I was shortly confused, because CONFIG_LEDS_HP_DISK went away and got integrated into CONFIG_SENSORS_LIS3LV02D with lis3lv02d-merge-with-leds-hp-disk.patch :)

Yep.... and thanks.

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#4 lore raw

Am Donnerstag, den 08.01.2009, 12:49 +0100 schrieb Pavel Machek:

Quoted 5 lines · Daniel Troeder
Quoted 4 lines

Am Dienstag, den 06.01.2009, 11:14 +0100 schrieb Pavel Machek:

Quoted 3 lines
Quoted 3 lines

I have a HP Compaq nc2400 notebook, and having recently installed 2.6.28 (gentoo patchset, self configured), I have observed the following:

Quoted 8 lines
Quoted 5 lines
Quoted 5 lines
Quoted 3 lines

When {I manually, udev automatically} load the leds_hp_disk module, my disk-led flashes regularly _without_ disk activity. When I look at my dmesg I see the following:

Yes, that's a (mis-feature).

What did does it flash, btw? It is red on hp2133 (while disk light is normally white).

It flashes orange, while normal HDD-activity-color is green.

(BTW: Problem persists in 2.6.28.1.)

Bye,
Daniel

#5 lore raw
Quoted 10 lines · Daniel Troeder

Am Donnerstag, den 08.01.2009, 12:49 +0100 schrieb Pavel Machek:

Quoted 9 lines · Daniel Troeder
Quoted 8 lines

Am Dienstag, den 06.01.2009, 11:14 +0100 schrieb Pavel Machek:

Quoted 7 lines
Quoted 6 lines

I have a HP Compaq nc2400 notebook, and having recently installed 2.6.28 (gentoo patchset, self configured), I have observed the following:

When {I manually, udev automatically} load the leds_hp_disk module, my disk-led flashes regularly _without_ disk activity. When I look at my dmesg I see the following:

Quoted 5 lines
Quoted 4 lines
Quoted 1 line
Quoted 1 line

Yes, that's a (mis-feature).

What did does it flash, btw? It is red on hp2133 (while disk light is normally white).

It flashes orange, while normal HDD-activity-color is green.

Thanks.

Quoted 1 line

(BTW: Problem persists in 2.6.28.1.)

Should be fixed in 2.6.29-rc2.
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html