byteorder: add load/store_{endian} api
PATCH 1/7 byteorder: add load/store_{endian} api
load_le16 is a synonym for the existing le16_to_cpup and is added to be symmetric with the load_le16_noalign API. On arches where unaligned access is OK, the unaligned calls are replaced with aligned calls.
store_le16 is a new API and is added to be symmetric with the unaligned functions. It is implemented as a macro to allow compile-time byteswapping when the value is a constant. This will also allow use in many places currently that are of the form:
*(__le16 *)ptr = cpu_to_le16(foo);
In addition, some drivers/filesystems/arches already provide this API privately, which will allow them to be consolidated into this common code.
Also, on arches where load-swapped through a pointer is available, load_le16 is more efficient than le16_to_cpu(*ptr), and no worse on arches that don't provide the load-swapped. load_le16 is a shorter name and hopefully will encourage more use of this API. It will also make the aligned/unaligned cases have a consistent namespace, making it easier to remember.
---
Linus, this set was in -mm for awhile and was only dropped recently due to the byteorder churn (conditional include you disliked)
include/linux/byteorder/generic.h | 25 +++++++++++++++++++------ 1 files changed, 19 insertions(+), 6 deletions(-)
include/linux/byteorder/generic.h +19 -6
@@ -119,6 +119,19 @@#define cpu_to_be16s __cpu_to_be16s#define be16_to_cpus __be16_to_cpus +#define load_le16 __le16_to_cpup +#define load_le32 __le32_to_cpup +#define load_le64 __le64_to_cpup +#define load_be16 __be16_to_cpup +#define load_be32 __be32_to_cpup +#define load_be64 __be64_to_cpup +#define store_le16 (p, val) (*(__le16 *)(p) = cpu_to_le16(val)) +#define store_le32 (p, val) (*(__le32 *)(p) = cpu_to_le32(val)) +#define store_le64 (p, val) (*(__le64 *)(p) = cpu_to_le64(val)) +#define store_be16 (p, val) (*(__be16 *)(p) = cpu_to_be16(val)) +#define store_be32 (p, val) (*(__be32 *)(p) = cpu_to_be32(val)) +#define store_be64 (p, val) (*(__be64 *)(p) = cpu_to_be64(val)) +/* * They have to be macros in order to do the constant folding * correctly - if the argument passed into a inline function
@@ -142,32 +155,32 @@static inline void le16_add_cpu (__le16 *var,u16 val) { - *var =cpu_to_le16 (le16_to_cpu (*var) + val); +store_le16 (var,load_le16 (var) + val); }static inline void le32_add_cpu (__le32 *var,u32 val) { - *var =cpu_to_le32 (le32_to_cpu (*var) + val); +store_le32 (var,load_le32 (var) + val); }static inline void le64_add_cpu (__le64 *var,u64 val) { - *var =cpu_to_le64 (le64_to_cpu (*var) + val); +store_le64 (var,load_le64 (var) + val); }static inline void be16_add_cpu (__be16 *var,u16 val) { - *var =cpu_to_be16 (be16_to_cpu (*var) + val); +store_be16 (var,load_be16 (var) + val); }static inline void be32_add_cpu (__be32 *var,u32 val) { - *var =cpu_to_be32 (be32_to_cpu (*var) + val); +store_be32 (var,load_be32 (var) + val); }static inline void be64_add_cpu (__be64 *var,u64 val) { - *var =cpu_to_be64 (be64_to_cpu (*var) + val); +store_be64 (var,load_be64 (var) + val); }#endif /* _LINUX_BYTEORDER_GENERIC_H */
Signature · 1 line
1.6.1.212.g4b3ec