Skip to contentSkip to conversation

typhoon: replace users of __constant_{endian}

PATCH In review Harvey Harrison 3 participants 5 messages Jan 16, 2009 – Jan 19, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 typhoon: replace users of __constant_{endian}

The base versions handle constant folding just fine, use them directly.

---
All the byteorder patches have landed as of 2.6.29-rc1, please apply.

 drivers/net/typhoon.c |    2 +-
 drivers/net/typhoon.h |  234 ++++++++++++++++++++++++------------------------
 2 files changed, 118 insertions(+), 118 deletions(-)
drivers/net/typhoon.c +1 -1
index 3af9a95..d1c9bc9 100644
@@ -1944,7 +1944,7 @@ typhoon_start_runtime(struct typhoon *tp)
 		goto error_out;
 
 	INIT_COMMAND_NO_RESPONSE(&xp_cmd, TYPHOON_CMD_VLAN_TYPE_WRITE);
-	xp_cmd.parm1 = __constant_cpu_to_le16(ETH_P_8021Q);
+	xp_cmd.parm1 = cpu_to_le16(ETH_P_8021Q);
 	err = typhoon_issue_command(tp, 1, &xp_cmd, 0, NULL);
 	if(err < 0)
 		goto error_out;
drivers/net/typhoon.h +117 -117

305 lines not on this page · raw message

Signature · 1 line
1.6.1.249.g455e5
#3 lore raw
Quoted 11 lines · David Miller

From: David Dillow <[email protected]>
Date: Thu, 15 Jan 2009 22:18:04 -0500

Quoted 6 lines · Harvey Harrison
Quoted 4 lines

The base versions handle constant folding just fine, use them directly.

Applied for 2.6.30, thanks everyone.

Dave, I split out typhoon as it had the most uses of the __constant_ versions, the other net drivers have only a handful each, should I bother splitting that one up, or would you be OK with an omnibus patch?

Harvey

maintainer
#4 lore raw

From: Harvey Harrison <[email protected]>
Date: Sun, 18 Jan 2009 22:19:18 -0800

Quoted 9 lines · David Miller
Quoted 8 lines

From: David Dillow <[email protected]>
Date: Thu, 15 Jan 2009 22:18:04 -0500

Quoted 5 lines · Harvey Harrison
Quoted 4 lines

The base versions handle constant folding just fine, use them directly.

Quoted 8 lines
Quoted 3 lines
Quoted 1 line

Applied for 2.6.30, thanks everyone.

Dave, I split out typhoon as it had the most uses of the __constant_ versions, the other net drivers have only a handful each, should I bother splitting that one up, or would you be OK with an omnibus patch?

Omnibus is fine.