Detailed Stack Information Patch [0/3]
Hi,
this is a patch which give you a better overview of the userland application stack usage, especially for embedded linux.
Currently you are only able to dump the main process/thread stack usage which is showed in proc/pid/status by the "VmStk" Value. But you get no information about the consumed stack memory of the the threads.
The patch is splitted in three parts.
Part 1 :
--------
This is an enhancement in the /proc/<pid>/tasks/<tid>/maps and smaps which marks the mapping where the thread stack pointer reside with "[thread stack]".
Also there is a new entry "stack usage" in proc/pid/status, which will you give the current stack usage.
This feature will be enabled the which "enable /proc/<pid> stack monitoring" under "General setup-->"
Part 2:
-------
This enable a new /proc/stackmon file entry. A cat /proc/stackmon will produce a output like:
bytes pages maxpages vm_start vm_end processid threadid name
436 1 1 afdbf000-afdd4000 pid: 409 tid: 409 syslogd
1168 1 1 afd12000-afd27000 pid: 411 tid: 411 sh
516 1 1 afe6c000-afe81000 pid: 412 tid: 412 getty
4580 2 2 af918000-af92d000 pid: 419 tid: 419 catThe first value is the current effektive stack usage in bytes.
The second value is the current real stack usage in pages. This means how many pages are really occupied by the stack.
The thrird value is the maximum real stack usage in pages. This value will be determinate by the difference of the highest used page in the mapping and the page of stack start address.
The fourth value is the start- and end- address of the mapping where the stack currently reside.
The fifth value process id.
The sixth value is thread id.
And the seventh and last entry is the name of the process.
This feature will be enabled the which "enable /proc/<pid> stack monitoring" under "General setup-->".
Part 3:
-------
There is also an additional stack monitor which can be enabled by boot time or by the /sys filesystem. Which this you are able to detect if a application use more stack than a given value. If the application exceeds this value, it will receive a SIGTRAP signal.
If there is a debugger attached at this time, there is the ability to examinate the stack usage. Otherwise the application will be terminated. In both cases a kernel log entry "pid:%d (%s) tid:%d stack size %lu exceeds max stack size." will be written.
There are following entries under /sys/kernel/stackmon to control the monitor.
mode:
Setting this to an value not equal zero will start the stack monitoring
thread. Default is 0. Setting it to zero will stop the kernel thread.
stacksize:
This value is the stack size in kb which triggers a SIGTRAP to the
application, if the stack usage is equal or more. Default is 256 kb.
ticks:
Number of ticks between the monitoring invocation. A higher value will
give a less change to trigger a stack over usage, but will also result in a less CPU usage. Default is 1.
All this parameters can also set at boot time with the kernel parameter "stackmon=<stacksize>:<mode>:<ticks>".
The monitor can also compiled as a module.
This patch is against 2.6.28.1. The patch is cpu independent, so it should work on all linux supported architectures, it was tested under x86 and powerpc. Also there is not dependency a library: glibc, uclibc and all other should work.
I hope you like it and want ask what is necessary for inclusion into the main stream kernel or linux-next? If you have ideas how to do things in a better way, please let me know.
Have a nice day,
Stefani
Quoted 10 lines · Stefani Seibold
this is a patch which give you a better overview of the userland application stack usage, especially for embedded linux.
Currently you are only able to dump the main process/thread stack usage which is showed in proc/pid/status by the "VmStk" Value. But you get no information about the consumed stack memory of the the threads.
[...]
Quoted 8 lines
This patch is against 2.6.28.1. The patch is cpu independent, so it should work on all linux supported architectures, it was tested under x86 and powerpc. Also there is not dependency a library: glibc, uclibc and all other should work.
I hope you like it and want ask what is necessary for inclusion into the main stream kernel or linux-next? If you have ideas how to do things in a better way, please let me know.
First goal would be to get people interested. Why would Joe Kernelhacker care about this, what problem would it solve for him? Next goal is to prove to akpm that the solved problems are worth the maintenance burden this code brings.
It would be nice to have diffstat added to each patch to give people a quick overview. More importantly, the number of #ifdef's in the patches may raise a red flag. You should try to remove them from common code and have a single one in the headers:
#ifdef CONFIG_NEW_FEATURE
void handle_this(int foo, long bar);
#else
static inline void handle_this(int foo, long bar)
{
}
#endif
Not sure what else to say. I'm still wondering whether it will solve a problem for me.
Jörn
Signature · 2 lines
Joern's library part 4: http://www.paulgraham.com/spam.html
First, i had explained what is the reason for the patch.
Second, the number of #ifdef is not more or less than other features which extends the task_struct on demand.
There is no way to do this without #ifdef's, only if i add this feature without a CONFIG_.... option.
I think the main reason why i get low responses is, because i posted it to the wrong mail list. kernel-mm would be a better place for this.
So i will wait until 2.6.29 is out, then move my patch to this version, enhance it, add a diffstat and try it again which are more detailed reason why this patch should be included.
But this patch did nit solve a problem, it is a feature like PROC_PAGE_MONITOR or similar. It will help to figure out, how much stack will be consumed by a particular process or thread.
It also not a patch which cares Joe Kernelhacker, it cares Jane Userlandhacker!
Thnx,
Steffi
Am Donnerstag, den 22.01.2009, 20:41 +0100 schrieb Jörn Engel:
Quoted 46 lines · Stefani Seibold
Quoted 10 lines
this is a patch which give you a better overview of the userland application stack usage, especially for embedded linux.
Currently you are only able to dump the main process/thread stack usage which is showed in proc/pid/status by the "VmStk" Value. But you get no information about the consumed stack memory of the the threads.
[...]
Quoted 8 lines
This patch is against 2.6.28.1. The patch is cpu independent, so it should work on all linux supported architectures, it was tested under x86 and powerpc. Also there is not dependency a library: glibc, uclibc and all other should work.
I hope you like it and want ask what is necessary for inclusion into the main stream kernel or linux-next? If you have ideas how to do things in a better way, please let me know.
First goal would be to get people interested. Why would Joe Kernelhacker care about this, what problem would it solve for him? Next goal is to prove to akpm that the solved problems are worth the maintenance burden this code brings.
It would be nice to have diffstat added to each patch to give people a quick overview. More importantly, the number of #ifdef's in the patches may raise a red flag. You should try to remove them from common code and have a single one in the headers:
#ifdef
CONFIG_NEW_FEATUREvoid
handle_this(int foo, long bar);#else
static inline void
handle_this(int foo, long bar)
{
}
#endifNot sure what else to say. I'm still wondering whether it will solve a problem for me.
Jörn
http://en.wikipedia.org/wiki/Posting_style
Quoted 2 lines · Stefani Seibold
First, i had explained what is the reason for the patch.
You did explain your solution. The problem you are trying to solve was not clear to me. It may be my mistake. If you have the stack information, what can you do that you couldn't do without? Notice overly large stacks and fix the application? I would guess so, but you surely know better than me.
Quoted 5 lines
Second, the number of #ifdef is not more or less than other features which extends the
task_structon demand.There is no way to do this without #ifdef's, only if i add this feature without a
CONFIG_.... option.
True. The comment was not about removing them completely but moving them where they hurt less. When I'm reading through some generic code and I read something like this:
f->f_pos = 0; f->f_op = fops_get(inode->i_fop); file_move(f, &inode->i_sb->s_files); error = security_dentry_open(f); if (error) goto cleanup_all;
I only get slightly distracted by the security_dentry_open() that I personally may not care about one bit. Much nicer than having this:
f->f_pos = 0; f->f_op = fops_get(inode->i_fop); file_move(f, &inode->i_sb->s_files);
#ifdef CONFIG_SECURITY error = security_dentry_open(f); if (error) goto cleanup_all;
#endif
See the difference?
Quoted 6 lines
But this patch did nit solve a problem, it is a feature like
PROC_PAGE_MONITORor similar. It will help to figure out, how much stack will be consumed by a particular process or thread.It also not a patch which cares Joe Kernelhacker, it cares Jane Userlandhacker!
Fair enough. So assuming I wanted to reduce or limit stack consumption, what would I do with this information. I know the responsible process, but not the callchain. kill -QUIT 12345 would give me a core dump and I could analyse that.
Is that what you try to achieve? I was only guessing and may have missed a more important point.
Jörn
Signature · 2 lines
Everything should be made as simple as possible, but not simpler. -- Albert Einstein