Skip to contentSkip to conversation

Doubts in usr/include/linux/elf.h

DISCUSSION Jaswinder Singh Rajput 2 participants 2 messages Jan 21, 2009

lore
Share & tools
lore
#0 lore raw

usr/include/linux/elf.h is giving 4 'make headers_check' warnings:
usr/include/linux/elf.h:379: extern's make no sense in userspace usr/include/linux/elf.h:387: extern's make no sense in userspace usr/include/linux/elf.h:401: extern's make no sense in userspace usr/include/linux/elf.h:402: extern's make no sense in userspace

usr/include/linux/elf.h:
--
#if ELF_CLASS == ELFCLASS32

extern Elf32_Dyn _DYNAMIC [];

#define elfhdr          elf32_hdr
#define elf_phdr        elf32_phdr
#define elf_note        elf32_note
#define elf_addr_t      Elf32_Off

#else

extern Elf64_Dyn _DYNAMIC [];

#define elfhdr          elf64_hdr
#define elf_phdr        elf64_phdr
#define elf_note        elf64_note
#define elf_addr_t      Elf64_Off

#endif

/* Optional callbacks to write extra ELF notes. */
#ifndef ARCH_HAVE_EXTRA_ELF_NOTES
static __inline__ int elf_coredump_extra_notes_size(void) { return 0; } static __inline__ int elf_coredump_extra_notes_write(struct file *file,

                        loff_t *foffset) { return 0; }

#else
extern int elf_coredump_extra_notes_size(void);
extern int elf_coredump_extra_notes_write(struct file *file, loff_t *foffset); #endif
--

Which things we can drop from this portion to get rid of above warnings.

Thanks

--
JSR

#1 lore raw
Quoted 19 lines · Jaswinder Singh Rajput

usr/include/linux/elf.h is giving 4 'make headers_check' warnings:
usr/include/linux/elf.h:379: extern's make no sense in userspace usr/include/linux/elf.h:387: extern's make no sense in userspace usr/include/linux/elf.h:401: extern's make no sense in userspace usr/include/linux/elf.h:402: extern's make no sense in userspace

usr/include/linux/elf.h:
--
#if ELF_CLASS == ELFCLASS32

extern Elf32_Dyn _DYNAMIC [];

#define elfhdr          elf32_hdr
#define elf_phdr        elf32_phdr
#define elf_note        elf32_note
#define elf_addr_t      Elf32_Off

#else

Quoted 7 lines

extern Elf64_Dyn _DYNAMIC [];

#define elfhdr          elf64_hdr
#define elf_phdr        elf64_phdr
#define elf_note        elf64_note
#define elf_addr_t      Elf64_Off

#endif

If my quick grep is correct we fo not define any variable named _DYNAMIC. So you can just drop these two lines.

Quoted 10 lines

/* Optional callbacks to write extra ELF notes. */
#ifndef ARCH_HAVE_EXTRA_ELF_NOTES
static __inline__ int elf_coredump_extra_notes_size(void) { return 0; } static __inline__ int elf_coredump_extra_notes_write(struct file *file,

                        loff_t *foffset) { return 0; }

#else
extern int elf_coredump_extra_notes_size(void);
extern int elf_coredump_extra_notes_write(struct file *file, loff_t *foffset); #endif

And the above can all be wrapped in __KERNEL__.
They got renamed in 2007:
http://ozlabs.org/pipermail/cbe-oss-dev/2007-September/003276.html

So they are hardly used by userspace anyway.

Sam