Don't show cocoa window when it's unused
PATCH 1/1 Don't show cocoa window when it's unused
While working with Qemu on Mac OS X I got really annoyed by it showing a window every time I start it with -nographic or -vnc.
This patch (uglyly) checks if we need to show that window at all and if not behaves the same way the non-cocoa version does.
--- cocoa.m | 15 +++++++++++++++ 1 files changed, 15 insertions(+), 0 deletions(-)
cocoa.m +15 -0
@@ -853,6 +853,21 @@ int main (int argc, const char * argv[]) { gArgc = argc; gArgv = (char **)argv; CPSProcessSerNum PSN; + int noCocoa = 0; + int i; + + /* In case we don't need to display a window, let's not do that */ + for (i=1; i<argc; i++) { + if (!strcmp(argv[i], "-vnc") || + !strcmp(argv[i], "-nographic") || + !strcmp(argv[i], "-curses")) { + noCocoa = 1; + break; + } + } + + if (noCocoa) + return qemu_main(argc, argv); NSAutoreleasePool * pool = [[NSAutoreleasePool alloc] init]; [NSApplication sharedApplication];
Signature · 1 line
1.6.0.2
Quoted 37 lines · Alexander Graf
While working with Qemu on Mac OS X I got really annoyed by it showing a window every time I start it with -nographic or -vnc.
This patch (uglyly) checks if we need to show that window at all and if not behaves the same way the non-cocoa version does.
Signed-off-by Alexander Graf <[email protected]>---
cocoa.m | 15 +++++++++++++++1 files changed, 15 insertions(+), 0 deletions(-)cocoa.m +15
-0@@ -853,6 +853,21 @@ int main (int argc, const char * argv[]) { gArgc = argc; gArgv = (char **)argv; CPSProcessSerNum PSN; + int noCocoa = 0; + int i; + + /* In case we don't need to display a window, let's not do that */ + for (i=1; i<argc; i++) { + if (!strcmp(argv[i], "-vnc") || + !strcmp(argv[i], "-nographic") || + !strcmp(argv[i], "-curses")) { + noCocoa = 1; + break; + } + } + + if (noCocoa) + return qemu_main(argc, argv); NSAutoreleasePool * pool = [[NSAutoreleasePool alloc] init];
Quoted 3 lines
[NSApplication sharedApplication];Signature · 1 line
1.6.0.2
I'm currently working on updating cocoa.m for the displaystate changes, and if you don't mind, I'll gladly incorporate this into the patch I'm rewriting.
I do have a question though, without the window, how would you be able to access the monitor, or any of the consoles for that matter?. Does no -nographic or -vnc automatically assume -monitor stdio?
—Sam
Quoted 39 lines · Samuel Benson
Quoted 36 lines · Alexander Graf
While working with Qemu on Mac OS X I got really annoyed by it showing a window every time I start it with -nographic or -vnc.
This patch (uglyly) checks if we need to show that window at all and if not behaves the same way the non-cocoa version does.
Signed-off-by Alexander Graf <[email protected]>---
cocoa.m | 15 +++++++++++++++1 files changed, 15 insertions(+), 0 deletions(-)cocoa.m +4
-0@@ -853,6 +853,21 @@ int main (int argc, const char * argv[]) { gArgc = argc; gArgv = (char **)argv; CPSProcessSerNum PSN; + int noCocoa = 0; + int i; + + /* In case we don't need to display a window, let's not dothat */
cocoa.m +11
-0+ for (i=1; i<argc; i++) { + if (!strcmp(argv[i], "-vnc") || + !strcmp(argv[i], "-nographic") || + !strcmp(argv[i], "-curses")) { + noCocoa = 1; + break; + } + } + + if (noCocoa) + return qemu_main(argc, argv);
Quoted 7 lines
Quoted 4 lines
NSAutoreleasePool * pool = [[NSAutoreleasePool alloc] init]; [NSApplication sharedApplication];Signature · 1 line
1.6.0.2I'm currently working on updating cocoa.m for the displaystate changes, and if you don't mind, I'll gladly incorporate this into the patch I'm rewriting.
Sure :) I don't really think this is anything near advanced code or things your patches will touch, but if you like, go ahead and take it into your series. I really was merely annoyed by it while playing around a bit today.
Quoted 5 lines
I do have a question though, without the window, how would you be able to access the monitor, or any of the consoles for that matter?. Does no -nographic or -vnc automatically assume -monitor stdio?
-nographic routes monitor/serial port to stdio
-vnc replaces cocoa completely, so you get the monitor by pressing ctrl-alt-2 in the vnc window
Alex
Quoted 5 lines
�\Sam