Skip to contentSkip to conversation

virtio-pci: do not oops on config change if driver not loaded

PATCH Applied Mark McLoughlin 2 participants 2 messages Jan 29, 2009 – Jan 30, 2009 virtio core

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 virtio-pci: do not oops on config change if driver not loaded

The host really shouldn't be notifying us of config changes before the device status is VIRTIO_CONFIG_S_DRIVER or VIRTIO_CONFIG_S_DRIVER_OK.

However, if we do happen to be interrupted while we're not attached to a driver, we really shouldn't oops. Prevent this simply by checking that device->driver is non-NULL before trying to notify the driver of config changes.

Problem observed by doing a "set_link virtio.0 down" with QEMU before the net driver had been loaded.

---
 drivers/virtio/virtio_pci.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/virtio/virtio_pci.c +1 -1
index bef6b45..330aacb 100644
@@ -192,7 +192,7 @@ static irqreturn_t vp_interrupt(int irq, void *opaque)
 		drv = container_of(vp_dev->vdev.dev.driver,
 				   struct virtio_driver, driver);
 
-		if (drv->config_changed)
+		if (drv && drv->config_changed)
 			drv->config_changed(&vp_dev->vdev);
 	}
 
Signature · 1 line
1.6.0.6
#1 lore raw
Quoted 6 lines · On Friday 30 January 2009 02:02:16 Mark McLoughlin wrote:

The host really shouldn't be notifying us of config changes before the device status is VIRTIO_CONFIG_S_DRIVER or VIRTIO_CONFIG_S_DRIVER_OK.

However, if we do happen to be interrupted while we're not attached to a driver, we really shouldn't oops.

Thanks, applied!

Rusty.