Skip to contentSkip to conversation

simplify loop with if and do while

PATCH New Yann Simon 1 participant 1 message Jun 15, 2016

lore
Share & tools
lore

Yann Simon

author
#0 lore raw

PATCH 1/1 simplify loop with if and do while

replace if(condition) { do { } while (condition) } by while (condition) { }

---
 .../src/org/spearce/jgit/lib/Repository.java       |   18
+++++++-----------
 1 files changed, 7 insertions(+), 11 deletions(-)
(quoted diff) +0 -0

b/org.spearce.jgit/src/org/spearce/jgit/lib/Repository.java index 038a869..b6efac1 100644

org.spearce.jgit/src/org/spearce/jgit/lib/Repository.java +3 -5
@@ -247,11 +247,9 @@ public File toFile(final AnyObjectId objectId) {
 	public boolean hasObject(final AnyObjectId objectId) {
 		final PackFile[] packs = packs();
 		int k = packs.length;
-		if (k > 0) {
-			do {
-				if (packs[--k].hasObject(objectId))
-					return true;
-			} while (k > 0);
+		while (k > 0) {
+			if (packs[--k].hasObject(objectId))
+				return true;
 		}
 		return toFile(objectId).isFile();
 	}
@@ -288,12 +286,10 @@ public ObjectLoader openObject(final WindowCursor

curs, final AnyObjectId id)
throws IOException {
final PackFile[] packs = packs();
int k = packs.length;
- if (k > 0) {
- do {
- final ObjectLoader ol = packs[--k].get(curs, id);
- if (ol != null)
- return ol;
- } while (k > 0);
+ while (k > 0) {
+ final ObjectLoader ol = packs[--k].get(curs, id);
+ if (ol != null)
+ return ol;
}
try {
return new UnpackedObjectLoader(this, id);

Signature · 1 line
1.6.0.6