Skip to contentSkip to conversation

ppc4xx: Fix initialization of the SDRAM_CODT register

PATCH New Stefan Roese 1 participant 1 message Feb 12, 2009

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ppc4xx: Fix initialization of the SDRAM_CODT register

From: Carolyn Smith <[email protected]>

This fixes the initialization of the SDRAM_CODT register in the ppc4xx DDR2 initialization code. It also removes use of the SDRAM_CODT_FEEDBACK_RCV_SINGLE_END and SDRAM_CODT_FEEDBACK_DRV_SINGLE_END #define's since they are reserved bits.

---
v2:
- Generated by Stefan using git tools
- Minor coding style cleanup

 cpu/ppc4xx/44x_spd_ddr2.c |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)
cpu/ppc4xx/44x_spd_ddr2.c +2 -5
index 1e49571..33788cc 100644
@@ -1101,11 +1101,8 @@ static void program_codt(unsigned long *dimm_populated,
 	 * Set the SDRAM Controller On Die Termination Register
 	 *-----------------------------------------------------------------*/
 	mfsdram(SDRAM_CODT, codt);
-	codt |= (SDRAM_CODT_IO_NMODE
-		 & (~SDRAM_CODT_DQS_SINGLE_END
-		    & ~SDRAM_CODT_CKSE_SINGLE_END
-		    & ~SDRAM_CODT_FEEBBACK_RCV_SINGLE_END
-		    & ~SDRAM_CODT_FEEBBACK_DRV_SINGLE_END));
+	codt &= ~(SDRAM_CODT_DQS_SINGLE_END | SDRAM_CODT_CKSE_SINGLE_END);
+	codt |= SDRAM_CODT_IO_NMODE;
 
 	for (dimm_num = 0; dimm_num < num_dimm_banks; dimm_num++) {
 		if (dimm_populated[dimm_num] != SDRAM_NONE) {
Signature · 1 line
1.6.1.3