Skip to contentSkip to conversation

fsl: Don't spew messages related to PHY fixup of device tree

PATCH New Kumar Gala 2 participants 2 messages Feb 18, 2009 – Mar 7, 2009

lore
Share & tools
lore

Kumar Gala

author
#0 lore raw

PATCH 1/1 fsl: Don't spew messages related to PHY fixup of device tree

Converted print statements that didn't have much meaning beyond debug from printf() to debug().

---
 board/freescale/common/sgmii_riser.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
board/freescale/common/sgmii_riser.c +3 -3
index aeacb91..9326360 100644
@@ -47,7 +47,7 @@ void fsl_sgmii_riser_fdt_fixup(void *fdt)
 		const char *model;
 		const char *path;
 
-		printf("Updating PHY address for %s\n", dev->name);
+		debug("Updating PHY address for %s\n", dev->name);
 		if (!strstr(dev->name, "eTSEC"))
 			continue;
 
@@ -64,7 +64,7 @@ void fsl_sgmii_riser_fdt_fixup(void *fdt)
 
 		model = fdt_getprop(fdt, enet_node, "model", NULL);
 
-		printf("%s's model is %s\n", enet, model);
+		debug("%s's model is %s\n", enet, model);
 		/*
 		 * We only want to do this to eTSECs.  On some platforms
 		 * there are more than one type of gianfar-style ethernet
@@ -84,7 +84,7 @@ void fsl_sgmii_riser_fdt_fixup(void *fdt)
 
 		priv = dev->priv;
 
-		printf("Device flags are %x\n", priv->flags);
+		debug("Device flags are %x\n", priv->flags);
 		if (priv->flags & TSEC_SGMII)
 			fdt_setprop_cell(fdt, phynode, "reg", priv->phyaddr);
 	}
Signature · 1 line
1.5.6.6
#1 lore raw

PATCH 1/1 fsl: Don't spew messages related to PHY fixup of device tree

Quoted 4 lines · Kumar Gala

Converted print statements that didn't have much meaning beyond debug from printf() to debug().

I decided to solve this by removing the printfs. They aren't really useful for debugging, unless you're debugging the problems I already solved using them. :) They should have been removed before I committed the code.

Andy