Skip to contentSkip to conversation

add symbol value to help find the real depend

PATCH In review Cheng Renquan 2 participants 3 messages Feb 18, 2009 – Feb 23, 2009 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 add symbol value to help find the real depend

From: Cheng Renquan <[email protected]>

kbuild-menuconfig-display-depend-value.patch

Sometimes when configuring need to disable some unused item, but the item is selected by many other items, it's hard to find the real dependency which selected it, This patch add every symbol's value accompanied to make it possible to find the real dependency easily.

An example is CONFIG_RFKILL,

---------------------- RF switch subsystem support ----------------------

  | CONFIG_RFKILL:                                                        |
  |                                                                       |
  | Say Y here if you want to have control over RF switches               |
  | found on many WiFi and Bluetooth cards.                               |
  |                                                                       |
  | To compile this driver as a module, choose M here: the                |
  | module will be called rfkill.                                         |
  |                                                                       |
  | Symbol: RFKILL [=m]                                                   |
  | Prompt: RF switch subsystem support                                   |
  |   Defined at net/rfkill/Kconfig:4                                     |
  |   Depends on: NET [=y]                                                |
  |   Location:                                                           |
  |     -> Networking support (NET [=y])                                  |
  |   Selected by: IWLCORE [=n] && NETDEVICES [=y] && !S390 [=S390] && PC |
  |                                                                       |

----------------------------------------------------------------( 99%)---

---

scripts/kconfig/expr.c +3 -0
Index: linux-2.6.29-rc5-lio/scripts/kconfig/expr.c
===================================================================
@@ -1098,6 +1098,9 @@ void expr_fprint(struct expr *e, FILE *o
 static void expr_print_gstr_helper(void *data, struct symbol *sym, const char *str)
 {
 	str_append((struct gstr*)data, str);
+	if (sym)
+		str_printf((struct gstr *)data, " [=%s]",
+				sym_get_string_value(sym));
 }
 
 void expr_gstr_print(struct expr *e, struct gstr *gs)
#1 lore raw
Quoted 39 lines · On Wed, 18 Feb 2009 16:13:45 +0800 Cheng Renquan wrote:

From: Cheng Renquan <[email protected]>

kbuild-menuconfig-display-depend-value.patch

Sometimes when configuring need to disable some unused item, but the item is selected by many other items, it's hard to find the real dependency which selected it, This patch add every symbol's value accompanied to make it possible to find the real dependency easily.

An example is CONFIG_RFKILL,

---------------------- RF switch subsystem support ----------------------

  | CONFIG_RFKILL:                                                        |
  |                                                                       |
  | Say Y here if you want to have control over RF switches               |
  | found on many WiFi and Bluetooth cards.                               |
  |                                                                       |
  | To compile this driver as a module, choose M here: the                |
  | module will be called rfkill.                                         |
  |                                                                       |
  | Symbol: RFKILL [=m]                                                   |
  | Prompt: RF switch subsystem support                                   |
  |   Defined at net/rfkill/Kconfig:4                                     |
  |   Depends on: NET [=y]                                                |
  |   Location:                                                           |
  |     -> Networking support (NET [=y])                                  |
  |   Selected by: IWLCORE [=n] && NETDEVICES [=y] && !S390 [=S390] && PC |
  |                                                                       |

----------------------------------------------------------------( 99%)---

---

Index: linux-2.6.29-rc5-lio/scripts/kconfig/expr.c
===================================================================

scripts/kconfig/expr.c void expr_fprint(struct expr *e, FILE *o

Quoted 10 lines
scripts/kconfig/expr.c +3 -1
@@ -1098,6 +1098,9 @@ void expr_fprint(struct expr *e, FILE *o
 static void expr_print_gstr_helper(void *data, struct symbol *sym, const char *str)
 {
 	str_append((struct gstr*)data, str);
+	if (sym)
+		str_printf((struct gstr *)data, " [=%s]",
+				sym_get_string_value(sym));
 }
 
 void expr_gstr_print(struct expr *e, struct gstr *gs)
--

Hi,

This looks good/helpful. Can it be made to work with gconfig & xconfig as well as menuconfig?

Thanks,
---
~Randy

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw
Quoted 4 lines · Randy Dunlap

Hi,

This looks good/helpful. Can it be made to work with gconfig & xconfig as well as menuconfig?

Patches for gconfig & xconfig are already in progress, please be patient, I will post later. Thanks,

Signature · 3 lines
Cheng Renquan, Shenzhen, China
Henny Youngman  - "When I told my doctor I couldn't afford an
operation, he offered to touch-up my X-rays."