Skip to contentSkip to conversation

ppc4xx: PCIe: Change 16GB inbound memory to 4GB

PATCH New Stefan Roese 2 participants 2 messages Feb 18, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ppc4xx: PCIe: Change 16GB inbound memory to 4GB

This patch fixes a problem recently seen on some 4xx platforms. For example on Kilauea PCIe slot #0.

---

Felix, could you please test on your Kilaue with this patch applied? It fixes the problem on my system but please report if your board now boots correctly with the PCIe card plugged into both slots.

Thanks.

 cpu/ppc4xx/4xx_pcie.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
cpu/ppc4xx/4xx_pcie.c +2 -2
index 58d96bb..07fbb0e 100644
@@ -1028,10 +1028,10 @@ void ppc4xx_setup_pcie_rootpoint(struct pci_controller *hose, int port)
 #endif
 	}
 
-	/* Set up 16GB inbound memory window at 0 */
+	/* Set up 4GB inbound memory window at 0 */
 	out_le32(mbase + PCI_BASE_ADDRESS_0, 0);
 	out_le32(mbase + PCI_BASE_ADDRESS_1, 0);
-	out_le32(mbase + PECFG_BAR0HMPA, 0x7fffffc);
+	out_le32(mbase + PECFG_BAR0HMPA, 0x7ffffff);
 	out_le32(mbase + PECFG_BAR0LMPA, 0);
 
 	out_le32(mbase + PECFG_PIM01SAH, 0xffff0000);
Signature · 1 line
1.6.1.3
#1 lore raw

PATCH 1/1 ppc4xx: PCIe: Change 16GB inbound memory to 4GB

Quoted 12 lines · Stefan Roese

This patch fixes a problem recently seen on some 4xx platforms. For example on Kilauea PCIe slot #0.

---

Felix, could you please test on your Kilaue with this patch applied? It fixes the problem on my system but please report if your board now boots correctly with the PCIe card plugged into both slots.

Thanks.

Yes, this fixes my problem. Tested with single slot populated (0 and 1) and with 2 slots populated.

Thanks a lot for a quick fix.

Felix.

Quoted 21 lines
 cpu/ppc4xx/4xx_pcie.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
cpu/ppc4xx/4xx_pcie.c +2 -2
index 58d96bb..07fbb0e 100644
@@ -1028,10 +1028,10 @@ void ppc4xx_setup_pcie_rootpoint(struct pci_controller *hose, int port)
 #endif
 	}
 
-	/* Set up 16GB inbound memory window at 0 */
+	/* Set up 4GB inbound memory window at 0 */
 	out_le32(mbase + PCI_BASE_ADDRESS_0, 0);
 	out_le32(mbase + PCI_BASE_ADDRESS_1, 0);
-	out_le32(mbase + PECFG_BAR0HMPA, 0x7fffffc);
+	out_le32(mbase + PECFG_BAR0HMPA, 0x7ffffff);
 	out_le32(mbase + PECFG_BAR0LMPA, 0);
 
 	out_le32(mbase + PECFG_PIM01SAH, 0xffff0000);