kvm mmu: fix another largepage memory leak
PATCH 1/1 kvm mmu: fix another largepage memory leak
In the paging_fetch function rmap_remove is called after setting a large pte to non-present. This causes rmap_remove to not drop the reference to the large page. The result is a memory leak of that page.
--- arch/x86/kvm/paging_tmpl.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kvm/paging_tmpl.h +1 -1
@@ -306,9 +306,9 @@ static u64 *FNAME(fetch)(struct kvm_vcpu *vcpu, gva_t addr,continue ;if (is_large_pte (*sptep)) { +rmap_remove (vcpu->kvm, sptep);set_shadow_pte (sptep, shadow_trap_nonpresent_pte);kvm_flush_remote_tlbs (vcpu->kvm); -rmap_remove (vcpu->kvm, sptep); } if (level == PT_DIRECTORY_LEVEL
Signature · 1 line
1.5.6.4
Quoted 15 lines · Joerg Roedel
In the
paging_fetchfunctionrmap_removeis called after setting a large pte to non-present. This causesrmap_removeto not drop the reference to the large page. The result is a memory leak of that page.Signed-off-by Joerg Roedel <[email protected]>--- arch/x86/kvm/paging_tmpl.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/x86/kvm/paging_tmpl.h +0
-0
arch/x86/kvm/paging_tmpl.h static u64 *FNAME(fetch)(struct kvm_vcpu *vcpu, gva_t addr, · line 314
Quoted 10 lines
arch/x86/kvm/paging_tmpl.h +1
-1@@ -306,9 +306,9 @@ static u64 *FNAME(fetch)(struct kvm_vcpu *vcpu, gva_t addr,continue ;if (is_large_pte (*sptep)) { +rmap_remove (vcpu->kvm, sptep);set_shadow_pte (sptep, shadow_trap_nonpresent_pte);kvm_flush_remote_tlbs (vcpu->kvm); -rmap_remove (vcpu->kvm, sptep); } if (level == PT_DIRECTORY_LEVEL
ACK
Avi Kivity
AppliedQuoted 5 lines · Joerg Roedel
In the
paging_fetchfunctionrmap_removeis called after setting a large pte to non-present. This causesrmap_removeto not drop the reference to the large page. The result is a memory leak of that page.
Applied, thanks.
Signature · 1 line
error compiling committee.c: too many arguments to function