x86-tip: cpufreq breakage - bisection fingers 89c9215165ca609096e845926d9a18f1306176a4
Box is Q6600, X86_64. I haven't poked at it other than to verify the bisection result via patchlet below data.
[ 1.672700] overflow in relocation type 11 val 3a000f06b588 [ 1.681051] `processor' likely not compiled with -mcmodel=kernel [ 1.693753] overflow in relocation type 11 val 3a000f06b588 [ 1.693755] `processor' likely not compiled with -mcmodel=kernel [ 1.720399] thermal: Unknown symbol acpi_processor_set_thermal_limit [ 5.569294] overflow in relocation type 11 val 3a000f06b6d8 [ 5.578042] `processor' likely not compiled with -mcmodel=kernel [ 5.619269] overflow in relocation type 11 val 3a000f06b6e0 [ 5.619271] `processor' likely not compiled with -mcmodel=kernel [ 5.646081] overflow in relocation type 11 val 3a000f06b6e0 [ 5.655513] `processor' likely not compiled with -mcmodel=kernel [ 5.700693] overflow in relocation type 11 val 3a000f06b7c8 [ 5.700695] `processor' likely not compiled with -mcmodel=kernel [ 5.744519] overflow in relocation type 11 val 3a000f06b7c8 [ 5.772634] `processor' likely not compiled with -mcmodel=kernel [ 6.010536] thermal: Unknown symbol acpi_processor_set_thermal_limit [ 6.188154] overflow in relocation type 11 val 3a000f06b9f8 [ 6.188156] `processor' likely not compiled with -mcmodel=kernel [ 6.212162] thermal: Unknown symbol acpi_processor_set_thermal_limit [ 10.143511] overflow in relocation type 11 val 3a000f06ba98 [ 10.152509] `processor' likely not compiled with -mcmodel=kernel [ 10.612100] overflow in relocation type 11 val 3a000f06ddc8 [ 10.621221] `processor' likely not compiled with -mcmodel=kernel [ 10.731705] overflow in relocation type 11 val 3a000f06deb8 [ 10.740753] `processor' likely not compiled with -mcmodel=kernel [ 10.755799] overflow in relocation type 11 val 3a000f06deb8 [ 10.764934] `processor' likely not compiled with -mcmodel=kernel [ 10.967668] thermal: Unknown symbol acpi_processor_set_thermal_limit [ 11.019259] overflow in relocation type 11 val 3a000f06ded8 [ 11.028755] `processor' likely not compiled with -mcmodel=kernel [ 11.123935] overflow in relocation type 11 val 3a000f06def0 [ 11.133523] `processor' likely not compiled with -mcmodel=kernel [ 11.207454] thermal: Unknown symbol acpi_processor_set_thermal_limit [ 18.805201] overflow in relocation type 11 val 3a000f06f9a0 [ 18.813655] `processor' likely not compiled with -mcmodel=kernel [ 18.919112] overflow in relocation type 11 val 3a000f06f998 [ 18.927626] `freq_table' likely not compiled with -mcmodel=kernel [ 19.256349] acpi_cpufreq: Unknown symbol cpufreq_frequency_table_target [ 19.266022] acpi_cpufreq: Unknown symbol cpufreq_frequency_table_get_attr [ 19.275759] acpi_cpufreq: Unknown symbol acpi_processor_notify_smm [ 19.284741] acpi_cpufreq: Unknown symbol acpi_processor_unregister_performance [ 19.294857] acpi_cpufreq: Unknown symbol acpi_processor_preregister_performance [ 19.304938] acpi_cpufreq: Unknown symbol acpi_processor_register_performance [ 19.314833] acpi_cpufreq: Unknown symbol cpufreq_freq_attr_scaling_available_freqs [ 19.325205] acpi_cpufreq: Unknown symbol cpufreq_frequency_table_cpuinfo [ 19.334698] acpi_cpufreq: Unknown symbol cpufreq_frequency_table_put_attr [ 19.344204] acpi_cpufreq: Unknown symbol cpufreq_frequency_table_verify
89c9215165ca609096e845926d9a18f1306176a4 is first bad commit commit 89c9215165ca609096e845926d9a18f1306176a4
Author: Tejun Heo <[email protected]> Date: Tue Feb 24 11:57:21 2009 +0900
x86: add embedding percpu first chunk allocator
Impact: add better first percpu allocation for !NUMA
On !NUMA, we can simply allocate contiguous memory and use it for the first chunk without mapping it into vmalloc area. As the memory area is covered by the large page physical memory mapping, it allows the dynamic perpcu allocator to not add any TLB overhead for the static percpu area and whatever falls into the first chunk and the implementation is very simple too.
:040000 040000 2c918c6a40167d3ee5a86272682ed404ded599b6 7e1a548ab4aec547905ca35ea6a964c7241264a7 M arch
git bisect start
# good: [2450cf51a1bdba7037e91b1bcc494b01c58aaf66] Revert "menu: fix embedded menu snafu"
git bisect good 2450cf51a1bdba7037e91b1bcc494b01c58aaf66
# bad: [2b42bd438d4002ad42494f746f723f8d38320df1] Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-tip into x86-tip git bisect bad 2b42bd438d4002ad42494f746f723f8d38320df1
# good: [31526355272dfebdf1ad8cd0f452fc47c59ca221] manual merge of auto-iommu-next
git bisect good 31526355272dfebdf1ad8cd0f452fc47c59ca221
# good: [a131dd32f2409df645863e3e210ef1462ba8d6fa] Merge branch 'out-of-tree'
git bisect good a131dd32f2409df645863e3e210ef1462ba8d6fa
# bad: [680305b987ea818d995760040f813547a2712ff9] Merge branch 'x86/mm'
git bisect bad 680305b987ea818d995760040f813547a2712ff9
# good: [b95dcd235cbbd01c356e586b77ab8208a762a819] Merge branch 'x86/apic'
git bisect good b95dcd235cbbd01c356e586b77ab8208a762a819
# good: [96dfd063990da3be59093cd9a7f1af8981ad5b27] Merge branch 'warnings/complex'
git bisect good 96dfd063990da3be59093cd9a7f1af8981ad5b27
# good: [c6a8e0a97d660a9eb29808eb67adacb6b1bab373] Merge branch 'tracing/ftrace'
git bisect good c6a8e0a97d660a9eb29808eb67adacb6b1bab373
# good: [8d408b4be37bc49c9086531f2ebe411cf5731746] percpu: give more latitude to arch specific first chunk initialization
git bisect good 8d408b4be37bc49c9086531f2ebe411cf5731746
# bad: [56becc479934e00ec6ee7abfb6aec5e9bd744b39] Merge branch 'core/percpu'
git bisect bad 56becc479934e00ec6ee7abfb6aec5e9bd744b39
# bad: [40150d37be7f7949b2ec07d511244da856647d84] percpu: add __read_mostly to variables which are mostly read only
git bisect bad 40150d37be7f7949b2ec07d511244da856647d84
# bad: [89c9215165ca609096e845926d9a18f1306176a4] x86: add embedding percpu first chunk allocator
git bisect bad 89c9215165ca609096e845926d9a18f1306176a4
# good: [5f5d8405d1c50f5cf7e1dbfe9c9b44e2f015c8fd] x86: separate out setup_pcpu_4k() from setup_per_cpu_areas()
git bisect good 5f5d8405d1c50f5cf7e1dbfe9c9b44e2f015c8fd
arch/x86/kernel/setup_percpu.c +2 -0
@@ -392,8 +392,10 @@ void __init setup_per_cpu_areas(void)* each allocator for details. */ ret =setup_pcpu_remap (static_size); +#if 0 if (ret <0 ) ret =setup_pcpu_embed (static_size); +#endif if (ret <0 ) ret =setup_pcpu_4k (static_size);if (ret <0 )
Quoted 5 lines · Mike Galbraith
Box is Q6600,
X86_64. I haven't poked at it other than to verify the bisection result via patchlet below data.[ 1.672700] overflow in relocation type 11 val 3a000f06b588 [ 1.681051] `processor' likely not compiled with -mcmodel=kernel
btw., the .config you used, and the output of ld -v and gcc -v would be nice as well.
Ingo
Quoted 10 lines · Ingo Molnar
Quoted 5 lines · Mike Galbraith
Box is Q6600,
X86_64. I haven't poked at it other than to verify the bisection result via patchlet below data.[ 1.672700] overflow in relocation type 11 val 3a000f06b588 [ 1.681051] `processor' likely not compiled with -mcmodel=kernelbtw., the .config you used, and the output of ld -v and gcc -v would be nice as well.
GNU ld (GNU Binutils; openSUSE 11.0) 2.18.50.20080409-11.1
Using built-in specs.
Target: x86_64-suse-linux
Configured with: ../configure --prefix=/usr --with-local-prefix=/usr/local --infodir=/usr/share/info --mandir=/usr/share/man --libdir=/usr/lib64 --libexecdir=/usr/lib64 --enable-languages=c,c++,objc,fortran,obj-c++,java,ada --enable-checking=release --with-gxx-include-dir=/usr/include/c++/4.3 --enable-ssp --disable-libssp --with-bugurl=http://bugs.opensuse.org/ --with-pkgversion='SUSE Linux' --disable-libgcj --with-slibdir=/lib64 --with-system-zlib --enable-__cxa_atexit --enable-libstdcxx-allocator=new --disable-libstdcxx-pch --program-suffix=-4.3 --enable-version-specific-runtime-libs --enable-linux-futex --without-system-libunwind --with-cpu=generic --build=x86_64-suse-linux Thread model: posix
gcc version 4.3.1 20080507 (prerelease) [gcc-4_3-branch revision 135036] (SUSE Linux)
config attached.
-Mike
Hello,
Quoted 11 lines · Mike Galbraith
Quoted 9 lines · Ingo Molnar
Quoted 5 lines · Mike Galbraith
Box is Q6600,
X86_64. I haven't poked at it other than to verify the bisection result via patchlet below data.[ 1.672700] overflow in relocation type 11 val 3a000f06b588 [ 1.681051] `processor' likely not compiled with -mcmodel=kernelbtw., the .config you used, and the output of ld -v and gcc -v would be nice as well.
Quoted 7 lines
GNU ld (GNU Binutils; openSUSE 11.0) 2.18.50.20080409-11.1
Using built-in specs.
Target: x86_64-suse-linux
Configured with: ../configure --prefix=/usr --with-local-prefix=/usr/local --infodir=/usr/share/info --mandir=/usr/share/man --libdir=/usr/lib64 --libexecdir=/usr/lib64 --enable-languages=c,c++,objc,fortran,obj-c++,java,ada --enable-checking=release --with-gxx-include-dir=/usr/include/c++/4.3 --enable-ssp --disable-libssp --with-bugurl=http://bugs.opensuse.org/ --with-pkgversion='SUSE Linux' --disable-libgcj --with-slibdir=/lib64 --with-system-zlib --enable-__cxa_atexit --enable-libstdcxx-allocator=new --disable-libstdcxx-pch --program-suffix=-4.3 --enable-version-specific-runtime-libs --enable-linux-futex --without-system-libunwind --with-cpu=generic --build=x86_64-suse-linux Thread model: posix
gcc version 4.3.1 20080507 (prerelease) [gcc-4_3-branch revision 135036] (SUSE Linux)
I can't reproduce the problem here. My tool chains are newer tho (11.1). Hmmm... I really don't see how calling a function or not can cause relocation overflow in other places. For the linker, all three setup_pcpu functions aren't that different.
I'll set up a 11.0 system and see whether I can reproduce the problem. Just in case, can you please try to rebuild after mrproper?
Signature · 1 line
tejun
Quoted 1 line · Tejun Heo
I can't reproduce the problem here.
Guess I'll have to sharpen a stick or two then.
Quoted 2 lines
I'll set up a 11.0 system and see whether I can reproduce the problem. Just in case, can you please try to rebuild after mrproper?
Yup, still there. I even dropped the branch and started from scratch.
-Mike
Quoted 5 lines · Mike Galbraith
Quoted 1 line · Tejun Heo
I can't reproduce the problem here.
Guess I'll have to sharpen a stick or two then.
With monkey-see-monkey-do-stick, box becomes happy camper again.
arch/x86/kernel/setup_percpu.c +10 -0
@@ -256,6 +256,11 @@ static struct page * __init pcpue_get_page(unsigned int cpu, int pageno) + ((size_t)pageno << PAGE_SHIFT)); } +static void __init embed_populate_pte (unsigned long addr) +{ +populate_extra_pte (addr); +} +static ssize_t __init setup_pcpu_embed (size_t static_size) {unsigned int cpu;
@@ -284,10 +289,15 @@ static ssize_t __init setup_pcpu_embed(size_t static_size)pr_info ("PERCPU: Embedded %zu pages at %p, static data %zu bytes\n" , pcpue_unit_size >>PAGE_SHIFT , pcpue_ptr, static_size); +#if 0 return pcpu_setup_first_chunk (pcpue_get_page, static_size, pcpue_unit_size, pcpue_unit_size - static_size, pcpue_ptr,NULL ); +#else +return pcpu_setup_first_chunk (pcpue_get_page, static_size, +0 ,0 ,NULL , embed_populate_pte); +#endif }/*
Hello, Mike.
Quoted 28 lines · Mike Galbraith
Quoted 4 lines · Mike Galbraith
Quoted 1 line · Tejun Heo
I can't reproduce the problem here.
Guess I'll have to sharpen a stick or two then.
With monkey-see-monkey-do-stick, box becomes happy camper again.
arch/x86/kernel/setup_percpu.c +5
-0@@ -256,6 +256,11 @@ static struct page * __init pcpue_get_page(unsigned int cpu, int pageno) + ((size_t)pageno << PAGE_SHIFT)); } +static void __init embed_populate_pte (unsigned long addr) +{ +populate_extra_pte (addr); +} +static ssize_t __init setup_pcpu_embed (size_t static_size) {unsigned int cpu;@@ -284,10 +289,15 @@ static ssize_t __init setup_pcpu_embed(size_t static_size)pr_info ("PERCPU: Embedded %zu pages at %p, static data %zu bytes\n" , pcpue_unit_size >>PAGE_SHIFT , pcpue_ptr, static_size);
arch/x86/kernel/setup_percpu.c static ssize_t __init setup_pcpu_embed(size_t static_size) · line 301
Quoted 10 lines
arch/x86/kernel/setup_percpu.c +5
-0+#if 0 return pcpu_setup_first_chunk (pcpue_get_page, static_size, pcpue_unit_size, pcpue_unit_size - static_size, pcpue_ptr,NULL ); +#else +return pcpu_setup_first_chunk (pcpue_get_page, static_size, +0 ,0 ,NULL , embed_populate_pte); +#endif }
That isn't quite correct but is still very interesting that it fixes the build issue. Super weird. I'm almost done setting up 11.0 system. I'll dig into it as soon as I'm done with sata_nv -stable issue.
Thanks for drilling it down.
Signature · 1 line
tejun
Quoted 30 lines · Tejun Heo
Hello, Mike.
Quoted 27 lines · Mike Galbraith
Quoted 4 lines · Mike Galbraith
Quoted 1 line · Tejun Heo
I can't reproduce the problem here.
Guess I'll have to sharpen a stick or two then.
With monkey-see-monkey-do-stick, box becomes happy camper again.
arch/x86/kernel/setup_percpu.c +5
-0@@ -256,6 +256,11 @@ static struct page * __init pcpue_get_page(unsigned int cpu, int pageno) + ((size_t)pageno << PAGE_SHIFT)); } +static void __init embed_populate_pte (unsigned long addr) +{ +populate_extra_pte (addr); +} +static ssize_t __init setup_pcpu_embed (size_t static_size) {unsigned int cpu;@@ -284,10 +289,15 @@ static ssize_t __init setup_pcpu_embed(size_t static_size)pr_info ("PERCPU: Embedded %zu pages at %p, static data %zu bytes\n" , pcpue_unit_size >>PAGE_SHIFT , pcpue_ptr, static_size);
Quoted 14 lines
arch/x86/kernel/setup_percpu.c static ssize_t __init setup_pcpu_embed(size_t static_size) · line 301
Quoted 10 lines
arch/x86/kernel/setup_percpu.c +5
-0+#if 0 return pcpu_setup_first_chunk (pcpue_get_page, static_size, pcpue_unit_size, pcpue_unit_size - static_size, pcpue_ptr,NULL ); +#else +return pcpu_setup_first_chunk (pcpue_get_page, static_size, +0 ,0 ,NULL , embed_populate_pte); +#endif }That isn't quite correct but is still very interesting that it fixes the build issue. Super weird. I'm almost done setting up 11.0 system. I'll dig into it as soon as I'm done with
sata_nv-stable issue.
Hmm... on my openSUSE 11.0 it builds just fine.
$ gcc --version gcc (SUSE Linux) 4.3.1 20080507 (prerelease) [gcc-4_3-branch revision 135036] Copyright (C) 2008 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
$ ld --version GNU ld (GNU Binutils; openSUSE 11.0) 2.18.50.20080409-11.1 Copyright 2007 Free Software Foundation, Inc. This program is free software; you may redistribute it under the terms of the GNU General Public License version 3 or (at your option) a later version. This program has absolutely no warranty.
I've used the config file you attached and the commit ID I used is d0c4f570276cb4d2dc4215b90eb7cb6e2bdd4a15.
I wonder what is going on. I'll try again with 89c9215165ca609096e845926d9a18f1306176a4. Argh... weird.
Thanks.
--
tejun
Quoted 5 lines · Tejun Heo
I've used the config file you attached and the commit ID I used is
d0c4f570276cb4d2dc4215b90eb7cb6e2bdd4a15.I wonder what is going on. I'll try again with
89c9215165ca609096e845926d9a18f1306176a4. Argh... weird.
One thing. The config file you attached earlier doesn't have all the config vars for the above commits. Is it the correct config file?
Thanks.
Signature · 1 line
tejun
Quoted 3 lines · Tejun Heo
Quoted 2 lines · Tejun Heo
I've used the config file you attached and the commit ID I used is
d0c4f570276cb4d2dc4215b90eb7cb6e2bdd4a15.
My tip tree is at v2.6.29-rc6-2441-g4239438.
Quoted 5 lines
Quoted 2 lines
I wonder what is going on. I'll try again with
89c9215165ca609096e845926d9a18f1306176a4. Argh... weird.One thing. The config file you attached earlier doesn't have all the config vars for the above commits. Is it the correct config file?
Yes, verified.
-Mike
Quoted 2 lines · Tejun Heo
I wonder what is going on. I'll try again with
89c9215165ca609096e845926d9a18f1306176a4. Argh... weird.
marge:/ # modprobe processor
FATAL: Error inserting processor (/lib/modules/2.6.29-tip-smp/kernel/drivers/acpi/processor.ko): Invalid module format
I've got 80 _other_ modules loaded/working just fine, only the cpufreq stuff won't play ball.
I re-installed binutils/gcc/modutils, checked my repo via git fsck and rebuilt from scratch, and the problem remains. That very same module loads and cpufreq works just peachy with the hacklet I posted.
Yup, pretty weird.
-Mike
Quoted 6 lines · Mike Galbraith
Quoted 3 lines · Tejun Heo
Quoted 2 lines · Tejun Heo
I've used the config file you attached and the commit ID I used is
d0c4f570276cb4d2dc4215b90eb7cb6e2bdd4a15.My tip tree is at v2.6.29-rc6-2441-g4239438.
Eh... how do I map that to git commit?
Thanks.
Signature · 1 line
tejun
Quoted 9 lines · Tejun Heo
Quoted 6 lines · Mike Galbraith
Quoted 3 lines · Tejun Heo
Quoted 2 lines · Tejun Heo
I've used the config file you attached and the commit ID I used is
d0c4f570276cb4d2dc4215b90eb7cb6e2bdd4a15.My tip tree is at v2.6.29-rc6-2441-g4239438.
Eh... how do I map that to git commit?
The last 6, short form of 4239438b08fe8ec149ddc530238ca131bf88d290.
-Mike
Quoted 4 lines · Mike Galbraith
Quoted 3 lines · Tejun Heo
Quoted 2 lines · Mike Galbraith
Quoted 1 line · Tejun Heo
Tejun Heo wrote:
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
Quoted 2 lines
I've used the config file you attached and the commit ID I used is
d0c4f570276cb4d2dc4215b90eb7cb6e2bdd4a15.My tip tree is at v2.6.29-rc6-2441-g4239438.
Eh... how do I map that to git commit?
The last 6, short form of
4239438b08fe8ec149ddc530238ca131bf88d290.
^7
Quoted 4 lines · Mike Galbraith
Quoted 3 lines · Tejun Heo
Quoted 2 lines · Mike Galbraith
Quoted 1 line · Tejun Heo
Tejun Heo wrote:
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
Quoted 2 lines
I've used the config file you attached and the commit ID I used is
d0c4f570276cb4d2dc4215b90eb7cb6e2bdd4a15.My tip tree is at v2.6.29-rc6-2441-g4239438.
Eh... how do I map that to git commit?
The last 6, short form of
4239438b08fe8ec149ddc530238ca131bf88d290.
yes - but recent enough Git will do this for you automatically as well.
Ingo
Quoted 10 lines · Mike Galbraith
Quoted 7 lines · Tejun Heo
Quoted 5 lines · Mike Galbraith
Quoted 3 lines · Tejun Heo
Quoted 2 lines · Tejun Heo
I've used the config file you attached and the commit ID I used is
d0c4f570276cb4d2dc4215b90eb7cb6e2bdd4a15.My tip tree is at v2.6.29-rc6-2441-g4239438.
Eh... how do I map that to git commit?
The last 6, short form of
4239438b08fe8ec149ddc530238ca131bf88d290.
Okay, got it. It's slightly convoluted and can possibly affect other allocation methods too. I'll report back after trying a few things.
Thanks.
Signature · 1 line
tejun