Skip to contentSkip to conversation

ACPI : add a warning message if _BQC is not found

PATCH RESEND Superseded Zhang Rui 1 participant 1 message Mar 12, 2009 ACPI

lore
Share & tools
lore

Zhang Rui

author
#0 lore raw

PATCH RESEND 7/7 ACPI : add a warning message if _BQC is not found

ACPI backlight control w/o _BQC support is kinda firmware bug. Add a warning if _BQC is not implemented.

---
 drivers/acpi/video_detect.c |    3 +++
 1 file changed, 3 insertions(+)
drivers/acpi/video_detect.c +3 -0
Index: linux-2.6/drivers/acpi/video_detect.c
===================================================================
@@ -55,6 +55,9 @@ acpi_backlight_cap_match(acpi_handle han
 		ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Found generic backlight "
 				  "support\n"));
 		*cap |= ACPI_VIDEO_BACKLIGHT;
+		if (ACPI_FAILURE(acpi_get_handle(handle, "_BQC", &h_dummy)))
+			printk(KERN_WARNING FW_BUG PREFIX "ACPI brightness "
+					"control misses _BQC function\n");
 		/* We have backlight support, no need to scan further */
 		return AE_CTRL_TERMINATE;
 	}