fsl-ddr: Fix two bugs in the ddr infrastructure
PATCH 1/2 fsl-ddr: Fix two bugs in the ddr infrastructure
1. wr_lat
UM said the total write latency for DDR2 is equal to WR_LAT + ADD_LAT, the write latency is CL + ADD_LAT - 1. so, the WR_LAT = CL - 1;
2. rd_to_pre
we missed to add the ADD_LAT for DDR2 case.
Reported-by Joakim Tjernlund <[email protected]>
Signed-off-by Dave Liu <[email protected]>
---
The patch is resent to list, it is because the comming patch base one it.
cpu/mpc8xxx/ddr/ctrl_regs.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-)
cpu/mpc8xxx/ddr/ctrl_regs.c +4 -1
@@ -302,12 +302,15 @@ static void set_timing_cfg_2(fsl_ddr_cfg_regs_t *ddr,*/ wr_lat =0 ;#elif defined(CONFIG_FSL_DDR2 ) - wr_lat = cas_latency + additive_latency -1 ; + wr_lat = cas_latency -1 ;#else #error "Fix WR_LAT for DDR3"#endif rd_to_pre =picos_to_mclk (common_dimm->tRTP_ps); +#if defined(CONFIG_FSL_DDR2 ) + rd_to_pre += additive_latency; +#endif wr_data_delay = popts->write_data_delay; cke_pls =picos_to_mclk (popts->tCKE_clock_pulse_width_ps); four_act =picos_to_mclk (popts->tFAW_window_four_activates_ps);
Signature · 1 line
1.5.4