Skip to contentSkip to conversation

Neterion: New driver: Kconfig and Makefile

PATCH In review Ramkrishna Vepa 5 participants 6 messages Mar 14, 2009 – Mar 15, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 3/10 Neterion: New driver: Kconfig and Makefile

- Kconfig and Makefile related changes for vxge driver.

---

drivers/net/Kconfig +18 -0
diff -urpN patch_2/drivers/net/Kconfig patch_3/drivers/net/Kconfig
@@ -2531,6 +2531,24 @@ config S2IO
 	  More specific information on configuring the driver is in 
 	  <file:Documentation/networking/s2io.txt>.
 
+config VXGE
+	tristate "Neterion X3100 Series 10GbE PCIe Server Adapter"
+	depends on PCI
+	select INET_LRO
+	---help---
+	  This driver supports Neterion Inc's X3100 Series 10 GbE PCIe
+	  I/O Virtualized Server Adapter.
+	  More specific information on configuring the driver is in
+	  <file:Documentation/networking/vxge.txt>.
+
+config VXGE_DEBUG_TRACE_ALL
+	bool "Enabling All Debug trace statments in driver"
+	default n
+	depends on VXGE
+	---help---
+	  Say Y here if you want to enabling all the debug trace statements in
+	  driver. By  default only few debug trace statements are enabled.
+
 config MYRI10GE
 	tristate "Myricom Myri-10G Ethernet support"
 	depends on PCI && INET
drivers/net/Makefile +1 -0
diff -urpN patch_2/drivers/net/Makefile patch_3/drivers/net/Makefile
@@ -219,6 +219,7 @@ obj-$(CONFIG_R8169) += r8169.o
 obj-$(CONFIG_AMD8111_ETH) += amd8111e.o
 obj-$(CONFIG_IBMVETH) += ibmveth.o
 obj-$(CONFIG_S2IO) += s2io.o
+obj-$(CONFIG_VXGE) += vxge/
 obj-$(CONFIG_MYRI10GE) += myri10ge/
 obj-$(CONFIG_SMC91X) += smc91x.o
 obj-$(CONFIG_SMC911X) += smc911x.o
drivers/net/vxge/Makefile +9 -0
diff -urpN patch_2/drivers/net/vxge/Makefile patch_3/drivers/net/vxge/Makefile
@@ -0,0 +1,9 @@
+#
+# Makefile for Neterion Inc's X3100 Series 10 GbE PCIe
+# I/O Virtualized Server Adapter linux driver
+#
+
+obj-$(CONFIG_VXGE) += vxge.o
+
+vxge-objs := vxge-config.o vxge-traffic.o vxge-ethtool.o vxge-main.o
+
#1 lore raw
Quoted 12 lines · Ramkrishna Vepa

- Kconfig and Makefile related changes for vxge driver.

---
diff -urpN patch_2/drivers/net/Kconfig patch_3/drivers/net/Kconfig

drivers/net/Kconfig +0 -0
@@ -2531,6 +2531,24 @@ config S2IO
 	  More specific information on configuring the driver is in 
 	  <file:Documentation/networking/s2io.txt>.

drivers/net/Kconfig config S2IO · line 2542

Quoted 10 lines
drivers/net/Kconfig +9 -0
 
+config VXGE
+	tristate "Neterion X3100 Series 10GbE PCIe Server Adapter"
+	depends on PCI
+	select INET_LRO
+	---help---
+	  This driver supports Neterion Inc's X3100 Series 10 GbE PCIe
+	  I/O Virtualized Server Adapter.
+	  More specific information on configuring the driver is in
+	  <file:Documentation/networking/vxge.txt>.

To prevent certain build failures, when you "select INET_LRO" you also need to add a depends on INET, so the above "depends on PCI" needs to be changed to:

	depends on PCI && INET

						-Bill
#2 lore raw
Quoted 29 lines · Bill Fink
Quoted 12 lines · Ramkrishna Vepa

- Kconfig and Makefile related changes for vxge driver.

---
diff -urpN patch_2/drivers/net/Kconfig patch_3/drivers/net/Kconfig

drivers/net/Kconfig +0 -0
@@ -2531,6 +2531,24 @@ config S2IO
 	  More specific information on configuring the driver is in 
 	  <file:Documentation/networking/s2io.txt>.

drivers/net/Kconfig config S2IO · line 2542

Quoted 10 lines
drivers/net/Kconfig +9 -0
 
+config VXGE
+	tristate "Neterion X3100 Series 10GbE PCIe Server Adapter"
+	depends on PCI
+	select INET_LRO
+	---help---
+	  This driver supports Neterion Inc's X3100 Series 10 GbE PCIe
+	  I/O Virtualized Server Adapter.
+	  More specific information on configuring the driver is in
+	  <file:Documentation/networking/vxge.txt>.

To prevent certain build failures, when you "select INET_LRO" you also need to add a depends on INET, so the above "depends on PCI" needs to be changed to:

Quoted 1 line
	depends on PCI && INET

And I believe LRO has been deprecated in favor of GRO.

-Bill

maintainer
#3 lore raw

From: Bill Fink <[email protected]>
Date: Sat, 14 Mar 2009 14:08:57 -0400

Quoted 1 line

And I believe LRO has been deprecated in favor of GRO.

That's correct.

We should not add any new users of LRO.

#4 lore raw
In reply to Ramkrishna Vepa
Quoted 1 line · Ramkrishna Vepa

- Kconfig and Makefile related changes for vxge driver.

[...]

These should really come last in the series so they don't refer to nonexistent files. This may not matter for a new driver as Dave can squash them together into one patch.

Ben.

Signature · 3 lines
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
#5 lore raw

Ben,

Thanks for the comments. We will address them when we resubmit the patches in the next day or so.

Ram

Quoted 2 lines

-----Original Message-----
From: [email protected]

[mailto:[email protected]]

Quoted 25 lines

On Behalf Of Ben Hutchings
Sent: Sunday, March 15, 2009 12:10 PM
To: [email protected]
Cc: Netdev; David Miller
Subject: Re: [net-2.6 PATCH 3/10] Neterion: New driver: Kconfig and Makefile

Quoted 1 line · Ramkrishna Vepa

- Kconfig and Makefile related changes for vxge driver.

[...]

These should really come last in the series so they don't refer to nonexistent files. This may not matter for a new driver as Dave can squash them together into one patch.

Ben.

--
Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. --
To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html