Skip to contentSkip to conversation

tracing/syscalls: various cleanups

tip:tracing/syscalls Frederic Weisbecker 1 participant 1 message Mar 16, 2009 1 message not in the archive Tracing

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive
Commit-ID:  6404434525bb9f8f2239998f30fd7c93f2efa5b3
Gitweb:     http://git.kernel.org/tip/6404434525bb9f8f2239998f30fd7c93f2efa5b3
Author:     Frederic Weisbecker <[email protected]>
AuthorDate: Sun, 15 Mar 2009 22:10:36 +0100
Commit:     Ingo Molnar <[email protected]>
CommitDate: Mon, 16 Mar 2009 09:13:16 +0100

tracing/syscalls: various cleanups

Impact: cleanup

- Drop unused cpu variable
- Fix some errors on comments

LKML-Reference: <[email protected]>

---
 kernel/trace/trace_syscalls.c |   10 ++--------
 1 files changed, 2 insertions(+), 8 deletions(-)
kernel/trace/trace_syscalls.c +2 -8
index c5fc1d8..26f9a86 100644
@@ -7,7 +7,7 @@
 
 static atomic_t refcount;
 
-/* Our two options */
+/* Option to display the parameters types */
 enum {
 	TRACE_SYSCALLS_OPT_TYPES = 0x1,
 };
@@ -18,7 +18,7 @@ static struct tracer_opt syscalls_opts[] = {
 };
 
 static struct tracer_flags syscalls_flags = {
-	.val = 0, /* By default: no args types */
+	.val = 0, /* By default: no parameters types */
 	.opts = syscalls_opts
 };
 
@@ -135,12 +135,9 @@ void ftrace_syscall_enter(struct pt_regs *regs)
 	struct ring_buffer_event *event;
 	int size;
 	int syscall_nr;
-	int cpu;
 
 	syscall_nr = syscall_get_nr(current, regs);
 
-	cpu = raw_smp_processor_id();
-
 	sys_data = syscall_nr_to_meta(syscall_nr);
 	if (!sys_data)
 		return;
@@ -166,12 +163,9 @@ void ftrace_syscall_exit(struct pt_regs *regs)
 	struct syscall_metadata *sys_data;
 	struct ring_buffer_event *event;
 	int syscall_nr;
-	int cpu;
 
 	syscall_nr = syscall_get_nr(current, regs);
 
-	cpu = raw_smp_processor_id();
-
 	sys_data = syscall_nr_to_meta(syscall_nr);
 	if (!sys_data)
 		return;