: ACPI: Add the Pansonic CF51 box to the dmi check table
PATCH 1/1 : ACPI: Add the Pansonic CF51 box to the dmi check table
Subject: ACPI: Add the Pansonic CF51 box to the dmi check table
From: Zhao Yakui <[email protected]>
The Pansonic CF51-2L box can't be resumed if the boot option of "acpi_sleep=old_ordering" is not added.
Add the Pansonic CF51-2L to the dmi check table so that the old suspend order is used.
http://bugzilla.kernel.org/show_bug.cgi?id=12561
--- drivers/acpi/sleep.c | 9 +++++++++ 1 file changed, 9 insertions(+)
drivers/acpi/sleep.c +9 -0
@@ -378,6 +378,15 @@ DMI_MATCH(DMI_PRODUCT_NAME, "Macmini1,1"), }, }, + { + .callback = init_old_suspend_ordering, + .ident = "Pansonic CF51-2L", + .matches = { +DMI_MATCH (DMI_BOARD_VENDOR , +"Matsushita Electric Industrial Co.,Ltd." ), + DMI_MATCH(DMI_BOARD_NAME, "CF51-2L"), + }, + }, {}, };#endif /* CONFIG_SUSPEND */
Quoted 5 lines · yakui_zhao
Subject: ACPI: Add the Pansonic CF51 box to the dmi check table
From: Zhao Yakui <[email protected]>The Pansonic CF51-2L box can't be resumed if the boot option of "acpi_sleep=old_ordering" is not added.
Do we have any idea what's going on here, yet? Several of the machines on this blacklist are modern, so it's not a workaround for ancient hardware.
Signature · 1 line
Matthew Garrett | [email protected]
Quoted 11 lines · Matthew Garrett
Quoted 5 lines · yakui_zhao
Subject: ACPI: Add the Pansonic CF51 box to the dmi check table
From: Zhao Yakui <[email protected]>The Pansonic CF51-2L box can't be resumed if the boot option of "acpi_sleep=old_ordering" is not added.
Do we have any idea what's going on here, yet?
Several of the machines
on this blacklist are modern, so it's not a workaround for ancient hardware.
Now we have no idea how the behaviour is changed with the boot option. In fact the boot option is useful for all the boxes that can't be resumed unless it is added.
Although the machine is modern, the ACPI 1.0 is followed on this box. Without the boot option of "acpi_sleep=old_ordering", it can't be resumed from S3 correctly. But after adding the boot option, the box can be resumed.
Quoted 1 line
Quoted 5 lines · yakui_zhao
Quoted 4 lines · Matthew Garrett
Do we have any idea what's going on here, yet?
Several of the machines
on this blacklist are modern, so it's not a workaround for ancient hardware.
Quoted 8 lines
Now we have no idea how the behaviour is changed with the boot option. In fact the boot option is useful for all the boxes that can't be resumed unless it is added.
Although the machine is modern, the ACPI 1.0 is followed on this box. Without the boot option of "acpi_sleep=old_ordering", it can't be resumed from S3 correctly. But after adding the boot option, the box can be resumed.
Yes. So how do we tell which ordering a machine needs without having a blacklist? Windows doesn't.
Signature · 1 line
Matthew Garrett | [email protected]
Quoted 10 lines · Matthew Garrett
Quoted 9 lines · yakui_zhao
Quoted 4 lines · Matthew Garrett
Do we have any idea what's going on here, yet?
Several of the machines
on this blacklist are modern, so it's not a workaround for ancient hardware.Now we have no idea how the behaviour is changed with the boot option. In fact the boot option is useful for all the boxes that can't be resumed unless it is added.
Quoted 7 lines
Quoted 4 lines
Although the machine is modern, the ACPI 1.0 is followed on this box. Without the boot option of "acpi_sleep=old_ordering", it can't be resumed from S3 correctly. But after adding the boot option, the box can be resumed.
Yes. So how do we tell which ordering a machine needs without having a blacklist? Windows doesn't.
If there exists the different behaviour w/o the boot option, maybe it should be added to the blacklist.
Maybe there is no such blacklist on windows.
I verify this problem on windows by using KVM and find that the _PTS object is called after device suspend in course of hibernate.(No S3 is supported on KVM). In theory the _PTS is also called after device suspend in course of suspend.
But it is strange that suspend/resume can work well on windows XP. Maybe more registers are saved/restored in course of suspend. But we can't know what should be saved/restored.
Quoted 1 line
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 8 lines · yakui_zhao
Quoted 2 lines · Matthew Garrett
Yes. So how do we tell which ordering a machine needs without having a blacklist? Windows doesn't.
If there exists the different behaviour w/o the boot option, maybe it should be added to the blacklist.
Maybe there is no such blacklist on windows.
Quite. There shouldn't be on Linux.
Quoted 4 lines
I verify this problem on windows by using KVM and find that the
_PTSobject is called after device suspend in course of hibernate.(No S3 is supported on KVM). In theory the_PTSis also called after device suspend in course of suspend.
What would it take to fake S3 on KVM enough that we could instrument Windows' behaviour?
Quoted 3 lines
But it is strange that suspend/resume can work well on windows XP. Maybe more registers are saved/restored in course of suspend. But we can't know what should be saved/restored.
Nor can we continue adding machines to a blacklist.
Signature · 5 lines
Matthew Garrett | [email protected] -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 11 lines · Matthew Garrett
Quoted 8 lines · yakui_zhao
Quoted 2 lines · Matthew Garrett
Yes. So how do we tell which ordering a machine needs without having a blacklist? Windows doesn't.
If there exists the different behaviour w/o the boot option, maybe it should be added to the blacklist.
Maybe there is no such blacklist on windows.
Quite. There shouldn't be on Linux.
If there is no such blacklist, the suspend/resume can't wok well on some boxes. IMO this can be workaround for some boxes that can't be resumed.
Quoted 8 lines
Quoted 5 lines
I verify this problem on windows by using KVM and find that the
_PTSobject is called after device suspend in course of hibernate.(No S3 is supported on KVM). In theory the_PTSis also called after device suspend in course of suspend.What would it take to fake S3 on KVM enough that we could instrument Windows' behaviour?
The graphics simulated in KVM is too old.
Quoted 7 lines
Quoted 4 lines
But it is strange that suspend/resume can work well on windows XP. Maybe more registers are saved/restored in course of suspend. But we can't know what should be saved/restored.
Nor can we continue adding machines to a blacklist.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 7 lines · yakui_zhao
Quoted 4 lines · Matthew Garrett
Quoted 1 line · yakui_zhao
Maybe there is no such blacklist on windows.
Quite. There shouldn't be on Linux.
If there is no such blacklist, the suspend/resume can't wok well on some boxes. IMO this can be workaround for some boxes that can't be resumed.
Workarounds should be temporary. Blacklists scale badly. In the long run we need to determine why this doesn't work.
Quoted 8 lines
Quoted 7 lines
Quoted 4 lines
I verify this problem on windows by using KVM and find that the
_PTSobject is called after device suspend in course of hibernate.(No S3 is supported on KVM). In theory the_PTSis also called after device suspend in course of suspend.What would it take to fake S3 on KVM enough that we could instrument Windows' behaviour?
The graphics simulated in KVM is too old.
Is this simply a matter of the driver setting a flag to indicate that it supports S3?
Signature · 5 lines
Matthew Garrett | [email protected] -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Len Brown
reviewerI agree with Matthew that we need to find the root cause.
However, I've checked this into acpi-test in the interest of getting the box working w/o delay.
thanks,
Len Brown, Intel Open Source Technology Center