Skip to contentSkip to conversation

tracing/ftrace: fix missing include string.h

PATCH Superseded Frederic Weisbecker 2 participants 4 messages Mar 27, 2009 – Apr 7, 2009 Tracing

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tracing/ftrace: fix missing include string.h

Building a kernel with tracing can raise the following warning on tip/master:

kernel/trace/trace.c:1249: error: implicit declaration of function 'vbin_printf'

We are missing an include to string.h

---
 kernel/trace/trace.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
kernel/trace/trace.c +1 -0
index 2a81dec..704cd7f 100644
@@ -30,6 +30,7 @@
 #include <linux/percpu.h>
 #include <linux/splice.h>
 #include <linux/kdebug.h>
+#include <linux/string.h>
 #include <linux/ctype.h>
 #include <linux/init.h>
 #include <linux/poll.h>
Signature · 1 line
1.6.1
#1 lore raw

PATCH v2 1/1 tracing/ftrace: fix missing include string.h

Building a kernel with tracing can raise the following warning on tip/master:

kernel/trace/trace.c:1249: error: implicit declaration of function 'vbin_printf'

We are missing an include to string.h

[v2: add reported-by]

---
 kernel/trace/trace.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
kernel/trace/trace.c +1 -0
index 2a81dec..704cd7f 100644
@@ -30,6 +30,7 @@
 #include <linux/percpu.h>
 #include <linux/splice.h>
 #include <linux/kdebug.h>
+#include <linux/string.h>
 #include <linux/ctype.h>
 #include <linux/init.h>
 #include <linux/poll.h>
Signature · 1 line
1.6.1
#3 lore raw
In reply to Frederic Weisbecker
Commit-ID:  5f0c6c03c5fee91c02c696bc9bf4c0d41392abe7
Gitweb:     http://git.kernel.org/tip/5f0c6c03c5fee91c02c696bc9bf4c0d41392abe7
Author:     Frederic Weisbecker <[email protected]>
AuthorDate: Fri, 27 Mar 2009 14:22:10 +0100
Committer:  Ingo Molnar <[email protected]>
CommitDate: Tue, 7 Apr 2009 14:00:18 +0200

tracing/ftrace: fix missing include string.h

Building a kernel with tracing can raise the following warning on tip/master:

kernel/trace/trace.c:1249: error: implicit declaration of function 'vbin_printf'

We are missing an include to string.h

LKML-Reference: <[email protected]>

---
 kernel/trace/trace.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
kernel/trace/trace.c +1 -0
index 457dd8c..2230b46 100644
@@ -30,6 +30,7 @@
 #include <linux/percpu.h>
 #include <linux/splice.h>
 #include <linux/kdebug.h>
+#include <linux/string.h>
 #include <linux/ctype.h>
 #include <linux/init.h>
 #include <linux/poll.h>