Skip to contentSkip to conversation

Don't claim that we speak AT

PATCH New Russ Dill 2 participants 3 messages Apr 2, 2009

lore
Share & tools
lore

Russ Dill

author
#0 lore raw

PATCH 1/1 Don't claim that we speak AT

When we claim that we speak AT, Network Manager will send query us with AT commands.

---
 drivers/serial/usbtty.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/serial/usbtty.c +1 -1
index 2624e6f..1ed0e4d 100644
@@ -178,7 +178,7 @@ static struct acm_config_desc acm_configuration_descriptors[NUM_CONFIGS] = {
 			.bInterfaceClass =
 				COMMUNICATIONS_INTERFACE_CLASS_CONTROL,
 			.bInterfaceSubClass = COMMUNICATIONS_ACM_SUBCLASS,
-			.bInterfaceProtocol = COMMUNICATIONS_V25TER_PROTOCOL,
+			.bInterfaceProtocol = COMMUNICATIONS_NO_PROTOCOL,
 			.iInterface = STR_CTRL_INTERFACE,
 		},
 		.usb_class_header = {
Signature · 1 line
1.6.0.4
#1 lore raw

PATCH 1/1 Don't claim that we speak AT

Quoted 1 line · On Thursday 02 April 2009 09:06:13 Russ Dill wrote:

... will send query us with ...

one of those words should get dropped ... probably "send": "will query us with" ...

Quoted 1 line
 drivers/serial/usbtty.c |    2 +-

please put this info into the subject/summary. a simple "usbtty: " prefix in the subject would be fine.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090402/44562c07/attachment.pgp

author
#2 lore raw

PATCH 1/1 Don't claim that we speak AT

Quoted 12 lines · Mike Frysinger
Quoted 1 line · On Thursday 02 April 2009 09:06:13 Russ Dill wrote:

... will send query us with ...

one of those words should get dropped ... probably "send": "will query us with" ...

Quoted 1 line

?drivers/serial/usbtty.c | ? ?2 +-

please put this info into the subject/summary. ?a simple "usbtty: " prefix in the subject would be fine.
-mike

Sorry, I'm too sleep deprived, let me NAK my own patch here. The kernel won't recognize a device with PROTO_NONE. Maybe in the future this is how serial consoles should be handled.