Skip to contentSkip to conversation

remove BSD partition number from install_drive/grub_drive in grub-install

PATCH In review Felix Zielcke 4 participants 13 messages Apr 11, 2009 – Apr 15, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 remove BSD partition number from install_drive/grub_drive in grub-install

Hi,

on BSD grub-install thinks that you're wanting to do a cross-install when in fact you won't.
The problem is that in install_drive the BSD partition number isn't removed before doing the cross-install check.
I'm not sure if the regexp is okay so or if it could be better, but at least it works for me.
Though then grub-install still fails with grub-setup: error: cannot open /dev/da0' in open_device()'

Signature · 1 line
Felix Zielcke

2009-04-12 Felix Zielcke <[email protected]>

* util/i386/pc/grub-install.in (install_drive): Remove the BSD partition number.
(grub_drive): Likewise.

i386/pc/grub-install.in +2 -2
Index: util/i386/pc/grub-install.in
===================================================================
@@ -262,8 +262,8 @@ if [ "x${devabstraction_module}" = "x" ]
     grub_drive="`$grub_probe --target=drive --device ${grub_device}`"
 
     # Strip partition number
-    install_drive="`echo ${install_drive} | sed -e s/,[0-9]*//g`"
-    grub_drive="`echo ${grub_drive} | sed -e s/,[0-9]*//g`"
+    install_drive="`echo ${install_drive} | sed -e s/,[0-9]*[a-z]*//g`"
+    grub_drive="`echo ${grub_drive} | sed -e s/,[0-9]*[a-z]*//g`"
     if [ "${target_cpu}-${platform}" != "i386-pc" ] ; then
         # generic method (used on coreboot)
         uuid="`$grub_probe --target=fs_uuid --device ${grub_device}`"
#1 lore raw

Which BSD?

Quoted 19 lines · Felix Zielcke

Hi,

on BSD grub-install thinks that you're wanting to do a cross-install when in fact you won't.
The problem is that in install_drive the BSD partition number isn't removed before doing the cross-install check.
I'm not sure if the regexp is okay so or if it could be better, but at least it works for me.
Though then grub-install still fails with grub-setup: error: cannot open /dev/da0' in open_device()'
--
Felix Zielcke

_______________________________________________
Grub-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/grub-devel

#2 lore raw

Am Sonntag, den 12.04.2009, 09:45 +1000 schrieb Chip Panarchy:

Quoted 2 lines

Which BSD?

Debian GNU/kFreeBSD-amd64

Signature · 1 line
Felix Zielcke
#3 lore raw

Hi

Ah, interesting.

I've been trying to get a feature added to GRUB2 to do with FreeBSD-amd64. That is to give GRUB2 the feature which allows for direct 'calling' of the 64-bit FreeBSD kernel. GRUB2 currently supports only the 32-bit version.

If you have the skill, and the time, can you please give a go implementing the above feature(s)?

Thanks in advance,

Panarchy

Quoted 15 lines · Felix Zielcke

Am Sonntag, den 12.04.2009, 09:45 +1000 schrieb Chip Panarchy:

Quoted 2 lines

Which BSD?

Debian GNU/kFreeBSD-amd64
--
Felix Zielcke

_______________________________________________
Grub-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/grub-devel

#4 lore raw

Am Sonntag, den 12.04.2009, 17:12 +1000 schrieb Chip Panarchy:

Quoted 8 lines

Hi

Ah, interesting.

I've been trying to get a feature added to GRUB2 to do with FreeBSD-amd64. That is to give GRUB2 the feature which allows for direct 'calling' of the 64-bit FreeBSD kernel. GRUB2 currently supports only the 32-bit version.

Oh I forgot already that I read this even here that 64bit doestn't work.

Quoted 3 lines

If you have the skill, and the time, can you please give a go implementing the above feature(s)?

Well I don't have any experience at all with BSD, I doubt I could figure this out.

Signature · 1 line
Felix Zielcke
#5 lore raw
In reply to Chip Panarchy

Please, don't bother developers with same request in multiple threads. Not only it doesn't help to promote your suggestion but is also annoying. I feel it is actually unnice how you push your suggestions hardly without offering any help in developement

Quoted 37 lines · Chip Panarchy

Hi

Ah, interesting.

I've been trying to get a feature added to GRUB2 to do with FreeBSD-amd64. That is to give GRUB2 the feature which allows for direct 'calling' of the 64-bit FreeBSD kernel. GRUB2 currently supports only the 32-bit version.

If you have the skill, and the time, can you please give a go implementing the above feature(s)?

Thanks in advance,

Panarchy

Quoted 9 lines · Felix Zielcke

Am Sonntag, den 12.04.2009, 09:45 +1000 schrieb Chip Panarchy:

Quoted 2 lines

Which BSD?

Debian GNU/kFreeBSD-amd64
--
Felix Zielcke

Quoted 5 lines

_______________________________________________
Grub-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/grub-devel

_______________________________________________
Grub-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/grub-devel

Signature · 2 lines
Regards
Vladimir 'phcoder' Serbinenko
#6 lore raw

You're right.

Once I have all my operating systems installed, working correctly, have successfully created my 2 Linux distributions, have some time off (starting work tomorrow!), then I will learn some C++, and help with the development of software like GRUB2.

In the meantime, I will have to leech of others... as it were.

Sorry if I am/have sounded rude, that was not my intention.

Please continue helping me out PHcoder.

Thanks in advance,

Panarchy

Quoted 58 lines · phcoder

Please, don't bother developers with same request in multiple threads. Not only it doesn't help to promote your suggestion but is also annoying. I feel it is actually unnice how you push your suggestions hardly without offering any help in developement

Quoted 36 lines · Chip Panarchy

Hi

Ah, interesting.

I've been trying to get a feature added to GRUB2 to do with FreeBSD-amd64. That is to give GRUB2 the feature which allows for direct 'calling' of the 64-bit FreeBSD kernel. GRUB2 currently supports only the 32-bit version.

If you have the skill, and the time, can you please give a go implementing the above feature(s)?

Thanks in advance,

Panarchy

Quoted 11 lines · Felix Zielcke

Am Sonntag, den 12.04.2009, 09:45 +1000 schrieb Chip Panarchy:

Quoted 3 lines

Which BSD?

Debian GNU/kFreeBSD-amd64
--
Felix Zielcke

Quoted 5 lines

_______________________________________________
Grub-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/grub-devel

Quoted 4 lines

_______________________________________________
Grub-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/grub-devel

--

Regards
Vladimir 'phcoder' Serbinenko

_______________________________________________
Grub-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/grub-devel

#7 lore raw

Hello, I'm sorry if my responses have been a bit rude too.

Quoted 7 lines · Chip Panarchy

You're right.

Once I have all my operating systems installed, working correctly, have successfully created my 2 Linux distributions, have some time off (starting work tomorrow!), then I will learn some C++, and help with the development of software like GRUB2.

grub2 doesn't use any C++, only pure C

Quoted 1 line

Please continue helping me out PHcoder.

You once spoke about xnu code for grub2. I'm happy to announce that this code is near its completion. I have some strange bugs in it and some incompletenesses but code itself already works

Quoted 65 lines

Thanks in advance,

Panarchy

Quoted 44 lines · phcoder

Please, don't bother developers with same request in multiple threads. Not only it doesn't help to promote your suggestion but is also annoying. I feel it is actually unnice how you push your suggestions hardly without offering any help in developement

Quoted 32 lines · Chip Panarchy

Hi

Ah, interesting.

I've been trying to get a feature added to GRUB2 to do with FreeBSD-amd64. That is to give GRUB2 the feature which allows for direct 'calling' of the 64-bit FreeBSD kernel. GRUB2 currently supports only the 32-bit version.

If you have the skill, and the time, can you please give a go implementing the above feature(s)?

Thanks in advance,

Panarchy

Quoted 9 lines · Felix Zielcke

Am Sonntag, den 12.04.2009, 09:45 +1000 schrieb Chip Panarchy:

Quoted 2 lines

Which BSD?

Debian GNU/kFreeBSD-amd64
--
Felix Zielcke

Quoted 5 lines

_______________________________________________
Grub-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/grub-devel

Quoted 4 lines

_______________________________________________
Grub-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/grub-devel

--

Quoted 9 lines

Regards
Vladimir 'phcoder' Serbinenko

_______________________________________________
Grub-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/grub-devel

_______________________________________________
Grub-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/grub-devel

Signature · 2 lines
Regards
Vladimir 'phcoder' Serbinenko
#8 lore raw

Hello

Great, looking forward to its completion.

Panarchy

Quoted 102 lines · phcoder

Hello, I'm sorry if my responses have been a bit rude too.

Quoted 8 lines · Chip Panarchy

You're right.

Once I have all my operating systems installed, working correctly, have successfully created my 2 Linux distributions, have some time off (starting work tomorrow!), then I will learn some C++, and help with the development of software like GRUB2.

grub2 doesn't use any C++, only pure C

Quoted 2 lines

Please continue helping me out PHcoder.

You once spoke about xnu code for grub2. I'm happy to announce that this code is near its completion. I have some strange bugs in it and some incompletenesses but code itself already works

Quoted 68 lines

Thanks in advance,

Panarchy

Quoted 51 lines · phcoder

Please, don't bother developers with same request in multiple threads. Not
only it doesn't help to promote your suggestion but is also annoying. I feel
it is actually unnice how you push your suggestions hardly without offering
any help in developement

Quoted 35 lines · Chip Panarchy

Hi

Ah, interesting.

I've been trying to get a feature added to GRUB2 to do with FreeBSD-amd64. That is to give GRUB2 the feature which allows for direct 'calling' of the 64-bit FreeBSD kernel. GRUB2 currently supports only the 32-bit version.

If you have the skill, and the time, can you please give a go implementing the above feature(s)?

Thanks in advance,

Panarchy

Quoted 11 lines · Felix Zielcke

Am Sonntag, den 12.04.2009, 09:45 +1000 schrieb Chip Panarchy:

Quoted 3 lines

Which BSD?

Debian GNU/kFreeBSD-amd64
--
Felix Zielcke

Quoted 5 lines

_______________________________________________
Grub-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/grub-devel

Quoted 4 lines

_______________________________________________
Grub-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/grub-devel

--

Quoted 9 lines

Regards
Vladimir 'phcoder' Serbinenko

_______________________________________________
Grub-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/grub-devel

Quoted 4 lines

_______________________________________________
Grub-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/grub-devel

--

Regards
Vladimir 'phcoder' Serbinenko

_______________________________________________
Grub-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/grub-devel

#9 lore raw
In reply to Felix Zielcke

Am Samstag, den 11.04.2009, 23:52 +0200 schrieb Felix Zielcke:

Quoted 8 lines

Hi,

on BSD grub-install thinks that you're wanting to do a cross-install when in fact you won't.
The problem is that in install_drive the BSD partition number isn't removed before doing the cross-install check.
I'm not sure if the regexp is okay so or if it could be better, but at least it works for me.

I commited this now.
All other variants of the regexp I tried didn't work except that one.

Signature · 1 line
Felix Zielcke
#10 lore raw

Awesome.

BTW: How do these update to GRUB2 work, I mean to the patches, once proven automatically get integrated into GRUB2 (and released to the official website)?

Quoted 22 lines · Felix Zielcke

Am Samstag, den 11.04.2009, 23:52 +0200 schrieb Felix Zielcke:

Quoted 8 lines

Hi,

on BSD grub-install thinks that you're wanting to do a cross-install when in fact you won't.
The problem is that in install_drive the BSD partition number isn't removed before doing the cross-install check.
I'm not sure if the regexp is okay so or if it could be better, but at least it works for me.

I commited this now.
All other variants of the regexp I tried didn't work except that one. --
Felix Zielcke

_______________________________________________
Grub-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/grub-devel

#11 lore raw

You can checkout the code via:
svn co svn://svn.savannah.gnu.org/grub/trunk/grub2

Then use the autocompile.sh script that was posted earlier to make builds of grub2 or you can wait for the nightly autobuilder to be set-up and just download its results (from wherever they will be announced).

GRUB2 is not making frequent stable releases yet.

-joey

Quoted 6 lines · Chip Panarchy

Awesome.

BTW: How do these update to GRUB2 work, I mean to the patches, once proven automatically get integrated into GRUB2 (and released to the official website)?

#12 lore raw

Hello

Great, thanks.

Quoted 26 lines · Joey Korkames

You can checkout the code via:
svn co svn://svn.savannah.gnu.org/grub/trunk/grub2
Then use the autocompile.sh script that was posted earlier to make builds of grub2 or you can wait for the nightly autobuilder to be set-up and just download its results (from wherever they will be announced).

GRUB2 is not making frequent stable releases yet.

-joey

Quoted 6 lines · Chip Panarchy

Awesome.

BTW: How do these update to GRUB2 work, I mean to the patches, once proven automatically get integrated into GRUB2 (and released to the official website)?

_______________________________________________
Grub-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/grub-devel