Skip to contentSkip to conversation

How SHOULD inotify and hardlinks play together?

DISCUSSION Eric Paris 1 participant 1 message Apr 15, 2009 VFS

lore
Share & tools
lore

Eric Paris

author
#0 lore raw

touch /tmp/file1 /tmp/file2
ln /tmp/file2 /tmp/hardlinktofile2

[A] Set up one inotify watch on /tmp/file2
[B] Set up another inotify watch on /tmp/hardlinktofile2

(they are both watching the same inode/data)

mv /tmp/file1 /tmp/file2

Right now, today, both [A] and [B] are going to get DELETE_SELF and IGNORED messages and are not going to get any more notifications.

That might be fine for [A] since the pathname it ask to watch doesn't exist any more (although I argue the inode still does), but that isn't right for [B] since /tmp/hardlinktofile2 is still there, still it's own inode, and still able to receive events, be modified, be read, be deleted, whatever. But after that mv operation neither [A] nor [B] will get any more events what-so-ever.

So the question is, should inotify continue to clear all watches on an inode when something else is moved on top if it even if i_nlink isn't going to 0? If not, should inotify continue to send a DELETE_SELF like it does today? Should it instead send an ATTRIB like it does when you add a hard link?

-Eric