Skip to contentSkip to conversation

OMAP3: Board specific updates

PATCH Superseded Sanjeev Premi 4 participants 6 messages Apr 27, 2009

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v3 cover OMAP3: Board specific updates

This series contains 3 specific updates:
- Use common API to print cpu and board
related information.
- Remove unused board type definitions.
- Print correct silicon revision in the
board information

These updates have been tested on OMAP3EVM
with ES 3.0 and ES3.1 silicon versions.

Thanks to Dirk Behme [dirk.behme at googlemail.com] for converting a quick hack into complete solution.

Sanjeev Premi (3):
OMAP3: Use functions print_cpuinfo() and checkboard()
OMAP3: Remove unused board-types
OMAP3: Print correct silicon revision

 board/omap3/beagle/beagle.h            |    2 -
 board/omap3/evm/evm.h                  |    2 -
 board/omap3/overo/overo.h              |    2 -
 board/omap3/pandora/pandora.h          |    2 -
 board/omap3/zoom1/zoom1.h              |    2 -
 cpu/arm_cortexa8/cpu.c                 |    4 +-
 cpu/arm_cortexa8/omap3/board.c         |   24 ++++-
 cpu/arm_cortexa8/omap3/clock.c         |    5 +-
 cpu/arm_cortexa8/omap3/sys_info.c      |  145 +++++++++++++++-----------------
 include/asm-arm/arch-omap3/omap3.h     |   22 ++---
 include/asm-arm/arch-omap3/sys_proto.h |    4 -
 include/configs/omap3_beagle.h         |    6 ++
 include/configs/omap3_evm.h            |    7 ++-
 include/configs/omap3_overo.h          |    6 ++
 include/configs/omap3_pandora.h        |    6 ++
 include/configs/omap3_zoom1.h          |    6 ++
 16 files changed, 131 insertions(+), 114 deletions(-)
#1 lore raw

v3 cover OMAP3: Board specific updates

Hi Premi,

Quoted 10 lines · Sanjeev Premi

This series contains 3 specific updates:
- Use common API to print cpu and board
related information.
- Remove unused board type definitions.
- Print correct silicon revision in the
board information

These updates have been tested on OMAP3EVM
with ES 3.0 and ES3.1 silicon versions.

Quoted 8 lines

Thanks to Dirk Behme [dirk.behme at googlemail.com] for converting a quick hack into complete solution.

Sanjeev Premi (3):
OMAP3: Use functions print_cpuinfo() and checkboard()
OMAP3: Remove unused board-types
OMAP3: Print correct silicon revision

Applying all 3 patches I get

sys_info.c: In function 'print_cpuinfo':
sys_info.c:297: warning: no return statement in function returning non-void
board.c: In function 'checkboard':
board.c:349: warning: implicit declaration of function 'is_mem_sdr' board.c:357: warning: no return statement in function returning non-void

Not sure which patch it is, though.

Best regards

Dirk

Btw.: You can easily check this by doing a

./MAKEALL ARM_CORTEX_A8

#2 lore raw

v3 cover OMAP3: Board specific updates

Quoted 32 lines

-----Original Message-----
From: Dirk Behme [mailto:dirk.behme at googlemail.com]
Sent: Monday, April 27, 2009 8:47 PM
To: Premi, Sanjeev
Cc: u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCHv3 0/3] OMAP3: Board specific updates

Hi Premi,

Quoted 10 lines · Sanjeev Premi

This series contains 3 specific updates:
- Use common API to print cpu and board
related information.
- Remove unused board type definitions.
- Print correct silicon revision in the
board information

These updates have been tested on OMAP3EVM
with ES 3.0 and ES3.1 silicon versions.

Quoted 8 lines

Thanks to Dirk Behme [dirk.behme at googlemail.com] for converting a quick hack into complete solution.

Sanjeev Premi (3):
OMAP3: Use functions print_cpuinfo() and checkboard()
OMAP3: Remove unused board-types
OMAP3: Print correct silicon revision

Applying all 3 patches I get

Quoted 8 lines

sys_info.c: In function 'print_cpuinfo':
sys_info.c:297: warning: no return statement in function returning non-void
board.c: In function 'checkboard':
board.c:349: warning: implicit declaration of function 'is_mem_sdr' board.c:357: warning: no return statement in function returning non-void

I usually do a distclean followed by make; but let me do this again.

~sanjeev

Quoted 12 lines

Not sure which patch it is, though.

Best regards

Dirk

Btw.: You can easily check this by doing a

./MAKEALL ARM_CORTEX_A8

#3 lore raw

v3 cover OMAP3: Board specific updates

Quoted 49 lines

-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Premi, Sanjeev
Sent: Monday, April 27, 2009 8:49 PM
To: Dirk Behme
Cc: u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCHv3 0/3] OMAP3: Board specific updates

Quoted 31 lines

-----Original Message-----
From: Dirk Behme [mailto:dirk.behme at googlemail.com]
Sent: Monday, April 27, 2009 8:47 PM
To: Premi, Sanjeev
Cc: u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCHv3 0/3] OMAP3: Board specific updates

Hi Premi,

Quoted 10 lines · Sanjeev Premi

This series contains 3 specific updates:
- Use common API to print cpu and board
related information.
- Remove unused board type definitions.
- Print correct silicon revision in the
board information

These updates have been tested on OMAP3EVM
with ES 3.0 and ES3.1 silicon versions.

Quoted 8 lines

Thanks to Dirk Behme [dirk.behme at googlemail.com] for converting a quick hack into complete solution.

Sanjeev Premi (3):
OMAP3: Use functions print_cpuinfo() and checkboard()
OMAP3: Remove unused board-types
OMAP3: Print correct silicon revision

Applying all 3 patches I get

Quoted 8 lines

sys_info.c: In function 'print_cpuinfo':
sys_info.c:297: warning: no return statement in function returning non-void
board.c: In function 'checkboard':
board.c:349: warning: implicit declaration of function 'is_mem_sdr' board.c:357: warning: no return statement in function returning non-void

Quoted 1 line

I usually do a distclean followed by make; but let me do this again.

Yeah. found it... a miss in interactive commit 3/3.

Should I re-submit the whole series?
OR
Is it okay to re-send just the last one.

~sanjeev

Quoted 21 lines

~sanjeev

Quoted 12 lines

Not sure which patch it is, though.

Best regards

Dirk

Btw.: You can easily check this by doing a

./MAKEALL ARM_CORTEX_A8

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

#4 lore raw

v3 cover OMAP3: Board specific updates

Quoted 47 lines · Sanjeev
Quoted 47 lines

-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Premi, Sanjeev
Sent: Monday, April 27, 2009 8:49 PM
To: Dirk Behme
Cc: u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCHv3 0/3] OMAP3: Board specific updates

Quoted 38 lines

-----Original Message-----
From: Dirk Behme [mailto:dirk.behme at googlemail.com]
Sent: Monday, April 27, 2009 8:47 PM
To: Premi, Sanjeev
Cc: u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCHv3 0/3] OMAP3: Board specific updates

Hi Premi,

Quoted 10 lines · Sanjeev Premi

This series contains 3 specific updates:
- Use common API to print cpu and board
related information.
- Remove unused board type definitions.
- Print correct silicon revision in the
board information

These updates have been tested on OMAP3EVM
with ES 3.0 and ES3.1 silicon versions.

Quoted 8 lines

Thanks to Dirk Behme [dirk.behme at googlemail.com] for converting a quick hack into complete solution.

Sanjeev Premi (3):
OMAP3: Use functions print_cpuinfo() and checkboard()
OMAP3: Remove unused board-types
OMAP3: Print correct silicon revision

Applying all 3 patches I get

sys_info.c: In function 'print_cpuinfo':
sys_info.c:297: warning: no return statement in function returning non-void
board.c: In function 'checkboard':
board.c:349: warning: implicit declaration of function 'is_mem_sdr' board.c:357: warning: no return statement in function returning non-void

Quoted 7 lines
Quoted 1 line

I usually do a distclean followed by make; but let me do this again.

Yeah. found it... a miss in interactive commit 3/3.

Should I re-submit the whole series?
OR
Is it okay to re-send just the last one.

I'm not a custodian, but last one marked with 'v4' should be sufficient from my point of view.

Best regards

Dirk

Quoted 22 lines

~sanjeev

Quoted 20 lines

~sanjeev

Quoted 12 lines

Not sure which patch it is, though.

Best regards

Dirk

Btw.: You can easily check this by doing a

./MAKEALL ARM_CORTEX_A8

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

#5 lore raw

v3 cover OMAP3: Board specific updates

Dear Dirk Behme,

Quoted 7 lines · In message <[email protected]> you wrote:
Quoted 4 lines

Should I re-submit the whole series?
OR
Is it okay to re-send just the last one.

I'm not a custodian, but last one marked with 'v4' should be sufficient from my point of view.

ACK, this is sufficient. Anything else would just be a waste of bandwidth and storage space.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I think there's a world market for about five computers.
         -- attr. Thomas J. Watson (Chairman of the Board, IBM), 1943