Skip to contentSkip to conversation

mfd: Mark WM8350 mask revision as readable to match silicon

PATCH In review Mark Brown 3 participants 4 messages Apr 30, 2009 – May 4, 2009

Subsystems (2)
lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 mfd: Mark WM8350 mask revision as readable to match silicon

No impact unless someone has written additional kernel code.

---
 drivers/mfd/wm8350-regmap.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mfd/wm8350-regmap.c +1 -1
index 9a4cc95..97d6aad 100644
@@ -3186,7 +3186,7 @@ const struct wm8350_reg_access wm8350_reg_io_map[] = {
 	/*  read    write volatile */
 	{ 0xFFFF, 0xFFFF, 0xFFFF }, /* R0   - Reset/ID */
 	{ 0x7CFF, 0x0C00, 0x7FFF }, /* R1   - ID */
-	{ 0x0000, 0x0000, 0x0000 }, /* R2 */
+	{ 0x007F, 0x0000, 0x0000 }, /* R2   - ROM Mask ID */
 	{ 0xBE3B, 0xBE3B, 0x8000 }, /* R3   - System Control 1 */
 	{ 0xFEF7, 0xFEF7, 0xF800 }, /* R4   - System Control 2 */
 	{ 0x80FF, 0x80FF, 0x8000 }, /* R5   - System Hibernate */
Signature · 1 line
1.6.2.4
#1 lore raw

Hi Mark,

Quoted 1 line · Mark Brown

No impact unless someone has written additional kernel code.

All 3 patches applied to my for-next branch, thanks.

Cheers,
Samuel.

Quoted 21 lines
---
 drivers/mfd/wm8350-regmap.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mfd/wm8350-regmap.c +1 -1
index 9a4cc95..97d6aad 100644
@@ -3186,7 +3186,7 @@ const struct wm8350_reg_access wm8350_reg_io_map[] = {
 	/*  read    write volatile */
 	{ 0xFFFF, 0xFFFF, 0xFFFF }, /* R0   - Reset/ID */
 	{ 0x7CFF, 0x0C00, 0x7FFF }, /* R1   - ID */
-	{ 0x0000, 0x0000, 0x0000 }, /* R2 */
+	{ 0x007F, 0x0000, 0x0000 }, /* R2   - ROM Mask ID */
 	{ 0xBE3B, 0xBE3B, 0x8000 }, /* R3   - System Control 1 */
 	{ 0xFEF7, 0xFEF7, 0xF800 }, /* R4   - System Control 2 */
 	{ 0x80FF, 0x80FF, 0x8000 }, /* R5   - System Hibernate */
Signature · 1 line
1.6.2.4
Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/
#2 lore raw
Quoted 5 lines · Samuel Ortiz
Quoted 1 line · Mark Brown

No impact unless someone has written additional kernel code.

All 3 patches applied to my for-next branch, thanks.

At least the patch for the caching of volatile registers really ought to go into 2.6.30 if possible - not having it breaks the audio driver for the chip.

#3 lore raw
Quoted 10 lines · Mark Brown
Quoted 5 lines · Samuel Ortiz
Quoted 1 line · Mark Brown

No impact unless someone has written additional kernel code.

All 3 patches applied to my for-next branch, thanks.

At least the patch for the caching of volatile registers really ought to go into 2.6.30 if possible - not having it breaks the audio driver for the chip.

Yes, I'll include it to one of my 2.6.30 pull requests.

Cheers,
Samuel.

Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/