Skip to contentSkip to conversation

Do not __always_inline bvec_kmap_irq() and bvec_kunmap_irq()

PATCH New Alberto Bertogli 1 participant 1 message May 20, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 3/4 Do not __always_inline bvec_kmap_irq() and bvec_kunmap_irq()

Quoted 1 line · Andrew Morton

The comment is wrong - this was a sparc requirement, long since removed.

So remove both the comment and the inline requirement, going back to the inline hint.

---
 include/linux/bio.h |    8 ++------
 1 files changed, 2 insertions(+), 6 deletions(-)
include/linux/bio.h +2 -6
index 7b214fd..df8fef0 100644
@@ -452,11 +452,8 @@ extern struct biovec_slab bvec_slabs[BIOVEC_NR_POOLS] __read_mostly;
 /*
  * remember never ever reenable interrupts between a bvec_kmap_irq and
  * bvec_kunmap_irq!
- *
- * This function MUST be inlined - it plays with the CPU interrupt flags.
  */
-static __always_inline char *bvec_kmap_irq(struct bio_vec *bvec,
-		unsigned long *flags)
+static inline char *bvec_kmap_irq(struct bio_vec *bvec, unsigned long *flags)
 {
 	unsigned long addr;
 
@@ -472,8 +469,7 @@ static __always_inline char *bvec_kmap_irq(struct bio_vec *bvec,
 	return (char *) addr + bvec->bv_offset;
 }
 
-static __always_inline void bvec_kunmap_irq(char *buffer,
-		unsigned long *flags)
+static inline void bvec_kunmap_irq(char *buffer, unsigned long *flags)
 {
 	unsigned long ptr = (unsigned long) buffer & PAGE_MASK;
 
Signature · 1 line
1.6.2.2.646.gb214