Skip to contentSkip to conversation

sdhci: consider ADMA error interrupt as data interrupt

PATCH In review Ben Dooks 2 participants 2 messages May 29, 2009

Subsystems (2)
lore
Share & tools
lore

Ben Dooks

author
#0 lore raw

PATCH 1/1 sdhci: consider ADMA error interrupt as data interrupt

Currently any SDHCI_INT_ADMA_ERROR response is processed by sdhci_data_irq() producing an -EIO for the transfer, but is not in the SDHCI_INT_DATA_MASK so sdhci_irq() produces a warning of "Unexpected interrupt 0x02000000".

---
 drivers/mmc/host/sdhci.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mmc/host/sdhci.h +1 -1
index f20a834..c9dd8bf 100644
@@ -125,7 +125,7 @@
 #define  SDHCI_INT_DATA_MASK	(SDHCI_INT_DATA_END | SDHCI_INT_DMA_END | \
 		SDHCI_INT_DATA_AVAIL | SDHCI_INT_SPACE_AVAIL | \
 		SDHCI_INT_DATA_TIMEOUT | SDHCI_INT_DATA_CRC | \
-		SDHCI_INT_DATA_END_BIT)
+		SDHCI_INT_DATA_END_BIT | SDHCI_INT_ADMA_ERROR)
 #define SDHCI_INT_ALL_MASK	((unsigned int)-1)
 
 #define SDHCI_ACMD12_ERR	0x3C
Signature · 1 line
1.5.6.5
#1 lore raw
Quoted 6 lines · On Fri, 29 May 2009 14:35:59 +0100 Ben Dooks <[email protected]> wrote:

Currently any SDHCI_INT_ADMA_ERROR response is processed by sdhci_data_irq() producing an -EIO for the transfer, but is not in the SDHCI_INT_DATA_MASK so sdhci_irq() produces a warning of "Unexpected interrupt 0x02000000".

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=4accfe2577fab83e41db02282570e849f24ddf53

;)

Rgds

Signature · 6 lines
     -- Pierre Ossman

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.