Skip to contentSkip to conversation

mpc512x: Fix problem with I2C access before relocation

PATCH New Stefan Roese 3 participants 7 messages Jun 8, 2009 – Jun 12, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mpc512x: Fix problem with I2C access before relocation

This is needed for the upcoming esd MECP5123 board port which uses I2C EEPROM for environment storage.

---
 cpu/mpc512x/i2c.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
cpu/mpc512x/i2c.c +1 -1
index 97bda0d..e2d9097 100644
@@ -33,7 +33,7 @@ DECLARE_GLOBAL_DATA_PTR;
 #include <i2c.h>
 
 /* by default set I2C bus 0 active */
-static unsigned int bus_num = 0;
+static unsigned int bus_num __attribute__ ((section (".data"))) = 0;
 
 #define I2C_TIMEOUT	100
 #define I2C_RETRIES	3
Signature · 1 line
1.6.3.2
#1 lore raw

PATCH 1/1 mpc512x: Fix problem with I2C access before relocation

Dear Stefan Roese,

Quoted 2 lines · In message <[email protected]> you wrote:

This is needed for the upcoming esd MECP5123 board port which uses I2C EEPROM for environment storage.

Stefan, please check if this is really what you want to do. Environmentin EEPROM is *strongly* discouraged. It is slow like hell, and even more unreliable. Do *not* do this. Check if you can use any other storage - NOR or NAND flash, or the like.

Quoted 5 lines
---
 cpu/mpc512x/i2c.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Heiko, if Stefan does not change his mind, then I suggest you ACK the patch and I apply it then to the 5xxx repo?

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Those who do not  understand  Unix  are  condemned  to  reinvent  it,
poorly.              - Henry Spencer, University of Toronto Unix hack
#2 lore raw

PATCH 1/1 mpc512x: Fix problem with I2C access before relocation

Hello Wolfgang,

Quoted 11 lines · Wolfgang Denk

Dear Stefan Roese,

Quoted 2 lines · In message <[email protected]> you wrote:

This is needed for the upcoming esd MECP5123 board port which uses I2C EEPROM for environment storage.

Stefan, please check if this is really what you want to do. Environmentin EEPROM is *strongly* discouraged. It is slow like hell, and even more unreliable. Do *not* do this. Check if you can use any other storage - NOR or NAND flash, or the like.

Quoted 8 lines
Quoted 5 lines
---
 cpu/mpc512x/i2c.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Heiko, if Stefan does not change his mind, then I suggest you ACK the patch and I apply it then to the 5xxx repo?

This Patch is okay, independent if Stefan changes his mind or not, I think. Thanks to Stefan for finding this.

bye
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#3 lore raw

PATCH 1/1 mpc512x: Fix problem with I2C access before relocation

Quoted 14 lines · On Monday 08 June 2009 12:33:01 Heiko Schocher wrote:
Quoted 14 lines
Quoted 2 lines

This is needed for the upcoming esd MECP5123 board port which uses I2C EEPROM for environment storage.

Stefan, please check if this is really what you want to do. Environmentin EEPROM is *strongly* discouraged. It is slow like hell, and even more unreliable. Do *not* do this. Check if you can use any other storage - NOR or NAND flash, or the like.

Quoted 5 lines
---
 cpu/mpc512x/i2c.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Quoted 5 lines
Quoted 2 lines

Heiko, if Stefan does not change his mind, then I suggest you ACK the patch and I apply it then to the 5xxx repo?

This Patch is okay, independent if Stefan changes his mind or not, I think. Thanks to Stefan for finding this.

Full ACK. This is a bugfix and should be applied in any case.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================

#4 lore raw

PATCH 1/1 mpc512x: Fix problem with I2C access before relocation

In reply to Wolfgang Denk

Hi Wolfgang,

Quoted 7 lines · On Monday 08 June 2009 12:25:01 Wolfgang Denk wrote:
Quoted 2 lines

This is needed for the upcoming esd MECP5123 board port which uses I2C EEPROM for environment storage.

Stefan, please check if this is really what you want to do. Environmentin EEPROM is *strongly* discouraged. It is slow like hell, and even more unreliable. Do *not* do this. Check if you can use any other storage - NOR or NAND flash, or the like.

I know that EEPROM has some disadvantages. But this is not my choice but the customers (esd) decision. esd has used I2C EEPROM for environment storage for a long time and even included write-protection to the EEPROM.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================

#5 lore raw

PATCH 1/1 mpc512x: Fix problem with I2C access before relocation

Dear Stefan Roese,

Quoted 4 lines · In message <[email protected]> you wrote:

I know that EEPROM has some disadvantages. But this is not my choice but the customers (esd) decision. esd has used I2C EEPROM for environment storage for a long time and even included write-protection to the EEPROM.

That's OK if they insist. But it is due diligence to at least point out the potential trouble they are inviting. Which we have done hereby.

But out of curiosity: please do me a favour and measure the time from power-up to U-Boot prompt. Then "setenv baudrate 115200; saveenv" and measure again. Thanks in advance.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Death. Destruction. Disease. Horror. That's what war  is  all  about.
That's what makes it a thing to be avoided.
	-- Kirk, "A Taste of Armageddon", stardate 3193.0
#6 lore raw

PATCH 1/1 mpc512x: Fix problem with I2C access before relocation

In reply to Stefan Roese

Dear Stefan Roese,

Quoted 8 lines · In message <[email protected]> you wrote:

This is needed for the upcoming esd MECP5123 board port which uses I2C EEPROM for environment storage.

---
 cpu/mpc512x/i2c.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Applied to u-boot-mpc5xxx repo, thanks.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I perceive a possibility of an immediate  chronological  sequence  of
events which includes a violence.
                        - Terry Pratchett, _The Dark Side of the Sun_