Skip to contentSkip to conversation

char: prevent opening unavailable ports in moxa.c

PATCH In review Dirk Eibach 2 participants 2 messages Jun 9, 2009 – Jun 10, 2009 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 char: prevent opening unavailable ports in moxa.c

In moxa.c there are 32 minor numbers reserved for each device. The number of ports actually available per device is stored in moxa_board_conf->numPorts. This number is not considered in moxa_open(). Opening a port that is not available results in a kernel oops. This patch adds a test to moxa_open() that prevents opening unavailable ports.

---
 drivers/char/moxa.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
drivers/char/moxa.c +5 -0
index 4a4cab7..65b6ff2 100644
@@ -1184,6 +1184,11 @@ static int moxa_open(struct tty_struct *tty, struct file *filp)
 		return -ENODEV;
 	}
 
+	if (port % MAX_PORTS_PER_BOARD >= brd->numPorts) {
+		mutex_unlock(&moxa_openlock);
+		return -ENODEV;
+	}
+
 	ch = &brd->ports[port % MAX_PORTS_PER_BOARD];
 	ch->port.count++;
 	tty->driver_data = ch;
Signature · 1 line
1.5.6.5
#1 lore raw
Quoted 8 lines · On Tue, 9 Jun 2009 08:57:36 +0200 Dirk Eibach <[email protected]> wrote:

In moxa.c there are 32 minor numbers reserved for each device. The number of ports actually available per device is stored in moxa_board_conf->numPorts. This number is not considered in moxa_open(). Opening a port that is not available results in a kernel oops. This patch adds a test to moxa_open() that prevents opening unavailable ports.

Applied - thanks

Alan