Skip to contentSkip to conversation

uec: Fix compile warning

PATCH New Kumar Gala 2 participants 5 messages Jun 17, 2009 – Jul 23, 2009

lore
Share & tools
lore

Kumar Gala

author
#0 lore raw

PATCH 1/1 uec: Fix compile warning

cpu.c: In function 'cpu_eth_init':
cpu.c:371: warning: implicit declaration of function 'uec_standard_init'

---
 include/netdev.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
include/netdev.h +1 -0
index aed5c4c..92eceb1 100644
@@ -50,6 +50,7 @@ int e1000_initialize(bd_t *bis);
 int eepro100_initialize(bd_t *bis);
 int eth_3com_initialize (bd_t * bis);
 int fec_initialize (bd_t *bis);
+int uec_standard_init(bd_t *bis);
 int greth_initialize(bd_t *bis);
 void gt6426x_eth_initialize(bd_t *bis);
 int inca_switch_initialize(bd_t *bis);
Signature · 1 line
1.6.0.6
author
#1 lore raw

PATCH 1/1 uec: Fix compile warning

Quoted 23 lines · Kumar Gala

cpu.c: In function 'cpu_eth_init':
cpu.c:371: warning: implicit declaration of function 'uec_standard_init'

---
include/netdev.h | 1 +

1 files changed, 1 insertions(+), 0 deletions(-)
include/netdev.h +1 -0
index aed5c4c..92eceb1 100644
@@ -50,6 +50,7 @@ int e1000_initialize(bd_t *bis);
 int eepro100_initialize(bd_t *bis);
 int eth_3com_initialize (bd_t * bis);
 int fec_initialize (bd_t *bis);
+int uec_standard_init(bd_t *bis);
 int greth_initialize(bd_t *bis);
 void gt6426x_eth_initialize(bd_t *bis);
 int inca_switch_initialize(bd_t *bis);
Signature · 1 line
1.6.0.6

Ben,

This should address the warning that Richard reported. Feel free to pick this up via the net tree.

- k

Applied
#2 lore raw

PATCH 1/1 uec: Fix compile warning

In reply to Kumar Gala
Quoted 14 lines · Kumar Gala

cpu.c: In function 'cpu_eth_init':
cpu.c:371: warning: implicit declaration of function 'uec_standard_init'

---
 include/netdev.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
include/netdev.h +0 -0
index aed5c4c..92eceb1 100644

include/netdev.h int e1000_initialize(bd_t *bis); · line 56

Quoted 7 lines
include/netdev.h +1 -0
@@ -50,6 +50,7 @@ int e1000_initialize(bd_t *bis);
 int eepro100_initialize(bd_t *bis);
 int eth_3com_initialize (bd_t * bis);
 int fec_initialize (bd_t *bis);
+int uec_standard_init(bd_t *bis);
 int greth_initialize(bd_t *bis);
 void gt6426x_eth_initialize(bd_t *bis);
 int inca_switch_initialize(bd_t *bis);

Applied to net repo.

thanks,
Ben

#3 lore raw

PATCH 1/1 uec: Fix compile warning

In reply to Kumar Gala
Quoted 14 lines · Kumar Gala

cpu.c: In function 'cpu_eth_init':
cpu.c:371: warning: implicit declaration of function 'uec_standard_init'

---
 include/netdev.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
include/netdev.h +0 -0
index aed5c4c..92eceb1 100644

include/netdev.h int e1000_initialize(bd_t *bis); · line 56

Quoted 7 lines
include/netdev.h +1 -0
@@ -50,6 +50,7 @@ int e1000_initialize(bd_t *bis);
 int eepro100_initialize(bd_t *bis);
 int eth_3com_initialize (bd_t * bis);
 int fec_initialize (bd_t *bis);
+int uec_standard_init(bd_t *bis);
 int greth_initialize(bd_t *bis);
 void gt6426x_eth_initialize(bd_t *bis);
 int inca_switch_initialize(bd_t *bis);

I'm not sure why I applied this - the prototype is already there and this is not sorted alphabetically.

Anyway, reverted and you shouldn't get the warning.

regards,
Ben

author
#4 lore raw

PATCH 1/1 uec: Fix compile warning

Quoted 26 lines · Ben Warren
Quoted 15 lines · Kumar Gala

cpu.c: In function 'cpu_eth_init':
cpu.c:371: warning: implicit declaration of function 'uec_standard_init'

---
include/netdev.h | 1 +

1 files changed, 1 insertions(+), 0 deletions(-)
include/netdev.h +0 -0
index aed5c4c..92eceb1 100644

include/netdev.h int e1000_initialize(bd_t *bis); · line 56

Quoted 7 lines
include/netdev.h +1 -0
@@ -50,6 +50,7 @@ int e1000_initialize(bd_t *bis);
 int eepro100_initialize(bd_t *bis);
 int eth_3com_initialize (bd_t * bis);
 int fec_initialize (bd_t *bis);
+int uec_standard_init(bd_t *bis);
 int greth_initialize(bd_t *bis);
 void gt6426x_eth_initialize(bd_t *bis);
 int inca_switch_initialize(bd_t *bis);

I'm not sure why I applied this - the prototype is already there and this is not sorted alphabetically.

Quoted 1 line

Anyway, reverted and you shouldn't get the warning.

I think part of that was because Wolfgang already applied a similar fix himself.

- k