Skip to contentSkip to conversation

factor out common code for matrix vision boards

PATCH New André Schwarz 2 participants 3 messages Jun 22, 2009 – Jul 17, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 factor out common code for matrix vision boards

MATRIX VISION GmbH, Talstra?e 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Gesch?ftsf?hrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Hans-Joachim Reich -------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-factor-out-common-code.patch
Type: text/x-patch
Size: 6914 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090622/553f802f/attachment-0001.bin

#1 lore raw

PATCH 1/3 factor out common code for matrix vision boards

Dear =?ISO-8859-1?Q?Andr=E9?= Schwarz,

Quoted 4 lines · In message <1245678391.3867.11.camel@swa-m460> you wrote:

factor out common code for Matrix Vision based boards.

Quoted 8 lines
---
 board/matrix_vision/common/Makefile    |   54 ++++++++++++++
 board/matrix_vision/common/mv_common.c |  125 ++++++++++++++++++++++++++++++++
 board/matrix_vision/common/mv_common.h |   25 +++++++
 3 files changed, 204 insertions(+), 0 deletions(-)
 create mode 100644 board/matrix_vision/common/Makefile
 create mode 100644 board/matrix_vision/common/mv_common.c
 create mode 100644 board/matrix_vision/common/mv_common.h

Hm... to me factor out means removing the same part of code form several places and adding a unique copy of it somewhere. But I see only added code, none removed?

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"In matters of principle, stand like a rock;  in  matters  of  taste,
swim with the current."                            - Thomas Jefferson
#2 lore raw

PATCH 1/3 factor out common code for matrix vision boards

Quoted 16 lines · Wolfgang Denk

Dear =?ISO-8859-1?Q?Andr=E9?= Schwarz,

Quoted 4 lines · In message <1245678391.3867.11.camel@swa-m460> you wrote:

factor out common code for Matrix Vision based boards.

Quoted 8 lines
---
 board/matrix_vision/common/Makefile    |   54 ++++++++++++++
 board/matrix_vision/common/mv_common.c |  125 ++++++++++++++++++++++++++++++++
 board/matrix_vision/common/mv_common.h |   25 +++++++
 3 files changed, 204 insertions(+), 0 deletions(-)
 create mode 100644 board/matrix_vision/common/Makefile
 create mode 100644 board/matrix_vision/common/mv_common.c
 create mode 100644 board/matrix_vision/common/mv_common.h
Quoted 3 lines

Hm... to me factor out means removing the same part of code form several places and adding a unique copy of it somewhere. But I see only added code, none removed?

yes - looks like I've chosen the wrong expression/description. Will provide new patches with descriptions more suitable.

Regards,

Andr??

Quoted 5 lines

Best regards,

Wolfgang Denk

MATRIX VISION GmbH, Talstra?e 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Gesch?ftsf?hrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Hans-Joachim Reich