FS: btrfs, don't touch freed memory

PATCH In review Jiri Slaby 1 participant 1 message Jun 29, 2009 Btrfs file system

Share & tools

Jiri Slaby

author

2009-06-29 16:01 UTC #0 lore raw

PATCH 3/5 FS: btrfs, don't touch freed memory

worker memory is already freed on one fail path in btrfs_start_workers, but is still dereferenced. Switch the dereference and kfree.

Signed-off-by Jiri Slaby <[email protected]>

---
 fs/btrfs/async-thread.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

fs/btrfs/async-thread.c +1 -1

index 7f88628..6e4f6c5 100644
@@ -299,8 +299,8 @@ int btrfs_start_workers(struct btrfs_workers *workers, int num_workers)
 					   "btrfs-%s-%d", workers->name,
 					   workers->num_workers + i);
 		if (IS_ERR(worker->task)) {
-			kfree(worker);
 			ret = PTR_ERR(worker->task);
+			kfree(worker);
 			goto fail;
 		}

Signature · 1 line

1.6.3.2